New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605548 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 29 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Can't mapping remote to workspace if it has sourcemap

Reported by darkvla...@gmail.com, Apr 21 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/49.0.2623.108 Chrome/49.0.2623.108 Safari/537.36

Steps to reproduce the problem:
1. Add to Workspace folder with sources
2. Try to map remote files to workspace
3. Refresh page, remote files not attached to workspace

What is the expected behavior?
Remote files attached to workspace

What went wrong?
Remote files not attached to workspace

Did this work before? Yes Chrome 48

Chrome version: 49.0.2623.108  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 11.2 r999

I think this problem related to: https://bugs.chromium.org/p/chromium/issues/detail?id=596422
Because sourcemap files have [sm] postfix in this filenames.
 

Comment 1 by allada@chromium.org, Apr 25 2016

Owner: lushnikov@chromium.org
Status: Available (was: Unconfirmed)
Can you remove [sm] postfix from remote files for fixing regression?
In `WebInspector.SourceMap.prototype._parseMap` method remove:

  if (url === this._compiledURL && hasSource)
    url += WebInspector.UIString(" [sm]");


Why less activity in this regression, that blocks developers to edit sources with sourcemaps.
Especially, I write above cause of this problem and what need to do for fixing it.
Note, that since Chrome 51 location changed: `WebInspector.TextSourceMap.prototype._parseMap`
Status: Assigned (was: Available)
Chrome 56 broken still!
It even not working with "Persistence 2.0"
WTF?
Now need patch `SDK.TextSourceMap.prototype._parseSources` by removing:

    if (url === this._compiledURL && source)
        url += Common.UIString(' [sm]');

Why you keep this dirty hack, where file name patches with " [sm]" postfix, while you can visualize it with css!
Status: Started (was: Assigned)
Started: https://codereview.chromium.org/2698183003/
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9614d5a7ab4b1ea2de28ba38edb198c4e7e2a93e

commit 9614d5a7ab4b1ea2de28ba38edb198c4e7e2a93e
Author: lushnikov <lushnikov@chromium.org>
Date: Sat Feb 18 06:36:45 2017

DevTools: teach automapping to map complex sourcemap setups.

Consider a sourcemap with inlined sources, which has one of the source
urls equals to the compiled url.

In this case, we append the ' [sm]' suffix to the source URL so that
the UISourceCode would not clash in the Workspace. (see  crbug.com/562870 ).
This, however, kills the ability to map this file to the workspace.

This patch exploits the ability of automapping to handle query parameters.
By appending '? [sm]' instead of just ' [sm]', the automapping is able
to establish a binding based on the source size.

BUG= 596422 ,  605548 
R=dgozman

Review-Url: https://codereview.chromium.org/2698183003
Cr-Commit-Position: refs/heads/master@{#451430}

[add] https://crrev.com/9614d5a7ab4b1ea2de28ba38edb198c4e7e2a93e/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sourcemap-nameclash-expected.txt
[add] https://crrev.com/9614d5a7ab4b1ea2de28ba38edb198c4e7e2a93e/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sourcemap-nameclash.html
[add] https://crrev.com/9614d5a7ab4b1ea2de28ba38edb198c4e7e2a93e/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/sourcemap-name-clash/out.js
[add] https://crrev.com/9614d5a7ab4b1ea2de28ba38edb198c4e7e2a93e/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/sourcemap-name-clash/out.js.map
[modify] https://crrev.com/9614d5a7ab4b1ea2de28ba38edb198c4e7e2a93e/third_party/WebKit/LayoutTests/http/tests/inspector/text-source-map-expected.txt
[modify] https://crrev.com/9614d5a7ab4b1ea2de28ba38edb198c4e7e2a93e/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js

Status: Fixed (was: Started)
Thanks!
Seemd it not working
Via this issue on github: https://github.com/ChromeDevTools/devtools-frontend/issues/21
@aslushnikov, I see that you try to fix this, by change [sm] -> ? [sm]
https://github.com/ChromeDevTools/devtools-frontend/blob/a4d56feed6c58cb6185a73ceb3b2eb8ac77dd465/front_end/sdk/SourceMap.js#L439
But it not working.
Chrome 58 affected.

Sign in to add a comment