New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605544 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Casting the first video from abc13.com/live fails

Project Member Reported by avayvod@chromium.org, Apr 21 2016

Issue description

Version: 49.0.2623.105 (Official Build) (32-bit) and above all the way to the Canary build
OS: Android 6.0.1; Nexus 6P Build/MTC19R

What steps will reproduce the problem?
(1) Go to abc13.com/live
(2) Play the first video on the page
(3) Cast the video using the Cast icon in the media controls

What is the expected output?

The video playback continues on the Cast device

What do you see instead?

The Chrome player is loaded but then stops and the Cast device goes back to the background image. Chrome switches back to local playback.

See internal issue at b/28290577
 
Status: Started (was: Assigned)
The issue seems to be that the Android Cast SDK receives the URL with an unescaped parameter that is not recognized by the server when fetched by the Cast device:

- escaped, working URL:

http://content.uplynk.com
/channel/ext/1efe3bfc4d1e4b5db5e5085a535b510b/KTRKwatch.m3u8
?tc=1
&exp=1461257066933
&rn=9209.113141206697
&ct=c
&oid=1efe3bfc4d1e4b5db5e5085a535b510b
&eid=KTRKwatch
&ad=watchktrklive
&ad.adUnit=midroll
&ad.flex=0
&ad._v=2
&ad.kv=station%2Cktrk%2C_fw_vcid2%2Cd015_6276049784806122024%2Cdatg_yx_bk%2CtLmMj8hi999l252j
&sig=601e28d47fef565459fb40b90dae5c0c08224058c2c8b3f6cb5cd1402f4032f6

- sent by Clank, not working URL

http://content.uplynk.com
/channel/ext/1efe3bfc4d1e4b5db5e5085a535b510b/KTRKwatch.m3u8
?tc=1
&exp=1461256703583
&rn=1692.467108431245
&ct=c
&oid=1efe3bfc4d1e4b5db5e5085a535b510b
&eid=KTRKwatch
&ad=watchktrklive
&ad.adUnit=midroll
&ad.flex=0
&ad._v=2
&ad.kv=station,ktrk,datg_yx_bk,tLmMj8hi999l252j
&sig=f47ba01765109a16d3f97db626531d7274c5e9f68cf694c6d79eb0f6cf4aea5b

Note the difference between the penultimate parameters.
Labels: -Pri-3 Pri-2
Labels: Merge-Request-51
Owner: ram...@chromium.org
Ramine, could you please verify the fix?

Comment 6 by tin...@google.com, Apr 26 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 7 by ram...@chromium.org, Apr 28 2016

Tested on '52.0.2718.2' Dev
On LG G3/LRX21T -> Pass
Nexus 5X/NRD26  -> Pass

Othere sites tested:
m.youtube.com
dailymotion
bbc.com


Cc: ram...@chromium.org
Labels: ReleaseBlock-Stable
Owner: avayvod@chromium.org
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 30 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, May 3 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8de7f8d6820d42bf0a476fd3029dd0cf0ae9c36

commit a8de7f8d6820d42bf0a476fd3029dd0cf0ae9c36
Author: Anton Vayvod <avayvod@google.com>
Date: Tue May 03 10:07:23 2016

[Android,MediaFling] Fix the encoding issue with already encoded URLs for abc13.com/live

Also some cleanup of error handling, url type conversions and media type detection,
extend the UMA to cover more failure cases.

BUG= 605544 
TEST=unit tests + avayvod.github.io/mediaflingtest.html

Review URL: https://codereview.chromium.org/1907413002

Cr-Commit-Position: refs/heads/master@{#389735}
(cherry picked from commit e358d10bb42b0699c2db6276b57d6b9963be4b24)

Review URL: https://codereview.chromium.org/1940273002 .

Cr-Commit-Position: refs/branch-heads/2704@{#350}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/a8de7f8d6820d42bf0a476fd3029dd0cf0ae9c36/chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java
[modify] https://crrev.com/a8de7f8d6820d42bf0a476fd3029dd0cf0ae9c36/chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java
[modify] https://crrev.com/a8de7f8d6820d42bf0a476fd3029dd0cf0ae9c36/chrome/android/junit/src/org/chromium/chrome/browser/media/remote/MediaUrlResolverTest.java
[modify] https://crrev.com/a8de7f8d6820d42bf0a476fd3029dd0cf0ae9c36/chrome/browser/media/android/remote/remote_media_player_bridge.cc
[modify] https://crrev.com/a8de7f8d6820d42bf0a476fd3029dd0cf0ae9c36/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified with Chrome Beta '51.0.2704.36' (Samsung Galaxy S7/MMB29M)

Sign in to add a comment