New issue
Advanced search Search tips

Issue 605527 link

Starred by 1 user
Status: Fixed
Owner:
melandory@chromium.org
Closed: Apr 2016
Cc:
sabineb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Item in account chooser should take all avaiable width

Project Member Reported by melandory@chromium.org, Apr 21 2016 

It seems that the light grey bar that appears when you tap on an account in the account chooser on Clank is not taking the entire width of the dialog.

https://screenshot.googleplex.com/3H6h62rebV5

Comment 1 by melandory@chromium.org, Apr 26 2016 

Screenshots of before and after.
Screenshot_2016-04-26-12-54-42.png
140 KB View Download
Screenshot_2016-04-26-12-58-17.png
120 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/834cc31549407a99029595b0025341154a65e67d

commit 834cc31549407a99029595b0025341154a65e67d
Author: melandory <melandory@chromium.org>
Date: Tue Apr 26 11:51:12 2016

[Smart Lock] Fix account chooser highlighted item.

Force highlight of the selected item in Account chooser
take full dialog length.

BUG= 605527 

Review URL: https://codereview.chromium.org/1903383004

Cr-Commit-Position: refs/heads/master@{#389750}

[modify] https://crrev.com/834cc31549407a99029595b0025341154a65e67d/chrome/android/java/res/layout/account_chooser_dialog_item.xml

Comment 3 by melandory@chromium.org, Apr 26 2016

Labels: -OS-Mac Merge-Request-51

Comment 4 by tin...@google.com, Apr 26 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 5 by melandory@chromium.org, Apr 26 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/947a094e6bc260692ea154e0ef49ab1f6e2b6b12

commit 947a094e6bc260692ea154e0ef49ab1f6e2b6b12
Author: Tatiana Gornak <melandory@chromium.org>
Date: Tue Apr 26 12:11:38 2016

[Smart Lock] Fix account chooser highlighted item.

Force highlight of the selected item in Account chooser
take full dialog length.

BUG= 605527 

Review URL: https://codereview.chromium.org/1903383004

Cr-Commit-Position: refs/heads/master@{#389750}
(cherry picked from commit 834cc31549407a99029595b0025341154a65e67d)

Review URL: https://codereview.chromium.org/1919173002 .

Cr-Commit-Position: refs/branch-heads/2704@{#244}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/947a094e6bc260692ea154e0ef49ab1f6e2b6b12/chrome/android/java/res/layout/account_chooser_dialog_item.xml
►

Sign in to add a comment