New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605520 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocking:
issue 584266



Sign in to add a comment

Make the "hosts" text box on snippets-internals larger

Project Member Reported by treib@chromium.org, Apr 21 2016

Issue description

Tiny feature request: Currently, the text box that show the list of hosts on snippets-internals is super tiny, which makes it painful to inspect/edit on Android. Can we please make it bigger, so it will (in typical cases) show all the hosts at once?
 

Comment 1 by fi...@chromium.org, Apr 22 2016

Blocking: 584266
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab8e57c751b135139f3666ad900f491e78744fcd

commit ab8e57c751b135139f3666ad900f491e78744fcd
Author: jkrcal <jkrcal@chromium.org>
Date: Mon Apr 25 08:17:40 2016

Display status message for "Add snippets" on chrome://snippets-internals

The status message informs of URLRequest / HTTP error codes, invalid input, etc (604740). Furthermore, I enlarged the hosts input (605520).

BUG= 604740 ,  605520 

Review URL: https://codereview.chromium.org/1910633005

Cr-Commit-Position: refs/heads/master@{#389431}

[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/resources/snippets_internals.css
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_fetcher.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_fetcher.h
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service.h
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service_unittest.cc

Comment 3 by jkrcal@chromium.org, Apr 25 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab8e57c751b135139f3666ad900f491e78744fcd

commit ab8e57c751b135139f3666ad900f491e78744fcd
Author: jkrcal <jkrcal@chromium.org>
Date: Mon Apr 25 08:17:40 2016

Display status message for "Add snippets" on chrome://snippets-internals

The status message informs of URLRequest / HTTP error codes, invalid input, etc (604740). Furthermore, I enlarged the hosts input (605520).

BUG= 604740 ,  605520 

Review URL: https://codereview.chromium.org/1910633005

Cr-Commit-Position: refs/heads/master@{#389431}

[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/resources/snippets_internals.css
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_fetcher.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_fetcher.h
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service.cc
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service.h
[modify] https://crrev.com/ab8e57c751b135139f3666ad900f491e78744fcd/components/ntp_snippets/ntp_snippets_service_unittest.cc

Comment 5 by fi...@chromium.org, Jul 1 2016

Labels: zine-mr-MVP

Comment 6 by finkm@google.com, Jul 1 2016

Labels: -zine-mr-mvp

Comment 7 by fi...@chromium.org, Jul 1 2016

Labels: zine-mr-MVP

Sign in to add a comment