`output` should not match to `:enabled`
Reported by
zambonif...@gmail.com,
Apr 21 2016
|
||||||||
Issue descriptionCurrently (49.0.2623.87), it seems that `output` elements are `:enabled` to CSS. Given that this behavior isn’t mentioned anywhere and that there is no `disabled` JavaScript property, I believe this is a bug.
,
Apr 22 2016
Not quite on the version you mentioned. I’m in 50.0.2661.86.
,
Apr 22 2016
This doesn't seem to be a DevTools problem but an implementation problem with the output element. From what I can tell, there is no direct mention of whether `output` should have a disabled state. Therefore, it seems as if allowing `:enabled` styling is incorrect since there is no disabled association (while having the disabled attribute on the element does trigger it.) Action here seems to be: 1. Don't allow `disabled` attribute to have an affect on `output` elements. 2. Don't allow `:enabled` or `:disabled` styling against `output`.
,
Apr 22 2016
Thank you for providing more feedback. Adding requester "ashejole@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 22 2016
Need to try a bisect by creating a test case as in #2.
,
Apr 25 2016
tkent, PTAL. Is HTMLOutputElement getting :enabled behavior because it's part of form controls? Should it?
,
Apr 25 2016
OUTPUT should not match to :enabled obviously. https://html.spec.whatwg.org/multipage/scripting.html#selector-enabled
,
Apr 25 2016
Would like to work on this bug.
,
Apr 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25bd6595e89a77312b6de294025f3c6632aa0485 commit 25bd6595e89a77312b6de294025f3c6632aa0485 Author: ramya.v <ramya.v@samsung.com> Date: Tue Apr 26 06:57:21 2016 output should not match to :enabled or :disabled pseudo classes. As per the spec https://html.spec.whatwg.org/multipage/scripting.html#selector-enabled https://html.spec.whatwg.org/multipage/scripting.html#concept-element-disabled BUG= 605518 Review URL: https://codereview.chromium.org/1914933003 Cr-Commit-Position: refs/heads/master@{#389712} [add] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/LayoutTests/fast/css/pseudo-enabled-disabled-output-element.html [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/css/SelectorChecker.cpp [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/dom/Element.h [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLAnchorElement.h [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLFormControlElement.h [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOptGroupElement.h [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOptionElement.h [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOutputElement.cpp [modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOutputElement.h
,
Apr 26 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ashej...@chromium.org
, Apr 22 2016Components: Platform>DevTools
Labels: Needs-Feedback