New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605518 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

`output` should not match to `:enabled`

Reported by zambonif...@gmail.com, Apr 21 2016

Issue description

Currently (49.0.2623.87), it seems that `output` elements are `:enabled` to CSS. Given that this behavior isn’t mentioned anywhere and that there is no `disabled` JavaScript property, I believe this is a bug.
 
Cc: ashej...@chromium.org
Components: Platform>DevTools
Labels: Needs-Feedback
Hey, would you mind providing screen-shot for the same.

Also, if it not much to ask can you please try the above issue on latest chrome version '50.0.2661.87' and let us know if the issue still persists.

Thank you!
Not quite on the version you mentioned. I’m in 50.0.2661.86.
Captura de tela de 2016-04-22 08-34-14.png
62.8 KB View Download
Cc: jonathan.garbee@chromium.org
Components: -Platform>DevTools Blink>CSS Blink>HTML
Labels: -OS-Linux OS-All
This doesn't seem to be a DevTools problem but an implementation problem with the output element.

From what I can tell, there is no direct mention of whether `output` should have a disabled state. Therefore, it seems as if allowing `:enabled` styling is incorrect since there is no disabled association (while having the disabled attribute on the element does trigger it.)

Action here seems to be:

1. Don't allow `disabled` attribute to have an affect on `output` elements.
2. Don't allow `:enabled` or `:disabled` styling against `output`.
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 22 2016

Labels: -Needs-Feedback Needs-Review
Owner: ashej...@chromium.org
Thank you for providing more feedback. Adding requester "ashejole@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Review Needs-Bisect
Need to try a bisect by creating a test case as in #2.
Components: -Blink>HTML -Blink>CSS Blink>Forms>Output
Owner: tkent@chromium.org
Status: Assigned (was: Unconfirmed)
tkent, PTAL. Is HTMLOutputElement getting :enabled behavior because it's part of form controls? Should it?

Comment 7 by tkent@chromium.org, Apr 25 2016

Labels: -Needs-Bisect Hotlist-Interop Hotlist-GoodFirstBug
Owner: ----
Status: Available (was: Assigned)
Summary: `output` should not match to `:enabled` (was: `output` is `:enabled`)
OUTPUT should not match to :enabled obviously.
https://html.spec.whatwg.org/multipage/scripting.html#selector-enabled

Comment 8 by ramy...@samsung.com, Apr 25 2016

Owner: ramy...@samsung.com
Status: Assigned (was: Available)
Would like to work on this bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25bd6595e89a77312b6de294025f3c6632aa0485

commit 25bd6595e89a77312b6de294025f3c6632aa0485
Author: ramya.v <ramya.v@samsung.com>
Date: Tue Apr 26 06:57:21 2016

output should not match to :enabled or :disabled pseudo classes.

As per the spec
https://html.spec.whatwg.org/multipage/scripting.html#selector-enabled
https://html.spec.whatwg.org/multipage/scripting.html#concept-element-disabled

BUG= 605518 

Review URL: https://codereview.chromium.org/1914933003

Cr-Commit-Position: refs/heads/master@{#389712}

[add] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/LayoutTests/fast/css/pseudo-enabled-disabled-output-element.html
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLAnchorElement.h
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLFormControlElement.h
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOptGroupElement.h
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOptionElement.h
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOutputElement.cpp
[modify] https://crrev.com/25bd6595e89a77312b6de294025f3c6632aa0485/third_party/WebKit/Source/core/html/HTMLOutputElement.h

Comment 10 by tkent@chromium.org, Apr 26 2016

Labels: M-52
Status: Fixed (was: Assigned)

Sign in to add a comment