New issue
Advanced search Search tips

Issue 605516 link

Starred by 1 user
Status: Verified
Owner:
machenb...@chromium.org
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 634246



Sign in to add a comment

Make it easier to repro failures from V8 waterfalls

Project Member Reported by machenb...@chromium.org, Apr 21 2016 
Complex cryptic infrastructure makes it hard for developers to reproduce failures found in CI or tryserver locally. This stems from:
- Compile on builders, test failures on testers
- Failures show up on swarming collect step, hard to reason how the test framework was started

Goals:
It should be easy to reason from the test failure how to compile and repro locally. As an alternative, it should be documented how to download the build product from swarming for repro.

Rerunning the tests should work by running a test directly or through the test framework with a filter and other optional parameters (e.g. rerun counts to make flakes more likely).
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/f11c19922bb86adf7c613b0d62d8af0e2026310e

commit f11c19922bb86adf7c613b0d62d8af0e2026310e
Author: machenbach@chromium.org <machenbach@chromium.org>
Date: Thu Apr 21 14:48:05 2016

V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.

BUG= 605516 

Review URL: https://codereview.chromium.org/1901103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300080 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipe_modules/v8/test_api.py
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_slim_bisect_tester_swarming.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug___greedy_allocator_bisect_tester.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_bisect_tester_swarming.json
[add] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_one_failure_build_env_not_supported.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_one_change.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_override_changes.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_recurring_failure.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_tests_too_long.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm64___builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm___builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___debug_builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug_builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_failures.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_flakes.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json
[modify] https://crrev.com/f11c19922bb86adf7c613b0d62d8af0e2026310e/scripts/slave/recipes/v8.py
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2016 

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86906

------------------------------------------------------------------
r86906 | recipe-roller@chromium.org | 2016-04-21T22:40:52.250660Z

-----------------------------------------------------------------
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/1ded93a29efc0b2f79d78316ba1b4501bdb5be76

commit 1ded93a29efc0b2f79d78316ba1b4501bdb5be76
Author: machenbach@chromium.org <machenbach@chromium.org>
Date: Fri Apr 22 07:25:41 2016

Revert of V8: Show build environment in failure logs (patchset #5 id:80001 of https://codereview.chromium.org/1901103004/ )

Reason for revert:
Might break the CQ: http://crbug.com/605846

Original issue's description:
> V8: Show build environment in failure logs
> 
> This will make it easier for developers to reproduce
> failures.
> 
> Currently, the indirection between builders/testers and
> between swarming trigger/collect makes it hard to
> reason how the test executables were built.
> 
> BUG= 605516 
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300080

TBR=kjellander@chromium.org,tandrii@chromium.org
BUG= 605516 ,605846

Review URL: https://codereview.chromium.org/1906353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300106 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipe_modules/v8/test_api.py
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_slim_bisect_tester_swarming.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug___greedy_allocator_bisect_tester.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_bisect_tester_swarming.json
[delete] https://crrev.com/8e956687161403ef877d56e85683ea684a2db449/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_one_failure_build_env_not_supported.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_one_change.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_override_changes.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_recurring_failure.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_tests_too_long.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm64___builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm___builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___debug_builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug_builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_failures.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_flakes.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json
[modify] https://crrev.com/1ded93a29efc0b2f79d78316ba1b4501bdb5be76/scripts/slave/recipes/v8.py
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86931

------------------------------------------------------------------
r86931 | recipe-roller@chromium.org | 2016-04-22T07:51:20.018880Z

-----------------------------------------------------------------
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6d21841ec3de68a5de6ba831bb7bb6d4d2ab3fcd

commit 6d21841ec3de68a5de6ba831bb7bb6d4d2ab3fcd
Author: machenbach <machenbach@chromium.org>
Date: Fri Apr 22 10:26:59 2016

[test] Print how test runner is called on swarming.

BUG= chromium:605516 
LOG=n

Review URL: https://codereview.chromium.org/1913013003

Cr-Commit-Position: refs/heads/master@{#35718}

[modify] https://crrev.com/6d21841ec3de68a5de6ba831bb7bb6d4d2ab3fcd/tools/run-tests.py
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/05168eeff91f3709805309988f81221148b694e8

commit 05168eeff91f3709805309988f81221148b694e8
Author: machenbach@chromium.org <machenbach@chromium.org>
Date: Fri Apr 22 10:46:03 2016

V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.

BUG= 605516 

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300080

Review URL: https://codereview.chromium.org/1901103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300108 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipe_modules/v8/test_api.py
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_slim_bisect_tester_swarming.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug___greedy_allocator_bisect_tester.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_bisect_tester_swarming.json
[add] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_one_failure_build_env_not_supported.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_one_change.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_override_changes.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_recurring_failure.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_tests_too_long.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm64___builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm___builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___debug_builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug_builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_failures.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_flakes.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json
[modify] https://crrev.com/05168eeff91f3709805309988f81221148b694e8/scripts/slave/recipes/v8.py
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86933

------------------------------------------------------------------
r86933 | recipe-roller@chromium.org | 2016-04-22T12:01:29.550762Z

-----------------------------------------------------------------

Comment 8 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>V8
Labels: -Infra-Client-V8
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/f9f6d442add21c92080b06a3c40c191b50148b09

commit f9f6d442add21c92080b06a3c40c191b50148b09
Author: machenbach <machenbach@chromium.org>
Date: Tue Jul 05 15:06:09 2016

V8: Get build environment from MB

Before MB, the build environment was hard-coded by
configurations on the infra side. After moving to MB, the
build environment is set dynamically in a recipe step.

The build environment is written to a property and passed to
testers to be presented to the user on build failures. This
CL makes that work with MB, both if it's a gyp or gn
environment.

BUG= 605516 , 616035 

Review-Url: https://codereview.chromium.org/2127573003

[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
[add] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder_with_gn.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_one_change.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_override_changes.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_recurring_failure.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_tests_too_long.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm64___builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm___builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___debug_builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug_builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json
[modify] https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09/scripts/slave/recipes/v8.py
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 5 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/188b03ddae5ee12f9effa993fbbc96cab2a5ce82

commit 188b03ddae5ee12f9effa993fbbc96cab2a5ce82
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 05 15:13:02 2016
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/774db88e63c9999a9aaaf15417b70e28a40c4e12

commit 774db88e63c9999a9aaaf15417b70e28a40c4e12
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 05 15:29:00 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/f9f6d442add21c92080b06a3c40c191b50148b09 V8: Get build environment from MB (machenbach@chromium.org)

R=machenbach@chromium.org
BUG= 616035 , 605516 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2119363002

[modify] https://crrev.com/774db88e63c9999a9aaaf15417b70e28a40c4e12/infra/config/recipes.cfg

Comment 12 by machenb...@chromium.org, Aug 4 2016

Blocking: 634246

Comment 13 by machenb...@chromium.org, Aug 9 2016

Status: Verified (was: Assigned)
This works now with swarming and gn and shows the used gn args on all test failures. It furthermore shows exact test runner parameters on all swarming tasks.
►

Sign in to add a comment