New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605497 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.2%-13.2% regression in v8.top_25_smooth at 387898:387908

Project Member Reported by rmcilroy@chromium.org, Apr 21 2016

Issue description

Looks like this is probably "[heap] Turn on black allocation during marking finalization to avoid floating garbage" in which case it is expected. Will bisect to be sure.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=605497

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgpOSVtgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxJfruAoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac11
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Apr 23 2016

Cc: hpayer@chromium.org
Owner: hpayer@chromium.org

=== Auto-CCing suspected CL author hpayer@chromium.org ===

Hi hpayer@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [heap] Turn on black allocation during marking finalization to avoid floating garbage.
Author  : hpayer
Commit description:
  
We will move this back to start of incremental marking when we make faster progress.

Perf sheriffs: This CL may cause a regression on benchmarks that improved earlier by enabling black allocation.

BUG= chromium:599174 
LOG=n

Review URL: https://codereview.chromium.org/1889853002

Cr-Commit-Position: refs/heads/master@{#35500}
Commit  : 413ea9261716511cf09489fcbbec61c9fb65f9a8
Date    : Thu Apr 14 17:37:43 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@387897         41.35991    0.725741    5           good
chromium@387903         41.023421   0.33547     5           good
chromium@387905         40.749169   2.004959    8           good
chromium@387905,v8@a0d2f240c341.644235   1.167527    8           good
chromium@387905,v8@b62af118f441.421339   1.336247    8           good
chromium@387905,v8@93135d8c0d41.063417   0.954508    5           good
chromium@387905,v8@43c7c76f1d40.355046   0.993898    5           good
chromium@387905,v8@413ea9261745.994645   2.800683    5           bad         <-
chromium@387905,v8@6c702283ac45.850458   0.504879    5           bad
chromium@387905,v8@139617b0d544.940644   1.174199    5           bad
chromium@387906         44.645303   0.688465    5           bad
chromium@387908         45.024768   1.210746    5           bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 605497

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests v8.top_25_smooth
Test Metric: v8_gc_total_outside_idle/v8_gc_total_outside_idle
Relative Change: 8.86%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/596
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9014665435784717888


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=605497

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 3 by hpayer@chromium.org, Apr 26 2016

Status: WontFix (was: Assigned)
Expected regression for now. This CL will be reverted as soon as memory is under control.

Sign in to add a comment