Crashing webkit_tests: usb/usbDevice.html and fast/dom/Window/property-access-on-cached-properties-after-frame-* on WebKit Win7 (dbg) |
|||
Issue descriptionThe following webkit_tests test started failing on WebKit Win7 (dbg) at https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5364 The following tests are crashing reliably: fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html fast/dom/Window/property-access-on-cached-window-after-frame-removed.html usb/usb.html usb/usbDevice.html I will update TestExpectations. I suspect https://codereview.chromium.org/1850023002 by reillyg@chromium.org breaks usb/usbDevice.html, but the others are hard to figure out. I CCed a few on the blamelist: https://chromium.googlesource.com/chromium/src/+log/f20000e405ded9b2dcf9d0f6a5bfc0259b251cf8%5E..afb8f54b782055923cadd711452c2448f3f7b5b4?pretty=fuller
,
Apr 22 2016
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1174ce5ac7e0b7c3300e5607e7869327ec0669f commit d1174ce5ac7e0b7c3300e5607e7869327ec0669f Author: reillyg <reillyg@chromium.org> Date: Mon Apr 25 23:32:53 2016 Make new WebUSB implementation more resilient to garbage collection. This patch fixes a couple logic errors on USBDevice cleanup: assuming the contextDestroyed() was already called and not clearing the request list on connection failure. We then attempt to fix the failures reported in issue 605487 by using WeakPersistenThisPointer when registering the connection error callbacks. BUG= 605487 Review URL: https://codereview.chromium.org/1912223002 Cr-Commit-Position: refs/heads/master@{#389610} [modify] https://crrev.com/d1174ce5ac7e0b7c3300e5607e7869327ec0669f/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/d1174ce5ac7e0b7c3300e5607e7869327ec0669f/third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js [modify] https://crrev.com/d1174ce5ac7e0b7c3300e5607e7869327ec0669f/third_party/WebKit/LayoutTests/usb/usbDevice.html [modify] https://crrev.com/d1174ce5ac7e0b7c3300e5607e7869327ec0669f/third_party/WebKit/Source/modules/webusb/USB.cpp [modify] https://crrev.com/d1174ce5ac7e0b7c3300e5607e7869327ec0669f/third_party/WebKit/Source/modules/webusb/USB.h [modify] https://crrev.com/d1174ce5ac7e0b7c3300e5607e7869327ec0669f/third_party/WebKit/Source/modules/webusb/USBDevice.cpp [modify] https://crrev.com/d1174ce5ac7e0b7c3300e5607e7869327ec0669f/third_party/WebKit/Source/modules/webusb/USBDevice.h
,
Apr 25 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 21 2016