New issue
Advanced search Search tips

Issue 605450 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Throw TypeErrors on invalid timings passed to AnimationEffectTiming

Project Member Reported by alancutter@chromium.org, Apr 21 2016

Issue description

Invalid values for timing properties should result in a TypeError:
https://w3c.github.io/web-animations/#animationeffecttiming

 

Comment 1 by suzyh@chromium.org, Apr 22 2016

Not a dupe, but just linking to related bug: TypeErrors for invalid easings  crbug.com/601672 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f760e7025c61bd64c3a6bdcf22b1af294ebcad90

commit f760e7025c61bd64c3a6bdcf22b1af294ebcad90
Author: alancutter <alancutter@chromium.org>
Date: Wed Apr 27 10:25:08 2016

Web Animations: Throw TypeErrors for invalid timing parameters

This change throws TypeErrors when invalid parameters are given
for the following AnimationEffectTiming parameters:
 - iterationStart
 - iterations
 - duration

See spec for valid inputs:
https://w3c.github.io/web-animations/#animationeffecttiming

BUG= 605450 

Review URL: https://codereview.chromium.org/1906463002

Cr-Commit-Position: refs/heads/master@{#390040}

[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/duration-expected.txt
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/iterationStart-expected.txt
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/iterations-expected.txt
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/LayoutTests/web-animations-api/timed-item-specified-setters.html
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/animation/AnimationEffectTiming.h
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/animation/AnimationEffectTiming.idl
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/animation/ElementAnimation.h
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/animation/Timing.h
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/animation/TimingInput.cpp
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/animation/TimingInput.h
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/html/HTMLMarqueeElement.js
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/f760e7025c61bd64c3a6bdcf22b1af294ebcad90/third_party/WebKit/Source/core/style/DataEquivalency.h

Status: Fixed (was: Started)

Comment 4 Deleted

Sign in to add a comment