DomDistillerViewerSourceBrowserTest tests are flaky on Linux Tests (dbg)(1) |
|||
Issue descriptionStarting with https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/53656 these tests became flaky: DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleExists DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleNotFound I couldn't find a culprit in that or nearby CLs, so I'm going to disable the tests for Linux debug. Example failure: [ RUN ] DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleExists [4568:4568:0420/205104:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled. [1:1:0420/205105:ERROR:memory_mapped_file.cc(40)] Couldn't open /tmp/run1uXtbv/out/Debug/chrome_material_200_percent.pak [1:1:0420/205105:ERROR:data_pack.cc(80)] Failed to mmap datapack [1:1:0420/205105:ERROR:memory_mapped_file.cc(40)] Couldn't open /tmp/run1uXtbv/out/Debug/chrome_200_percent.pak [1:1:0420/205105:ERROR:data_pack.cc(80)] Failed to mmap datapack [1:1:0420/205105:WARNING:histogram_base.cc(131)] 3 histograms were created before reporting was enabled. Xlib: extension "RANDR" missing on display ":9". [4568:4568:0420/205105:ERROR:memory_mapped_file.cc(40)] Couldn't open /tmp/run1uXtbv/out/Debug/chrome_material_200_percent.pak [4568:4568:0420/205105:ERROR:data_pack.cc(80)] Failed to mmap datapack [4568:4568:0420/205105:ERROR:memory_mapped_file.cc(40)] Couldn't open /tmp/run1uXtbv/out/Debug/chrome_200_percent.pak [4568:4568:0420/205105:ERROR:data_pack.cc(80)] Failed to mmap datapack Xlib: extension "RANDR" missing on display ":9". [4568:4568:0420/205105:WARNING:audio_manager.cc(307)] Multiple instances of AudioManager detected [4568:4568:0420/205105:WARNING:audio_manager.cc(281)] Multiple instances of AudioManager detected [4568:4568:0420/205106:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [4719:4719:0420/205107:WARNING:histogram_base.cc(131)] 1 histograms were created before reporting was enabled. [4568:4764:0420/205107:WARNING:simple_synchronous_entry.cc(929)] Could not open platform files for entry. ../../chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc:223: Failure Value of: contents_after_nav->GetLastCommittedURL() Actual: chrome-distiller://4fabaf74-a324-4d76-bb3d-5dc5ce72ce17/?entry_id=DISTILLED#loaded#loaded Expected: url Which is: chrome-distiller://4fabaf74-a324-4d76-bb3d-5dc5ce72ce17/?entry_id=DISTILLED [4719:4719:0420/205108:ERROR:gles2_cmd_decoder.cc(14816)] [.CommandBufferContext.DisplayCompositor-0x2201d5858a20]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name [4719:4719:0420/205108:ERROR:gles2_cmd_decoder.cc(7987)] [.CommandBufferContext.DisplayCompositor-0x2201d5858a20]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering. [4719:4719:0420/205108:ERROR:gles2_cmd_decoder.cc(14816)] [.CommandBufferContext.DisplayCompositor-0x2201d5858a20]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name [4719:4719:0420/205108:ERROR:gles2_cmd_decoder.cc(7987)] [.CommandBufferContext.DisplayCompositor-0x2201d5858a20]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering. [ FAILED ] DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleExists, where TypeParam = and GetParam() = (4170 ms)
,
Apr 21 2016
mdjones: Could this be related to the latest printing code? https://codereview.chromium.org/1575473002/ Or maybe something else... Anyway, would be great if you could take a look as it is important that this test ensures that we still don't give away WebUI bindings.
,
Apr 22 2016
Yeah, it's the hack that is used to tell print preview that the page has rendered. Working on a fix now.
,
May 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80ef02b21fe174b3c6a4588b1f6984b13f4d88f4 commit 80ef02b21fe174b3c6a4588b1f6984b13f4d88f4 Author: mdjones <mdjones@chromium.org> Date: Wed May 11 21:36:14 2016 Only trigger navigation in distiller if in print preview BUG= 605432 , 611161 Review-Url: https://codereview.chromium.org/1920563002 Cr-Commit-Position: refs/heads/master@{#393065} [modify] https://crrev.com/80ef02b21fe174b3c6a4588b1f6984b13f4d88f4/chrome/browser/ui/webui/print_preview/print_preview_distiller.cc [modify] https://crrev.com/80ef02b21fe174b3c6a4588b1f6984b13f4d88f4/components/dom_distiller/core/javascript/dom_distiller_viewer.js
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9599ecbdf0f63640aea7b07f601b9bf6949b665 commit e9599ecbdf0f63640aea7b07f601b9bf6949b665 Author: mdjones <mdjones@chromium.org> Date: Thu May 12 01:30:23 2016 Revert of Disable DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticle{Exists,NotFound} tests. (patchset #2 id:20001 of https://codereview.chromium.org/1911733002/ ) Reason for revert: A change landed that fixes the reason these became flaky (https://codereview.chromium.org/1920563002/). Original issue's description: > Disable DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticle{Exists,NotFound} tests. > > Starting with https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/53656 > these tests became flaky: > DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleExists > DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleNotFound > > BUG= 605432 > TBR=nyquist@chromium.org > > Committed: https://crrev.com/620c8a6cf23eebb0497ff4e64216fdaa8818433a > Cr-Commit-Position: refs/heads/master@{#388722} TBR=nyquist@chromium.org,kjellander@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 605432 Review-Url: https://codereview.chromium.org/1969993002 Cr-Commit-Position: refs/heads/master@{#393136} [modify] https://crrev.com/e9599ecbdf0f63640aea7b07f601b9bf6949b665/chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc
,
May 12 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 21 2016