New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605391 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 595136



Sign in to add a comment

Video Player: Stop using Cast API shared module.

Project Member Reported by fukino@chromium.org, Apr 21 2016

Issue description

The Cast API shared module doesn't support Media Router function, and will not be supported anymore.
We should stop using it and use each extension's cast_sender.js instead.
 

Comment 1 by fukino@chromium.org, Apr 21 2016

Blocking: 595136

Comment 2 by fukino@chromium.org, Apr 21 2016

Cc: vadimgo@chromium.org

Comment 3 by fukino@chromium.org, Apr 21 2016

Labels: M-52
Status: Started (was: Assigned)
CL is under review. https://codereview.chromium.org/1912493003/
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24bc75500304280de2a4cdfbe0f6eb4c81d1e679

commit 24bc75500304280de2a4cdfbe0f6eb4c81d1e679
Author: fukino <fukino@chromium.org>
Date: Tue Apr 26 09:55:48 2016

Video Player: Stop using Cast API shared module.

As the shared module will not be supported anymore and it doesn't handle media router.
We should use Cast Extension's cast_sender.js instead.

BUG= 605391 
TEST=make sure that the madia router is disabled, a Google Cast extension is
installed, there is at least one available cast device, and check that we can
cast video on Google Drive from built-in video player.

Review URL: https://codereview.chromium.org/1912493003

Cr-Commit-Position: refs/heads/master@{#389738}

[modify] https://crrev.com/24bc75500304280de2a4cdfbe0f6eb4c81d1e679/ui/file_manager/video_player/js/cast/caster.js
[modify] https://crrev.com/24bc75500304280de2a4cdfbe0f6eb4c81d1e679/ui/file_manager/video_player/js/video_player_metrics.js
[modify] https://crrev.com/24bc75500304280de2a4cdfbe0f6eb4c81d1e679/ui/file_manager/video_player/manifest.json

Comment 5 by fukino@chromium.org, Apr 26 2016

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 7 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
Cc: avkodipelli@chromium.org vsu...@chromium.org
Status: Verified (was: Fixed)

Sign in to add a comment