Support media router in video player. |
|||||||||||
Issue descriptionThe Chrome OS built-in video player has a function to cast a video to Google Cast devices, using a Google Cast extension. If the media router is enabled in chrome://flags, all Google Cast extensions are disabled and we need to use Media Router instead. Video player should support media router to keep the Cast function. There should be some UI differences when users enable/disable the media router. If users disable media router and the video player uses legacy Google Cast extensions, users will see a list of available cast devices at the right-bottom corner as drop-down menu. (Screenshot 1) If users enable media router and the video player uses Presentation API through the component extension, users will see a standard pop-up dialog to choose a device. (Screenshot 2) Once the cast device starts playback, users will see a control panel in the standard pop-up dialog. (Screenshot 3) The dialog is common with Chrome and other apps.
,
Apr 21 2016
,
Apr 21 2016
,
Apr 21 2016
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54e8895f6205ab1486db3a15e66b8832f12aa541 commit 54e8895f6205ab1486db3a15e66b8832f12aa541 Author: fukino <fukino@chromium.org> Date: Thu May 19 11:25:48 2016 Video Player: Support Media Router to cast Drive videos. This CL includes following changes to support both media router and legacy cast extensions to cast Drive video. - Added media router's component extensions to the cast extension list we use. - when we use media router, we use a cast button which requests a cast session via shared cast dialog, instead of dropdown cast menu button . This CL includes some minor bug fixes. (Added inline comments for them) BUG= 605390 TEST=enable media-router from chrome://flags and cast video from video player. Review-Url: https://codereview.chromium.org/1987173002 Cr-Commit-Position: refs/heads/master@{#394737} [modify] https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541/ui/file_manager/externs/chrome_cast.js [modify] https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541/ui/file_manager/video_player/css/media_controls.css [modify] https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541/ui/file_manager/video_player/js/cast/cast_extension_discoverer.js [modify] https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541/ui/file_manager/video_player/js/cast/cast_video_element.js [modify] https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541/ui/file_manager/video_player/js/cast/caster.js [modify] https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541/ui/file_manager/video_player/js/media_controls.js [modify] https://crrev.com/54e8895f6205ab1486db3a15e66b8832f12aa541/ui/file_manager/video_player/js/video_player.js
,
May 19 2016
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 15 2017
Verified on 9554.0.0, 60.0.3100.0. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by fukino@chromium.org
, Apr 21 2016