context screenshot

Deleted: Screen Shot 2016-04-21 at 11.29.46 AM.png 36.0 KB

	Screen Shot 2016-04-21 at 11.29.46 AM.png 36.0 KB View Download

Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The behavior seems to have changed. Instead now when a MacViews bubble is active, pressing Cmd+W does not close the tab, which is not in line with Cocoa. The behavior can also be seen on the current Stable. Running a bisect gave this CL as the cause - https://codereview.chromium.org/1955343002. Reverting it fixes the closing of the tab via Cmd+W, but brings back the above issue.  

So I don't think this is a bug. The closest thing to our bubbles is NSPopover. In Safari, if I right-click a bookmark in the sidebar and say 'Edit Address...', keys like Cmd+w will go to the popover -- not the parent window.

But on Mac, dialogs are not dismissed by Cmd+w, so having a dialog like this with a button ignore Cmd+w seems like the right thing to do.

I think it's an accident/bug that Cmd+w would close the tab. It would have been a result of the behaviour around the private API `-_sharesParentKeyState` that we never fully understood.

 Issue 612067  has been merged into this issue.

Reopening this, since the CL in https://codereview.chromium.org/2666523002/ probably changes things around this.

macviews triage: This bug is still live and still needs to be fixed before Harmony launches.

tapted: what's our status here?

we should fix this

Load balancing! Over to sdy@ :)

(note the fix will likely be similar to r526878 -- i.e. ContentSettingBubbleContents is already a WebContentsObserver, it just needs to observe WasHidden and GetWidget()->Close() itself .. technically the bubble on Windows have this problem too, but it's hard to switch tabs while the bubble is open since keyboard shortcuts are blocked [which is a separate bug - they shouldn't be blocked - that's Issue 319109])

Yoink :)

Fix: <https://chromium-review.googlesource.com/c/chromium/src/+/906890>

Note there's also  Issue 780131  - if that cl fixes both, it can probably be deduped into this bug.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9abe107b1c15f7ccfcf8de5be8dfc3e3a0b94c92

commit 9abe107b1c15f7ccfcf8de5be8dfc3e3a0b94c92
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue Feb 13 21:54:03 2018

views: dismiss content setting bubbles when the WebContents closes

This is necessary on Mac because cmd-w works even with a bubble open, which can
dismiss the underlying WebContents.

Bug:  605374 
Change-Id: I66558f72d0fbb63eb56ed5469d5789062f654d43
Reviewed-on: https://chromium-review.googlesource.com/906890
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536493}
[modify] https://crrev.com/9abe107b1c15f7ccfcf8de5be8dfc3e3a0b94c92/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/9abe107b1c15f7ccfcf8de5be8dfc3e3a0b94c92/chrome/browser/ui/views/content_setting_bubble_contents.h
[add] https://crrev.com/9abe107b1c15f7ccfcf8de5be8dfc3e3a0b94c92/chrome/browser/ui/views/content_setting_bubble_contents_browsertest.cc
[modify] https://crrev.com/9abe107b1c15f7ccfcf8de5be8dfc3e3a0b94c92/chrome/test/BUILD.gn
[add] https://crrev.com/9abe107b1c15f7ccfcf8de5be8dfc3e3a0b94c92/chrome/test/data/content_setting_bubble/geolocation.html
[add] https://crrev.com/9abe107b1c15f7ccfcf8de5be8dfc3e3a0b94c92/chrome/test/data/content_setting_bubble/geolocation.js