Issue 605356 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ kateso...@chromium.org Last visit > 30 days ago
Closed:	May 2016
Cc:	jchin...@chromium.org █ mimee@chromium.org mbarbe...@chromium.org infe...@chromium.org █ robert...@chromium.org chanli@chromium.org lijeffrey@chromium.org liaoyuke@chromium.org st...@chromium.org
Components:	Tools>Test>FindIt
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Bug

Blocking:
issue 608922

crash: pull buildspec from chrome-internal for official release Chrome builds

Project Member Reported by st...@chromium.org, Apr 21 2016

Issue description

For Chrome official release builds like canary/dev/beta/stable, buildspec might impact the DEPS. Thus grabbing DEPS from chromium is not enough for such builds.

As we are focusing on the Canary crashes now, if Canary build is not impacted, we could lower the priority and revisit later when other channels are supported.

Comment 1 by st...@chromium.org, Apr 21 2016

Labels: -Pri-3 Pri-1
Summary: crash: DEPS info for Chrome official build (was: DEPS info for Chrome official build)

Comment 2 by kateso...@chromium.org, Apr 22 2016

Status: Started (was: Assigned)

The Canary build is impacted, should resolve this asap.

Comment 3 by st...@chromium.org, May 3 2016

Summary: crash: pull buildspec from chrome-internal for official release Chrome builds (was: crash: DEPS info for Chrome official build)

Comment 4 by st...@chromium.org, May 3 2016

Blocking: 608922

Project Member

Comment 5 by bugdroid1@chromium.org, May 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/059e75397048f79d6bc4de3d399d7a7d3f213071

commit 059e75397048f79d6bc4de3d399d7a7d3f213071
Author: katesonia <katesonia@chromium.org>
Date: Sat May 07 00:16:39 2016

[Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds.

BUG= 605356 

patch from issue 1914653003 at patchset 80001 (http://crrev.com/1914653003#ps80001)

Review-Url: https://codereview.chromium.org/1950123003

[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/common/chromium_deps.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/common/dependency.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/common/deps_parser.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/common/http_client_appengine.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/common/test/chromium_deps_test.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/common/test/dependency_test.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/common/test/deps_parser_test.py
[add] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/callstack_filters.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/fracas.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/fracas_crash_pipeline.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/fracas_parser.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/results.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/scorers/test/aggregator_test.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/stacktrace_parser.py
[add] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/test/callstack_filters_test.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/test/findit_for_crash_test.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/test/fracas_crash_pipeline_test.py
[add] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/test/fracas_test.py
[modify] https://crrev.com/059e75397048f79d6bc4de3d399d7a7d3f213071/appengine/findit/crash/test/results_test.py

Comment 6 by kateso...@chromium.org, May 7 2016

Status: Fixed (was: Started)

Project Member

Comment 7 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/fb53695b44cc578a02b2d00c9e11b1ed316dde39

commit fb53695b44cc578a02b2d00c9e11b1ed316dde39
Author: katesonia <katesonia@chromium.org>
Date: Mon May 09 22:07:00 2016

[Findit] Use gerric scope instead of email scope to authorize findit to internal buildspec/

For internal buildspec/ (https://chrome-internal.googlesource.com/chrome/tools/buildspec.git/), the scope for authentication should be https://www.googleapis.com/auth/gerritcodereview instead of https://www.googleapis.com/auth/userinfo.email.

BUG= 605356 

Review-Url: https://codereview.chromium.org/1960353002

[modify] https://crrev.com/fb53695b44cc578a02b2d00c9e11b1ed316dde39/appengine/findit/common/auth_util.py
[modify] https://crrev.com/fb53695b44cc578a02b2d00c9e11b1ed316dde39/appengine/findit/common/http_client_appengine.py

►

Issue 605356 link

Issue metadata

crash: pull buildspec from chrome-internal for official release Chrome builds

Issue description

Comment 1 by st...@chromium.org, Apr 21 2016

Comment 1 Deleted

Comment 2 by kateso...@chromium.org, Apr 22 2016

Comment 2 Deleted

Comment 3 by st...@chromium.org, May 3 2016

Comment 3 Deleted

Comment 4 by st...@chromium.org, May 3 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, May 7 2016

Comment 5 Deleted

Comment 6 by kateso...@chromium.org, May 7 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, May 9 2016

Comment 7 Deleted

Sign in to add a comment