Image placeholders should be visible on a Web page as opaque rectangles with colors that, when possible, match the color scheme of the page.
Image placeholders should be visible on a Web page as stylized rectangles.
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72b7454b7d1ea60317365a076187da54e646e88e commit 72b7454b7d1ea60317365a076187da54e646e88e Author: sclittle <sclittle@chromium.org> Date: Mon Oct 24 20:49:06 2016 Add Blink support for showing image placeholders using range requests. Design doc: https://docs.google.com/document/d/1691W7yFDI1FJv69N2MEtaSzpnqO2EqkgGD3T0O-pQ08/edit?usp=sharing This CL introduces support for issuing a range request for just the first few bytes of an image, and showing a translucent gray box of the same size as the image in the image's place if the original image's dimensions can be decoded from the returned range. Currently, this behavior is only activated via a blink-settings flag. In the future, features such as Data Saver will activate this functionality to save data for users. BUG= 605350 , 605351 Review-Url: https://codereview.chromium.org/2423683002 Cr-Commit-Position: refs/heads/master@{#427141} [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/css/CSSImageValue.cpp [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/FetchRequest.cpp [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/FetchRequest.h [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/ImageResource.cpp [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/ImageResource.h [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/Resource.cpp [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/Resource.h [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/frame/Settings.in [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/loader/DocumentLoader.cpp [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/loader/ImageLoader.cpp [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/loader/ProgressTracker.cpp [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/page/DragController.cpp [modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/platform/BUILD.gn [add] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/platform/graphics/PlaceholderImage.cpp [add] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/platform/graphics/PlaceholderImage.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aae1e1ce18a9b1923ea7bdfafa5f3afe46050532 commit aae1e1ce18a9b1923ea7bdfafa5f3afe46050532 Author: sclittle <sclittle@chromium.org> Date: Thu Jun 08 21:48:05 2017 Stylize PlaceholderImages with icons. This CL stylizes the appearance of PlaceholderImages by adding an icon. See the spec here: https://docs.google.com/document/d/1BHeA1azbgCdZgCnr16VN2g7A9MHPQ_dwKn5szh8evMQ/edit BUG= 605351 Review-Url: https://codereview.chromium.org/2915353002 Cr-Commit-Position: refs/heads/master@{#478098} [modify] https://crrev.com/aae1e1ce18a9b1923ea7bdfafa5f3afe46050532/content/child/blink_platform_impl.cc [modify] https://crrev.com/aae1e1ce18a9b1923ea7bdfafa5f3afe46050532/third_party/WebKit/Source/platform/graphics/PlaceholderImage.cpp [modify] https://crrev.com/aae1e1ce18a9b1923ea7bdfafa5f3afe46050532/third_party/WebKit/Source/platform/graphics/PlaceholderImage.h [modify] https://crrev.com/aae1e1ce18a9b1923ea7bdfafa5f3afe46050532/third_party/WebKit/public/blink_image_resources.grd [add] https://crrev.com/aae1e1ce18a9b1923ea7bdfafa5f3afe46050532/third_party/WebKit/public/default_100_percent/blink/placeholder_icon.png
I've created a separate bug for adding text showing the original resource size of the image: https://crbug.com/632867 Marking this as fixed.
Comment 1 by bengr@chromium.org
, Apr 28 2016