New issue
Advanced search Search tips

Issue 605350 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 605347
issue 632867



Sign in to add a comment

Range requests should be issued for image optimization

Project Member Reported by bengr@chromium.org, Apr 21 2016

Issue description

When the image range request optimization is enabled, an image request should be sent with a range request header that provides a range just large enough to retrieve image dimension. No request should be sent if Chrome already knows the image's dimensions.
 

Comment 1 by bengr@chromium.org, Apr 28 2016

Labels: -Type-Bug Type-Feature
Blockedon: 605347
Status: Started (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 13 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by bengr@chromium.org, Aug 18 2016

Labels: -M-54 M-55
Blocking: 632867
Labels: -M-55 M-56
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72b7454b7d1ea60317365a076187da54e646e88e

commit 72b7454b7d1ea60317365a076187da54e646e88e
Author: sclittle <sclittle@chromium.org>
Date: Mon Oct 24 20:49:06 2016

Add Blink support for showing image placeholders using range requests.

Design doc:
https://docs.google.com/document/d/1691W7yFDI1FJv69N2MEtaSzpnqO2EqkgGD3T0O-pQ08/edit?usp=sharing

This CL introduces support for issuing a range request for just the
first few bytes of an image, and showing a translucent gray box of the
same size as the image in the image's place if the original image's
dimensions can be decoded from the returned range.

Currently, this behavior is only activated via a blink-settings flag. In
the future, features such as Data Saver will activate this functionality
to save data for users.

BUG= 605350 , 605351 

Review-Url: https://codereview.chromium.org/2423683002
Cr-Commit-Position: refs/heads/master@{#427141}

[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/css/CSSImageValue.cpp
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/FetchRequest.cpp
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/FetchRequest.h
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/ImageResource.h
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/Resource.h
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/frame/Settings.in
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/platform/graphics/PlaceholderImage.cpp
[add] https://crrev.com/72b7454b7d1ea60317365a076187da54e646e88e/third_party/WebKit/Source/platform/graphics/PlaceholderImage.h

Blocking: 605347
Blockedon: -605347
Status: Fixed (was: Started)

Sign in to add a comment