In example https://findit-for-me.appspot.com/build-failure?url=https%3A%2F%2Fbuild.chromium.org%2Fp%2Fchromium.webkit%2Fbuilders%2FWebKit%2520Win%2520x64%2520Builder%2Fbuilds%2F81139, the try job link is unavailable and the result is not found.

The root cause is the corresponding variable builder was misspelled in Findit's config, leading to failure of a try job to run.

Buildbucket however reports the run as completed, with the error information captured in result_json_details. For example:

'{
  "kind": "buildbucket#resourcesItem",
  "etag": "\\"K-c_AoveP5f6qkVevC_zAh9t5ts/Y47CEK7Jq0pj6vaWJzCgl8LlOBQ\\"",
  "build": {
    "status": "COMPLETED",
    "created_ts": "1461181975461970",
    "tags": ["user_agent:findit"],
    "completed_ts": "1461181976737350",
    "bucket": "master.tryserver.chromium.win",
    "result_details_json": "{
      \\"error\\": {
      \\"message\\": \\"Builder win_chromium_variable_webkit_builder_x64 not found\\" <-- Does not exist, should have been win_chromium_variable_webkit__win7_builder_x64 
      }
    }",
    "status_changed_ts":
    "1461181976737320",
    "created_by": "user:findit-for-me@appspot.gserviceaccount.com",
    "failure_reason": "INVALID_BUILD_DEFINITION",
    "result": "FAILURE",
    "utcnow_ts": "1461195013370780",
    "parameters_json": "{
      \\"builder_name\\": \\"win_chromium_variable_webkit_builder_x64\\",
      \\"properties\\": {
        \\"bad_revision\\":
        \\"28c3d160bd3817b51e4c9a20353642ad60dca0ea\\",
        \\"good_revision\\": \\"edafde65ae1b3e753dfabdaaffddafacd6e44805\\",
        \\"recipe\\": \\"findit/chromium/compile\\",
        \\"referenced_build_url\\": \\"https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/81139\\",
        \\"target_buildername\\": \\"WebKit Win x64 Builder\\",
        \\"target_mastername\\": \\"chromium.webkit\\"
      }
    }",
    "id": "9014833365066704416",
    "updated_ts": "1461181976737620"
  }
}'

Currently findit/common/waterfall/buildbucket_client.py only accounts for "error" being set in "build", but not "result": "FAILURE" or "failure_reason", or result_details_json containing errors.

In try job metadata, such an error should be reported.