New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605338 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Button padding decreased from 16px to 12px

Project Member Reported by bettes@chromium.org, Apr 20 2016

Issue description

Inner-padding of MD buttons has been revised, moving from 16px to 12px. Please update all instances. 

Updated spec: 
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_buttons.png%3Fz=width


 
Screen Shot 2016-04-20 at 4.39.44 PM.png
45.5 KB View Download

Comment 1 by bettes@chromium.org, Apr 20 2016

Does this screen shot look the way you'd like it
(with respect to the button sizing and placement)?
Here's a larger shot
Status: Started (was: Assigned)
Screenshot from 2016-05-13 18:32:07.png
58.6 KB View Download
#3: why do the paddings on SIGN OUT and RESET TO DEFAULT seem different?

Comment 7 by bettes@chromium.org, May 16 2016

These don't look correct to me. There seems to be >4px on the RHS and <4px on the LHS
Screenshot from 2016-05-16 14:00:34.png
46.4 KB View Download
@michaelpg, I uploaded a new image. They should align consistently - though they still may need to be moved a bit.

@bettes, the thing that is confusing me is that the margins are 20px and the button placement is 12px + 4px and the buttons should line up with other elements. There are 4px unaccounted for that I'm trying to understand better.
Sorry, to clarify it'd be 12px + 8px :)
And that's also true for buttons and vertical separators. 8px between left edge of button-bounds and rule-line
Alan, should the buttons with a solid blue background line up on
their outer button edge, or line up on their text label (just like
the other buttons)?
I chatted with Alan. He requests that in the one case where
the blue background button is in question, that we change that
button to be blue text on a white background. (Then line it up
by the text label).
Project Member

Comment 14 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7fd553da5d05419301e2395118fa2e133b9e62f

commit b7fd553da5d05419301e2395118fa2e133b9e62f
Author: dschuyler <dschuyler@chromium.org>
Date: Mon May 23 21:58:54 2016

[MD settings] change button padding and placement

This CL changes the button padding to be 12px on each side and
causes the button padding to extend into the margins so that
the button text lines up with the .settings-box margins.

The button style for Sign Into Chrome has also changed from
an action style to a primary style.

BUG= 605338 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1981423002
Cr-Commit-Position: refs/heads/master@{#395427}

[modify] https://crrev.com/b7fd553da5d05419301e2395118fa2e133b9e62f/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/b7fd553da5d05419301e2395118fa2e133b9e62f/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/b7fd553da5d05419301e2395118fa2e133b9e62f/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/b7fd553da5d05419301e2395118fa2e133b9e62f/chrome/browser/resources/settings/system_page/system_page.html

Status: Fixed (was: Started)

Sign in to add a comment