New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605327 link

Starred by 1 user
Status: Fixed
Owner:
█ rolfe@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
reillyg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

USB tab indicator not transparent on OS X

Project Member Reported by reillyg@chromium.org, Apr 20 2016 
The image assets from  issue 592105  have no transparency so white border around the tab indicator is visible over the tab's natural grey background.

rolfe@, can you cut new assets that have transparency?

Comment 1 by rolfe@chromium.org, Apr 21 2016 

Apologies - the original pngs should have had transparent backgrounds. Try the attached.
omnibox_usb_1x.png
323 bytes View Download
omnibox_usb_2x.png
492 bytes View Download

Comment 3 by reillyg@chromium.org, Apr 21 2016

Status: Fixed (was: Assigned)

Comment 4 by reillyg@chromium.org, Apr 21 2016

Labels: Merge-Request-51

Comment 5 by tin...@google.com, Apr 22 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 22 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85e3a24f2422349593de15c9bb21e737d7bf3b6d

commit 85e3a24f2422349593de15c9bb21e737d7bf3b6d
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Apr 22 21:44:30 2016

Update USB tab indicator assets for OS X.

The new versions are properly transparent.

BUG= 605327 

Review URL: https://codereview.chromium.org/1910263002

Cr-Commit-Position: refs/heads/master@{#388925}
(cherry picked from commit 05db32e533e6fc55fccfe1d3aaf2119b831ecf43)

Review URL: https://codereview.chromium.org/1914753002 .

Cr-Commit-Position: refs/branch-heads/2704@{#198}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/85e3a24f2422349593de15c9bb21e737d7bf3b6d/chrome/app/theme/default_100_percent/legacy/tab_usb_indicator.png
[modify] https://crrev.com/85e3a24f2422349593de15c9bb21e737d7bf3b6d/chrome/app/theme/default_200_percent/legacy/tab_usb_indicator.png

Comment 7 by lafo...@chromium.org, Dec 9 2016

Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label
►

Sign in to add a comment