New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605326 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Not currently working on Chromium
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Disable Origin Trials for Bluetooth and USB

Project Member Reported by scheib@chromium.org, Apr 20 2016

Issue description

Disable Origin Trials for Bluetooth and USB.
 
Labels: Needs-Feedback
scheib@ : Could you please let us know if there is any repro steps for further triaging and can be doable from Chrome-TE side.

Comment 2 by scheib@chromium.org, Apr 26 2016

Sorry for delay -- I'll move patchs forward today on this and they will include TEST lines. (they will be along the lines of  issue 584113 )
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/865f2de76200b7bf8362d4bd6ee9b7de2de3058e

commit 865f2de76200b7bf8362d4bd6ee9b7de2de3058e
Author: scheib <scheib@chromium.org>
Date: Wed Apr 27 21:39:31 2016

bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

BUG= 605326 ,  584113 

TEST=To verify:

Check the following with chrome launched with command line flag:
  --enable-blink-features=ExperimentalFramework

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

Check the following with chrome launched with command line flags:
 --enable-blink-features=ExperimentalFramework --enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

Review-Url: https://codereview.chromium.org/1917313002
Cr-Commit-Position: refs/heads/master@{#390198}

[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/modules/bluetooth/Bluetooth.idl
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.idl
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.idl
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.idl
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.idl
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/403af928b91df81acac1fc3b27fc093f2eb6da24

commit 403af928b91df81acac1fc3b27fc093f2eb6da24
Author: scheib <scheib@chromium.org>
Date: Mon May 02 23:28:39 2016

Move WebUSB from OriginTrialEnabled to RuntimeEnabled.

This reverses commit 5c00cb62536b679d52c3741598d3f08f79e7e32f.

BUG= 605326 ,  492204 

TEST=To verify:

On Windows, Chrome OS, Mac OSX:

Check the following with chrome launched without command line flags:

For each site:
 https://permission.site
 http://permission.site
Load and press the USB button.
 Expect in Chrome Developer Tools: Console output:
  "Uncaught TypeError: Cannot read property 'requestDevice' of undefined"

Check the following with chrome launched with command line flag:
 --enable-blink-features=ExperimentalFramework

For https://permission.site
Load and press the USB button.
 Expect a chooser dialog to open.

For http://permission.site
Load and press the USB button.
 Expect in Chrome Developer Tools: Console output:
  "error usb DOMException: Only secure origins are allowed (see: https://goo.gl/Y0ZkNV)."

Review-Url: https://codereview.chromium.org/1917103004
Cr-Commit-Position: refs/heads/master@{#391090}

[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USB.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBAlternateInterface.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBConfiguration.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBConnectionEvent.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBDevice.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBEndpoint.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBInTransferResult.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBInterface.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferResult.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferPacket.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferResult.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/modules/webusb/USBOutTransferResult.idl
[modify] https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Labels: -Needs-Feedback Needs-TestConfirmation

Comment 6 by ajha@chromium.org, May 4 2016

Cc: ajha@chromium.org
Labels: Needs-Feedback
Thanks scheib@ for the verification steps in C#3 and C#4.

C#3 Verification:
=================
All the scenarios related to Linux, OSX(Mac OS 10.11.4) and Windows(7) are working as intended on the latest canary(52.0.2724.0)

C#4 Verification:
=================
# Scenario 1 works as intended on OSX(Mac OS 10.11.4) and Windows(7) on the latest canary(52.0.2724.0)
# Scenario 2(Launching with Commandlineflag) doesn't work at all on Mac and Windows on the latest canary(52.0.2724.0). Attached is the screen-cast of the same.

scheib@: Could you please review the attached screen-cast and confirm if anything is being missed there.

Thanks in advance!


605326.mp4
3.3 MB Download
Cc: -ajha@chromium.org
Labels: -Needs-Feedback
Owner: ajha@chromium.org
Thank you, I was able to confirm just now with 52.0.2725.0 --- I think the USB patch may not have made it into the ...2724... build. Would you please try again.

Also, the feature will only with with HTTPS (which I see you tested -- but just pointing that out again).

Comment 8 by ajha@chromium.org, May 6 2016

Cc: ajha@chromium.org
Labels: Needs-Feedback
Owner: scheib@chromium.org
Still no luck in reproducing(USB patch with commandline flag) on the latest canary(52.0.2726.0) on Windows-7 and Mac OS 10.11.4.

Attached is the screen-cast of the same.

scheib@: Please review the attached screen-cast and confirm if anything is being missed here.
605326_1.mp4
5.5 MB Download
Labels: -Needs-Feedback
Owner: ajha@chromium.org
Apologies, I provided the wrong command line flag in C#4 Step 2.

The experimental command line flag should be:
  --enable-experimental-web-platform-features

Comment 10 by ajha@chromium.org, May 9 2016

Labels: -Needs-TestConfirmation TE-Verified-M52 TE-Verified-52.0.2729.0
Owner: scheib@chromium.org
Thanks for the clarification. This is working fine on the latest canary(52.0.2729.0) on Windows-7 and Mac OS 10.11.4. Attached is the screenshot of the same.
605326.jpg
381 KB View Download
Labels: Merge-Request-51

Comment 12 by tin...@google.com, May 9 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 13 by bugdroid1@chromium.org, May 9 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/917f6d0b356ed63a6edd62b07b1595c99d2781a7

commit 917f6d0b356ed63a6edd62b07b1595c99d2781a7
Author: Vincent Scheib <scheib@chromium.org>
Date: Mon May 09 18:55:24 2016

bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

BUG= 605326 ,  584113 

TEST=To verify:

Check the following with chrome launched with command line flag:
  --enable-blink-features=ExperimentalFramework

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

Check the following with chrome launched with command line flags:
 --enable-blink-features=ExperimentalFramework --enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

Review-Url: https://codereview.chromium.org/1917313002
Cr-Commit-Position: refs/heads/master@{#390198}
(cherry picked from commit 865f2de76200b7bf8362d4bd6ee9b7de2de3058e)

Review URL: https://codereview.chromium.org/1960263002 .

Cr-Commit-Position: refs/branch-heads/2704@{#448}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/modules/bluetooth/Bluetooth.idl
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.idl
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.idl
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.idl
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.idl
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/917f6d0b356ed63a6edd62b07b1595c99d2781a7/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Project Member

Comment 14 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/499429ab56d93c5e90c338fdb6d42e9987b3e508

commit 499429ab56d93c5e90c338fdb6d42e9987b3e508
Author: Vincent Scheib <scheib@chromium.org>
Date: Mon May 09 19:12:19 2016

Move WebUSB from OriginTrialEnabled to RuntimeEnabled.

This reverses commit 5c00cb62536b679d52c3741598d3f08f79e7e32f.

BUG= 605326 ,  492204 

TEST=To verify:

On Windows, Chrome OS, Mac OSX:

Check the following with chrome launched without command line flags:

For each site:
 https://permission.site
 http://permission.site
Load and press the USB button.
 Expect in Chrome Developer Tools: Console output:
  "Uncaught TypeError: Cannot read property 'requestDevice' of undefined"

Check the following with chrome launched with command line flag:
 --enable-blink-features=ExperimentalFramework

For https://permission.site
Load and press the USB button.
 Expect a chooser dialog to open.

For http://permission.site
Load and press the USB button.
 Expect in Chrome Developer Tools: Console output:
  "error usb DOMException: Only secure origins are allowed (see: https://goo.gl/Y0ZkNV)."

Review-Url: https://codereview.chromium.org/1917103004
Cr-Commit-Position: refs/heads/master@{#391090}
(cherry picked from commit 403af928b91df81acac1fc3b27fc093f2eb6da24)

Review URL: https://codereview.chromium.org/1959143002 .

Cr-Commit-Position: refs/branch-heads/2704@{#449}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USB.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBAlternateInterface.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBConfiguration.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBConnectionEvent.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBDevice.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBEndpoint.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBInTransferResult.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBInterface.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferResult.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferPacket.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferResult.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/modules/webusb/USBOutTransferResult.idl
[modify] https://crrev.com/499429ab56d93c5e90c338fdb6d42e9987b3e508/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

A friendly reminder that M51 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by May 17. All changes MUST be merged into the release branch by 5pm on May 20 to make into the desktop Stable final build cut. Thanks!
Status: Fixed (was: Started)

Sign in to add a comment