New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605324 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

VT2 terminal font size is very small

Project Member Reported by sdantul...@chromium.org, Apr 20 2016

Issue description

Google Chrome	52.0.2712.0 (Official Build) dev (64-bit)
Revision	0
Platform	8218.0.0 (Official Build) dev-channel link

What steps will reproduce the problem?
Open VT2 terminal

What do you see instead?
Font size is very small

Issue seen only on Link.
 
Cc: osh...@chromium.org
Can you check Samus as well?
Reproduced on Samus as well.

Comment 3 by osh...@chromium.org, Apr 21 2016

Owner: dbehr@chromium.org
Status: Assigned (was: Untriaged)
to dbehr@ who is frecon expert.

Comment 4 by dbehr@chromium.org, Apr 24 2016

Cc: ihf@chromium.org dbehr@chromium.org marc...@chromium.org
 Issue 605797  has been merged into this issue.

Comment 5 by dbehr@chromium.org, Apr 24 2016

Status: Started (was: Assigned)
Yeah, after I added starting frecon with no DRM objects scaling is initialized to 1 and then is not reinitialized when we create real DRM object and set scaling because of refcount in font module.
Working on a fix.

Comment 6 by dbehr@chromium.org, Apr 26 2016

Cc: h...@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/frecon/+/a3f65714568aaadaa3122c76c1187935f0d26247

commit a3f65714568aaadaa3122c76c1187935f0d26247
Author: Dominik Behr <dbehr@chromium.org>
Date: Tue Apr 26 00:42:14 2016

frecon: free font before resizing

Font module creates prescaled glyphs on first init. term_resize()
reinitializes font module but so far it has been only freed in term_close()
so font module refcount keeps on increasing. The font needs to be freed
before every term_resize() to balance font_init() in term_resize().

BUG= chromium:605324 
TEST=boot Samus and switch to developer console using CTRL-ALT-F2 and\
observe font size

Change-Id: I08449bdb5f57b4137599ec5ecccb8b339e26b278
Signed-off-by: Dominik Behr <dbehr@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/340565
Commit-Ready: Dominik Behr <dbehr@google.com>
Tested-by: Dominik Behr <dbehr@google.com>
Reviewed-by: Haixia Shi <hshi@chromium.org>

[modify] https://crrev.com/a3f65714568aaadaa3122c76c1187935f0d26247/term.c

Comment 8 by dbehr@chromium.org, Apr 29 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 8270.0.0, 52.0.2721.0

Sign in to add a comment