New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605320 link

Starred by 3 users
Status: Assigned
Owner:
sque@chromium.org
Cc:
█ dhsharp@chromium.org
wfh@chromium.org
█ tipp@chromium.org
█ bccheng@chromium.org
█ chongjiang@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature
cwp

Blocking:
issue 382705



Sign in to add a comment

Decide on runtime memory leak detection policy for ARM

Project Member Reported by sque@chromium.org, Apr 20 2016 
Should it be enabled in ARM? The leak detector requires Chrome to be built with frame pointer. That's currently the case on x86_64 but not on ARM.

In the future, we should decide whether it's worth the effort to enable frame pointer on ARM. For now, let's explicitly disable the leak detector on ARM.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/961ce9c8e5f7aae2685286356c2130373ba14fe0

commit 961ce9c8e5f7aae2685286356c2130373ba14fe0
Author: sque <sque@chromium.org>
Date: Thu Apr 21 04:42:55 2016

Enable Runtime Memory Leak Detector on x86_64 only

The leak detector requires Chrome to be compiled with frame pointer,
which is the case for Chrome OS x86_64. But not on 32-bit x86 or ARM.

BUG=chromium:605320
TEST=build successfully. Add a CHECK(false) to leak detector and build
for x86_64 and ARM. It should crash on x86_64 but not on ARM.

R=asvitkine@chromium.org, isherman@chromium.org

Review URL: https://codereview.chromium.org/1905793002

Cr-Commit-Position: refs/heads/master@{#388694}

[modify] https://crrev.com/961ce9c8e5f7aae2685286356c2130373ba14fe0/chrome/browser/metrics/chromeos_metrics_provider.cc
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 13 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment