New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605319 link

Starred by 1 user
Status: Fixed
Owner:
█ wkorman@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
wangxianzhu@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 529938



Sign in to add a comment

Visual rect is incorrect for newline characters.

Project Member Reported by wkorman@chromium.org, Apr 20 2016 
Breakout from  http://crbug.com/529938  --

Attached test case (a simplified version of editing/selection/image-before-linebreak.html) shows the issue.

Line breaks in contenteditable blocks are implemented with a line break InlineTextBox that reports zero width/height which leads to an empty visual rect size.

Thus we miss the display item when querying via cc RTree and don't paint it, which is fine except when we're selected and need to paint the selection newline highlight.

Fixes can include:

- rework InlineTextBox::visualRect() to incorporate more of the logic in InlineTextBoxPainter::paint() where we calculate the cull rect
- (likely preferred but a larger change) rework selection newline highlights to be included in the logical visual overflow of the inline text box
newline.html
219 bytes View Download
abe.png
12.0 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76f9a545cdf9903cded65e98b616a14976428aa8

commit 76f9a545cdf9903cded65e98b616a14976428aa8
Author: wkorman <wkorman@chromium.org>
Date: Thu May 19 17:35:25 2016

Include selection rect in paint invalidation for LayoutText.

This change is intended to fix the paint invalidation rect, and thus
the visual rect, as part of the linked bug  http://crbug.com/605319 
spun out of  http://crbug.com/529938 . There is more explanation of
the intended use of visual rects in my comment at
 http://crbug.com/604883#c5 

The visual rects that are incorrect without this change are not
currently used by live code, but will be used as part of
http://crrev.com/1484163002. This change fixes about 15 LayoutTests
with that patch applied, mainly under editing.

BUG= 605319 

Review-Url: https://codereview.chromium.org/1955423004
Cr-Commit-Position: refs/heads/master@{#394807}

[modify] https://crrev.com/76f9a545cdf9903cded65e98b616a14976428aa8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/76f9a545cdf9903cded65e98b616a14976428aa8/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/76f9a545cdf9903cded65e98b616a14976428aa8/third_party/WebKit/Source/core/paint/BoxClipper.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff61209663b4bc68b815a4c1e6ed9bb808730760

commit ff61209663b4bc68b815a4c1e6ed9bb808730760
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu May 19 18:51:28 2016

Auto-rebaseline for r394807

https://chromium.googlesource.com/chromium/src/+/76f9a545c

BUG= 605319 
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/1998663003 .

Cr-Commit-Position: refs/heads/master@{#394826}

[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/fast/repaint/selection-change-in-iframe-with-relative-parent-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/paint/selection/invalidation-rect-includes-newline-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/paint/selection/invalidation-rect-includes-newline-for-rtl-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/paint/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/paint/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/paint/selection/invalidation-rect-with-br-includes-newline-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/linux/compositing/squashing/selection-repaint-with-gaps-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/japanese-rl-selection-clear-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/japanese-rl-selection-repaint-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selection-after-delete-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selection-after-remove-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selection-clear-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selection-partial-invalidation-between-blocks-expected.txt
[add] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/linux/paint/selection/invalidation-rect-includes-newline-expected.txt
[add] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/linux/paint/selection/invalidation-rect-includes-newline-for-rtl-expected.txt
[add] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/linux/paint/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt
[add] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/linux/paint/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/japanese-rl-selection-repaint-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/mac/compositing/squashing/selection-repaint-with-gaps-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-clear-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-after-delete-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-after-remove-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-clear-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-partial-invalidation-between-blocks-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win/compositing/squashing/selection-repaint-with-gaps-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win/fast/repaint/japanese-rl-selection-clear-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win/fast/repaint/japanese-rl-selection-repaint-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-after-delete-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-after-remove-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-clear-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-partial-invalidation-between-blocks-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win/fast/repaint/text-selection-rect-in-overflow-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/japanese-rl-selection-clear-expected.txt
[modify] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/japanese-rl-selection-repaint-expected.txt
[add] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-expected.txt
[add] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-for-rtl-expected.txt
[add] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt
[add] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt
[add] https://crrev.com/ff61209663b4bc68b815a4c1e6ed9bb808730760/third_party/WebKit/LayoutTests/platform/win7/paint/selection/invalidation-rect-with-br-includes-newline-expected.txt

Comment 3 by hirosh...@chromium.org, May 19 2016 

The following tests are failing on Windows after the CLs at Comment #1 and #2.
  paint/selection/invalidation-rect-includes-newline-for-rtl.html
  paint/selection/invalidation-rect-includes-newline-for-vertical-lr.html
  paint/selection/invalidation-rect-includes-newline-for-vertical-rl.html
  paint/selection/invalidation-rect-includes-newline.html
  paint/selection/invalidation-rect-with-br-includes-newline.html

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=paint%2Fselection%2Finvalidation-rect-includes-newline-for-rtl.html%0Apaint%2Fselection%2Finvalidation-rect-includes-newline-for-vertical-lr.html%0Apaint%2Fselection%2Finvalidation-rect-includes-newline-for-vertical-rl.html%0Apaint%2Fselection%2Finvalidation-rect-includes-newline.html%0Apaint%2Fselection%2Finvalidation-rect-with-br-includes-newline.html

Rebaseline errors?
I'll mark the tests as failing. Please take a look.
Project Member

Comment 4 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eec5156c42b5c4e03073a1db30c7b691e1f69e3

commit 9eec5156c42b5c4e03073a1db30c7b691e1f69e3
Author: hiroshige <hiroshige@chromium.org>
Date: Fri May 20 03:34:41 2016

Mark some paint/selection/invalidation-rect* tests as failing on Windows

TBR=gogerald@chromium.org, spqchan@chromium.org
BUG= 605319 

Review-Url: https://codereview.chromium.org/1997953002
Cr-Commit-Position: refs/heads/master@{#394983}

[modify] https://crrev.com/9eec5156c42b5c4e03073a1db30c7b691e1f69e3/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by wangxianzhu@chromium.org, May 20 2016 

It seems that the rebaselines on Win7 are incorrect (and perhaps unnecessary):

LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-expected.txt
LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt
LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt
LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-for-rtl-expected.txt
LayoutTests/platform/win7/paint/selection/invalidation-rect-with-br-includes-newline-expected.txt

The actual results seem just the same as the expectations under the non-platform directory.

Comment 6 by wangxianzhu@chromium.org, May 20 2016 

FYI LayoutTests/platform/android also contains very out-dated expectations for these tests.

Comment 7 by wangxianzhu@chromium.org, May 20 2016

Cc: wangxianzhu@chromium.org

Comment 8 by wkorman@chromium.org, May 23 2016 

Re: Android tests in comment #6,  crbug.com/611462  has these tests marked as Missing for Android, so they were likely skipped by auto-rebaseline.

Re: Win7 tests, hmm, I'm investigating.

Comment 9 Deleted

Comment 10 by wangxianzhu@chromium.org, May 23 2016 

Re: Android tests, the tests were marked Missing for all platforms after the rebaseline. I think this is bug 546746.
Project Member

Comment 11 by bugdroid1@chromium.org, May 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bb1561635970d1e85e04e6d7231ce8fe2e213b8

commit 0bb1561635970d1e85e04e6d7231ce8fe2e213b8
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon May 23 22:56:00 2016

Rebaseline for  crbug.com/611462 

Manual rebaseline to generate the missing pixel expectations.
Also BTW rebaselined several wrong baselines for  bug 605319 .

BUG= 611462 , 605319 
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2005903002
Cr-Commit-Position: refs/heads/master@{#395447}

[modify] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/fast/images/repaint-subrect-grid-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/fast/repaint/canvas-putImageData-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/fast/repaint/invalidate-paint-for-fixed-pos-inside-iframe-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/editing/selection/repaint-rect-for-vertical-writing-mode-with-positioned-root-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/4776765-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/button-checkbox-click-method-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/canvas-resize-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/canvas-resize-no-full-invalidation-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/caret-invalidation-in-overflow-scroll-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/caret-outside-block-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/caret-with-transformation-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/delete-into-nested-block-expected.png
[modify] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/delete-into-nested-block-expected.txt
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/focus-enable-continuations-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/inline-focus-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/inline-outline-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/japanese-rl-selection-clear-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/japanese-rl-selection-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/paint-invalidation-with-reparent-across-frame-boundaries-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selected-replaced-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selection-after-delete-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selection-after-remove-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selection-clear-after-move-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selection-clear-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selection-partial-invalidation-between-blocks-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selection-rl-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/subtree-root-skipped-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/text-selection-rect-in-overflow-2-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/non-text-link-invalidation-optimization-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/button-checkbox-click-method-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/caret-invalidation-in-overflow-scroll-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/japanese-rl-selection-clear-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/japanese-rl-selection-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/subtree-root-skipped-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/button-checkbox-click-method-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/caret-invalidation-in-overflow-scroll-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/japanese-rl-selection-clear-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/japanese-rl-selection-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/repaint-across-writing-mode-boundary-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/subtree-root-skipped-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/editing/selection/repaint-rect-for-vertical-writing-mode-with-positioned-root-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/4776765-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/button-checkbox-click-method-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/canvas-resize-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/canvas-resize-no-full-invalidation-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/caret-invalidation-in-overflow-scroll-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/caret-outside-block-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/caret-with-transformation-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/delete-into-nested-block-expected.png
[modify] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/delete-into-nested-block-expected.txt
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/focus-enable-continuations-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/inline-focus-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/inline-outline-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-clear-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/paint-invalidation-with-reparent-across-frame-boundaries-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selected-replaced-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-after-delete-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-after-remove-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-change-in-iframe-with-relative-parent-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-clear-after-move-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-clear-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-partial-invalidation-between-blocks-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-rl-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/non-text-link-invalidation-optimization-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/paint/selection/invalidation-rect-includes-newline-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/paint/selection/invalidation-rect-includes-newline-for-rtl-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/paint/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/paint/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/mac/paint/selection/invalidation-rect-with-br-includes-newline-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/editing/selection/repaint-rect-for-vertical-writing-mode-with-positioned-root-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/4776765-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/button-checkbox-click-method-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/canvas-resize-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/canvas-resize-no-full-invalidation-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/caret-invalidation-in-overflow-scroll-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/caret-outside-block-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/caret-with-transformation-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/delete-into-nested-block-expected.png
[modify] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/delete-into-nested-block-expected.txt
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/focus-enable-continuations-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/inline-focus-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/inline-outline-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/japanese-rl-selection-clear-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/japanese-rl-selection-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/paint-invalidation-with-reparent-across-frame-boundaries-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selected-replaced-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-after-delete-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-after-remove-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-change-in-iframe-with-relative-parent-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-clear-after-move-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-clear-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-partial-invalidation-between-blocks-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-rl-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/subtree-root-skipped-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/fast/repaint/text-selection-rect-in-overflow-2-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/non-text-link-invalidation-optimization-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/paint/selection/invalidation-rect-includes-newline-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/paint/selection/invalidation-rect-includes-newline-for-rtl-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/paint/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/paint/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win/paint/selection/invalidation-rect-with-br-includes-newline-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/japanese-rl-selection-clear-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/japanese-rl-selection-repaint-expected.png
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/repaint-across-writing-mode-boundary-expected.png
[delete] https://crrev.com/e866443cc0280b421dd7527a737e5acdfc631bd7/third_party/WebKit/LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-expected.txt
[delete] https://crrev.com/e866443cc0280b421dd7527a737e5acdfc631bd7/third_party/WebKit/LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-for-rtl-expected.txt
[delete] https://crrev.com/e866443cc0280b421dd7527a737e5acdfc631bd7/third_party/WebKit/LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt
[delete] https://crrev.com/e866443cc0280b421dd7527a737e5acdfc631bd7/third_party/WebKit/LayoutTests/platform/win7/paint/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt
[delete] https://crrev.com/e866443cc0280b421dd7527a737e5acdfc631bd7/third_party/WebKit/LayoutTests/platform/win7/paint/selection/invalidation-rect-with-br-includes-newline-expected.txt
[add] https://crrev.com/0bb1561635970d1e85e04e6d7231ce8fe2e213b8/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/repaint-subrect-grid-expected.png

Comment 12 by wkorman@chromium.org, May 26 2016

Status: Fixed (was: Started)
Looks like no remaining 605319 marked entries in TestExpectations.
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85eb563218e8b7af05360745aae05a2c79f80824

commit 85eb563218e8b7af05360745aae05a2c79f80824
Author: dpranke <dpranke@chromium.org>
Date: Mon Jun 06 15:43:08 2016

Flip more Win bots to GN.

This flips the remaining Win builders on the chromium, chromium.chrome,
and chromium.perf waterfalls, as well as the matching trybots. The
remaining GYP win builders are FYI bots, memory bots, and the official
builders; the latter should be flipped ASAP after this lands to avoid
any skew.

R=brucedawson@chromium.org
BUG= 605319 

Review-Url: https://codereview.chromium.org/2030823002
Cr-Commit-Position: refs/heads/master@{#398033}

[modify] https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824/tools/mb/mb_config.pyl
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffd608485f3df47c83c3216f717e6c1b1fc828ee

commit ffd608485f3df47c83c3216f717e6c1b1fc828ee
Author: kinuko <kinuko@chromium.org>
Date: Tue Jun 07 09:25:14 2016

Revert of Flip more Win bots to GN. (patchset #1 id:1 of https://codereview.chromium.org/2030823002/ )

Reason for revert:
Suspected to break Chrome Win builder. (Will revert this revert if it was a false alarm)

Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/7879/steps/compile/logs/stdio

C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome chrome_official_builder_no_unittests -j200
ninja: Entering directory `C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'

Original issue's description:
> Flip more Win bots to GN.
>
> This flips the remaining Win builders on the chromium, chromium.chrome,
> and chromium.perf waterfalls, as well as the matching trybots. The
> remaining GYP win builders are FYI bots, memory bots, and the official
> builders; the latter should be flipped ASAP after this lands to avoid
> any skew.
>
> R=brucedawson@chromium.org
> BUG= 605319 
>
> Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
> Cr-Commit-Position: refs/heads/master@{#398033}

TBR=brucedawson@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605319 

Review-Url: https://codereview.chromium.org/2046913002
Cr-Commit-Position: refs/heads/master@{#398257}

[modify] https://crrev.com/ffd608485f3df47c83c3216f717e6c1b1fc828ee/tools/mb/mb_config.pyl
►

Sign in to add a comment