New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605318 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 498033
issue 618038
issue 622715
issue 624132



Sign in to add a comment

Flip all remaining Win bots over to GN

Project Member Reported by dpranke@chromium.org, Apr 20 2016

Issue description

This is a tracking bug to flip all of the windows builders over to GN:

- every bot on tryserver.chromium.win
- every builder on chromium.win
- the win builders on:
  - chromium.perf
  - chromium.lkgr
  - chromium.memory.fyi
  - chromium
  - chromium.chrome
  - chromium.webkit
  - tryserver.blink
  - official.desktop.continuous
  - official.desktop

possibly others on nacl, webrtc, pdfium, v8, etc.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/36dd7568f812d3be983acb303e0224329ab19cce

commit 36dd7568f812d3be983acb303e0224329ab19cce
Author: dpranke <dpranke@google.com>
Date: Thu Apr 21 21:52:31 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/ef9df5979d9e39bfc87f71ae04c8687424358eaf

commit ef9df5979d9e39bfc87f71ae04c8687424358eaf
Author: dpranke@chromium.org <dpranke@chromium.org>
Date: Thu Apr 21 22:13:10 2016

Remove obsolete chromium.fyi bots.

This CL removes a bunch of unneeded, unmaintained bots:

- Chromium Builder
- Chromium Builder (dbg)
- Chromium Win MiniInstaller Tests
- Chromium Win x64 Clobber (will move to the chromium master)
- Ozone ECS Linux (obsoleted by Cast bots)
- Vista Tests (dbg)(1)
- Vista Tests (dbg)(2)
- Win8 Tests(1)
- Win8 Tests(2)
- Windows 8 App Certification
- Windows Browser (Drmemory Light) (1)
- Windows Browser (Drmemory Light) (2)
- Windows Builder (DrMemory)
- Windows Tests (DrMemory)

R=scottmg@chromium.org, brucedawson@chromium.org
BUG= 605732 ,  605318 

Review URL: https://codereview.chromium.org/1908133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300095 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/ef9df5979d9e39bfc87f71ae04c8687424358eaf/masters/master.chromium.fyi/master.cfg
[modify] https://crrev.com/ef9df5979d9e39bfc87f71ae04c8687424358eaf/masters/master.chromium.fyi/slaves.cfg
[modify] https://crrev.com/ef9df5979d9e39bfc87f71ae04c8687424358eaf/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[delete] https://crrev.com/fab0c770b7ce3c9fdad595a6eb001a43550afacb/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Win_Builder.json

Labels: -Pri-3 Pri-1
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/995095d51f434da8cb261a8f1a3c52a89f09f403

commit 995095d51f434da8cb261a8f1a3c52a89f09f403
Author: dpranke <dpranke@chromium.org>
Date: Fri Apr 22 00:40:44 2016

Add new 'Win x64', 'Win 10 Fast Ring' bot configs to MB.

R=scottmg@chromium.org, wfh@chromium.org
BUG= 605318 

Review URL: https://codereview.chromium.org/1907083003

Cr-Commit-Position: refs/heads/master@{#388979}

[modify] https://crrev.com/995095d51f434da8cb261a8f1a3c52a89f09f403/tools/mb/mb_config.pyl

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/5a82730b113d550b14d3d63befbf4a9a2753c45a

commit 5a82730b113d550b14d3d63befbf4a9a2753c45a
Author: dpranke@chromium.org <dpranke@chromium.org>
Date: Fri Apr 22 00:54:28 2016

Move Win x64 clobber bot and remove Win x64 GN bots.

This CL moves the Win x64 Clobber bot to the chromium waterfall
(from the FYI waterfall), and removes the x64 GN bots, now that
the main bots have been flipped to GN.

R=scottmg@chromium.org, wfh@chromium.org, brucedawson@chromium.org
BUG= 605318 

Review URL: https://codereview.chromium.org/1905213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300102 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/masters/master.chromium.win/master_win_cfg.py
[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/masters/master.chromium.win/slaves.cfg
[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/masters/master.chromium/master_full_cfg.py
[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/masters/master.chromium/slaves.cfg
[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/masters/master.tryserver.chromium.win/master.cfg
[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/masters/master.tryserver.chromium.win/slaves.cfg
[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/scripts/slave/recipe_modules/chromium_tests/chromium.py
[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py
[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/scripts/slave/recipe_modules/chromium_tests/chromium_win.py
[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/scripts/slave/recipe_modules/chromium_tests/trybots.py
[copy] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json
[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_x64_GN.json
[modify] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_x64_GN__dbg_.json
[delete] https://crrev.com/f8ac28628938ee8276c2be5d0cb4e85bc30d1735/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_GN.json
[delete] https://crrev.com/f8ac28628938ee8276c2be5d0cb4e85bc30d1735/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_GN__dbg_.json
[delete] https://crrev.com/f8ac28628938ee8276c2be5d0cb4e85bc30d1735/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_gn_x64_dbg.json
[rename] https://crrev.com/5a82730b113d550b14d3d63befbf4a9a2753c45a/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_x64_archive.json

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86917

------------------------------------------------------------------
r86917 | recipe-roller@chromium.org | 2016-04-22T01:42:48.002740Z

-----------------------------------------------------------------
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fa426bd8fc5ce52c6cf95eb4386552ae5eed4fd

commit 8fa426bd8fc5ce52c6cf95eb4386552ae5eed4fd
Author: wfh <wfh@chromium.org>
Date: Fri Apr 22 19:28:33 2016

Fix Win10 FYI bot name so it runs tests.

BUG= 605318 

Review URL: https://codereview.chromium.org/1905173003

Cr-Commit-Position: refs/heads/master@{#389209}

[modify] https://crrev.com/8fa426bd8fc5ce52c6cf95eb4386552ae5eed4fd/testing/buildbot/chromium.fyi.json

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9711369180264c97e942e0b6be83c3e17db5e326

commit 9711369180264c97e942e0b6be83c3e17db5e326
Author: dpranke <dpranke@chromium.org>
Date: Thu Apr 28 21:34:09 2016

Try to build 'gn_all' on Win x64 builders.

This CL adds the 'gn_all' additional_compile_target to
'Win x64 Builder' and 'Win x64 Builder (dbg)'; the former will
get mirrored onto 'win_chromium_x64_rel_ng' in the CQ as well.

This should allow us to catch a lot more of the compile-related issues
that seem to be cropping up as we switch the bots to GN.

This will likely increase the cycle times for the builder in the
CQ, but we don't know by how much.

We don't build 'all' because of  crbug.com/555273 . In theory, gn_all
should build everything that all does except for stamp files (any discrepancy is a bug), but in practice we're probably missing some things and need to hunt them down.

R=jam@chromium.org, brucedawson@chromium.org, thakis@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/1926723003
Cr-Commit-Position: refs/heads/master@{#390488}

[modify] https://crrev.com/9711369180264c97e942e0b6be83c3e17db5e326/testing/buildbot/chromium.win.json

Comment 10 by jam@chromium.org, May 5 2016

Since last thursday 50/90th has gone up a lot on both win & win64. As a result there are pending queues.
win.PNG
162 KB View Download
winx64.PNG
177 KB View Download
Project Member

Comment 11 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f414e44aac0f359a551409d4db5cd904742ec145

commit f414e44aac0f359a551409d4db5cd904742ec145
Author: jam <jam@chromium.org>
Date: Thu May 05 21:31:17 2016

Revert of Try to build 'gn_all' on Win x64 builders. (patchset #2 id:20001 of https://codereview.chromium.org/1926723003/ )

Reason for revert:
To see if windows bots' cycle time recovers.

Original issue's description:
> Try to build 'gn_all' on Win x64 builders.
>
> This CL adds the 'gn_all' additional_compile_target to
> 'Win x64 Builder' and 'Win x64 Builder (dbg)'; the former will
> get mirrored onto 'win_chromium_x64_rel_ng' in the CQ as well.
>
> This should allow us to catch a lot more of the compile-related issues
> that seem to be cropping up as we switch the bots to GN.
>
> This will likely increase the cycle times for the builder in the
> CQ, but we don't know by how much.
>
> We don't build 'all' because of  crbug.com/555273 . In theory, gn_all
> should build everything that all does except for stamp files (any discrepancy is a bug), but in practice we're probably missing some things and need to hunt them down.
>
> R=jam@chromium.org, brucedawson@chromium.org, thakis@chromium.org
> BUG= 605318 
>
> Committed: https://crrev.com/9711369180264c97e942e0b6be83c3e17db5e326
> Cr-Commit-Position: refs/heads/master@{#390488}

TBR=brucedawson@chromium.org,thakis@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605318 

Review-Url: https://codereview.chromium.org/1952863004
Cr-Commit-Position: refs/heads/master@{#391901}

[modify] https://crrev.com/f414e44aac0f359a551409d4db5cd904742ec145/testing/buildbot/chromium.win.json

Comment 12 by jam@chromium.org, May 6 2016

To follow up, here are the graphs after the revert. It looks like the cycle time has gone down to before, so it seems that this change was what had caused the regression.
win after revert.PNG
170 KB View Download
winx64 after revert.PNG
186 KB View Download
@jam - the revert only affected the x64 bot; do you think the x86 bot's decrease in cycle times was due to fixing the webkit_tests retry issue, or something else?

Comment 14 by jam@chromium.org, May 6 2016

Ah that's a good question, I missed that it was for x64 only.

I don't know why 32 bit went down as well. perhaps it is because of webkit_tests retry, but I didn't look in details.
Project Member

Comment 15 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77405408a41233916670d7c4cbf0e18ad451a802

commit 77405408a41233916670d7c4cbf0e18ad451a802
Author: dpranke <dpranke@chromium.org>
Date: Fri May 13 17:15:06 2016

Flip remaining CQ Win builders to GN.

This CL flips the remaining CQ builders on tryserver.chromium.win to GN:

  - win_chromium_compile_dbg_ng
  - win_chromium_rel_ng

and some matching bots on chromium.win:

  - Win Builder
  - Win Builder (dbg)

and tryserver.chromium.win:

  - win_chromium_compile_rel_ng
  - win_chromium_dbg_ng

and the affected GPU bots that are also tested by win_chromium_rel_ng:

  - GPU Win Builder
  - GPU Win Builder (dbg)

R=brucedawson@chromium.org, brettw@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/1908733002
Cr-Commit-Position: refs/heads/master@{#393560}

[modify] https://crrev.com/77405408a41233916670d7c4cbf0e18ad451a802/tools/mb/mb_config.pyl

Project Member

Comment 16 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe79b4b7bd484f806217fd8668de721306ff376a

commit fe79b4b7bd484f806217fd8668de721306ff376a
Author: dpranke <dpranke@chromium.org>
Date: Wed May 18 00:52:16 2016

Revert of Flip remaining CQ Win builders to GN. (patchset #11 id:200001 of https://codereview.chromium.org/1908733002/ )

Reason for revert:
reverting this until after the branch to maintain GYP coverage ...

Original issue's description:
> Flip remaining CQ Win builders to GN.
>
> This CL flips the remaining CQ builders on tryserver.chromium.win to GN:
>
>   - win_chromium_compile_dbg_ng
>   - win_chromium_rel_ng
>
> and some matching bots on chromium.win:
>
>   - Win Builder
>   - Win Builder (dbg)
>
> and tryserver.chromium.win:
>
>   - win_chromium_compile_rel_ng
>   - win_chromium_dbg_ng
>
> and the affected GPU bots that are also tested by win_chromium_rel_ng:
>
>   - GPU Win Builder
>   - GPU Win Builder (dbg)
>
> R=brucedawson@chromium.org, brettw@chromium.org
> BUG= 605318 
>
> Committed: https://crrev.com/77405408a41233916670d7c4cbf0e18ad451a802
> Cr-Commit-Position: refs/heads/master@{#393560}

TBR=brettw@chromium.org,brucedawson@chromium.org,kbr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605318 

Review-Url: https://codereview.chromium.org/1981313003
Cr-Commit-Position: refs/heads/master@{#394300}

[modify] https://crrev.com/fe79b4b7bd484f806217fd8668de721306ff376a/tools/mb/mb_config.pyl

Project Member

Comment 17 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35605899a98b8e5850573ac10d6f664e2f116aef

commit 35605899a98b8e5850573ac10d6f664e2f116aef
Author: dpranke <dpranke@chromium.org>
Date: Tue May 24 00:21:56 2016

Re-land "Flip remaining CQ Win builders to GN."

Now that we've cleared the M52 branch, we can flip the x86 Win
CQ bots to GN and push hard to get the rest flipped as well :).

R=brucedawson@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2006733003
Cr-Commit-Position: refs/heads/master@{#395480}

[modify] https://crrev.com/35605899a98b8e5850573ac10d6f664e2f116aef/tools/mb/mb_config.pyl

Project Member

Comment 18 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4ad43e579b880f6c432b5a530b45f8d39ebfe99

commit f4ad43e579b880f6c432b5a530b45f8d39ebfe99
Author: dpranke <dpranke@chromium.org>
Date: Tue May 24 03:07:07 2016

Flip webkit bots to GN (again)

This re-lands #392218, now that we've cleared the M52 branch.

TBR=brettw@chromium.org
BUG= 605732 ,  605318 

Review-Url: https://codereview.chromium.org/2000283003
Cr-Commit-Position: refs/heads/master@{#395525}

[modify] https://crrev.com/f4ad43e579b880f6c432b5a530b45f8d39ebfe99/tools/mb/mb_config.pyl

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caa330a53f0d7972ae3fa276f0ade9f0e33e3037

commit caa330a53f0d7972ae3fa276f0ade9f0e33e3037
Author: dpranke <dpranke@chromium.org>
Date: Mon Jun 06 06:12:12 2016

Move remaining tests on win GN bots to main bots and update CQ

There were a few test steps running only on the Win8 Aura
bot, which was the original GN bot. This CL makes sure
they run on the main Windows x86 and x64 bots now that
they are also using GN.

This CL also takes win8_chromium_ng out of the CQ since
it's now redundant.

R=brucedawson@chromium.org, msw@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2032613004
Cr-Commit-Position: refs/heads/master@{#397982}

[modify] https://crrev.com/caa330a53f0d7972ae3fa276f0ade9f0e33e3037/infra/config/cq.cfg
[modify] https://crrev.com/caa330a53f0d7972ae3fa276f0ade9f0e33e3037/testing/buildbot/chromium.win.json

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52cf5270a55fcf700a2602753914600de2f8a28d

commit 52cf5270a55fcf700a2602753914600de2f8a28d
Author: dpranke <dpranke@chromium.org>
Date: Mon Jun 06 22:32:59 2016

Flip Win bots on tryserver.chromium.perf to GN.

TBR=dtu@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2045693003
Cr-Commit-Position: refs/heads/master@{#398146}

[modify] https://crrev.com/52cf5270a55fcf700a2602753914600de2f8a28d/tools/mb/mb_config.pyl

Blockedon: 617837
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d5b7069c8376c83fb8b3d35b0df49979592bb2a

commit 1d5b7069c8376c83fb8b3d35b0df49979592bb2a
Author: dpranke <dpranke@chromium.org>
Date: Mon Jun 20 21:09:04 2016

Flip Google Chrome Win builder to GN.

And add the missing //:chrome_official_builder_no_unittests target
that caused the prior flip to be reverted :).

R=brettw@chromium.org
BUG= 605318 ,  621575 

Review-Url: https://codereview.chromium.org/2082683003
Cr-Commit-Position: refs/heads/master@{#400780}

[modify] https://crrev.com/1d5b7069c8376c83fb8b3d35b0df49979592bb2a/BUILD.gn
[modify] https://crrev.com/1d5b7069c8376c83fb8b3d35b0df49979592bb2a/tools/mb/mb_config.pyl

Project Member

Comment 23 by bugdroid1@chromium.org, Jun 20 2016

Blocking: 621677
Labels: -Pri-1 M-53 Pri-2
Only some (well, most) of the builders need to be flipped over before we ship GN. All of them need to be flipped over before we drop GYP support, obviously.
Project Member

Comment 26 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44265dd04f839147986041fa9c32e9b3c758aebf

commit 44265dd04f839147986041fa9c32e9b3c758aebf
Author: dpranke <dpranke@chromium.org>
Date: Mon Jun 20 23:17:39 2016

Flip official Win builders to GN (on trunk).

This also flips the continuous official builders, but because those
are pulling MB configs from versioned code, this'll only actually
affect the trunk builder for now. When we branch, the branch builders
will also start to pick up these changes.

R=brettw@chromium.org, brucedawson@chromium.org, scottmg@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2082823002
Cr-Commit-Position: refs/heads/master@{#400827}

[modify] https://crrev.com/44265dd04f839147986041fa9c32e9b3c758aebf/tools/mb/mb_config.pyl

Blockedon: 618038
Blockedon: -617837
Blockedon: 498033
Project Member

Comment 30 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/217fb93cfc4e41ca74f55373834d9b9630842a41

commit 217fb93cfc4e41ca74f55373834d9b9630842a41
Author: dpranke <dpranke@chromium.org>
Date: Tue Jun 21 03:55:17 2016

Revert of Flip official Win builders to GN (on trunk). (patchset #1 id:1 of https://codereview.chromium.org/2082823002/ )

Reason for revert:
Didn't work - see crbug.com/621776.

Original issue's description:
> Flip official Win builders to GN (on trunk).
>
> This also flips the continuous official builders, but because those
> are pulling MB configs from versioned code, this'll only actually
> affect the trunk builder for now. When we branch, the branch builders
> will also start to pick up these changes.
>
> R=brettw@chromium.org, brucedawson@chromium.org, scottmg@chromium.org
> BUG= 605318 
>
> Committed: https://crrev.com/44265dd04f839147986041fa9c32e9b3c758aebf
> Cr-Commit-Position: refs/heads/master@{#400827}

TBR=brettw@chromium.org,brucedawson@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605318 

Review-Url: https://codereview.chromium.org/2077353003
Cr-Commit-Position: refs/heads/master@{#400887}

[modify] https://crrev.com/217fb93cfc4e41ca74f55373834d9b9630842a41/tools/mb/mb_config.pyl

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 21 2016

Labels: merge-merged-2774
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34ddc60db4147750937a5ea847e9958f1488a356

commit 34ddc60db4147750937a5ea847e9958f1488a356
Author: Dirk Pranke <dpranke@chromium.org>
Date: Tue Jun 21 04:22:25 2016

Revert of Flip official Win builders to GN (on trunk). (patchset #1 id:1 of https://codereview.chromium.org/2082823002/ )

Reason for revert:
Didn't work - see crbug.com/621776.

Original issue's description:
> Flip official Win builders to GN (on trunk).
>
> This also flips the continuous official builders, but because those
> are pulling MB configs from versioned code, this'll only actually
> affect the trunk builder for now. When we branch, the branch builders
> will also start to pick up these changes.
>
> R=brettw@chromium.org, brucedawson@chromium.org, scottmg@chromium.org
> BUG= 605318 
>
> Committed: https://crrev.com/44265dd04f839147986041fa9c32e9b3c758aebf
> Cr-Commit-Position: refs/heads/master@{#400827}

TBR=brettw@chromium.org,brucedawson@chromium.org,scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605318 

Review-Url: https://codereview.chromium.org/2077353003
Cr-Commit-Position: refs/heads/master@{#400887}
(cherry picked from commit 217fb93cfc4e41ca74f55373834d9b9630842a41)

Review URL: https://codereview.chromium.org/2085863002 .

Cr-Commit-Position: refs/branch-heads/2774@{#3}
Cr-Branched-From: b0f304cf34c7a20dcab2f8de8f4941521c6a0f9b-refs/heads/master@{#400850}

[modify] https://crrev.com/34ddc60db4147750937a5ea847e9958f1488a356/tools/mb/mb_config.pyl

Labels: -Pri-2 Pri-1
Marking as P1 until all of the builders we need to ship are flipped over.
Project Member

Comment 33 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a02cdef6f8ae650ea976a3e40dd5008e23df913

commit 6a02cdef6f8ae650ea976a3e40dd5008e23df913
Author: jmadill <jmadill@chromium.org>
Date: Wed Jun 22 02:34:00 2016

gles2_conform: Suppress warnings on Win/GN.

BUG= 605318 
R=piman@chromium.org,dpranke@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2085043003
Cr-Commit-Position: refs/heads/master@{#401175}

[modify] https://crrev.com/6a02cdef6f8ae650ea976a3e40dd5008e23df913/gpu/gles2_conform_support/BUILD.gn

Project Member

Comment 34 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/400201d7327b4ed73f5d31d8968be30c1daa70a1

commit 400201d7327b4ed73f5d31d8968be30c1daa70a1
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 22 03:07:30 2016

Flip Win GPU, Angle builders to GN.

Now that most of the Win builders are using GN instead of GYP
these should be, too.

R=kbr@chromium.org, jmadill@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2077233002
Cr-Commit-Position: refs/heads/master@{#401185}

[modify] https://crrev.com/400201d7327b4ed73f5d31d8968be30c1daa70a1/tools/mb/mb_config.pyl

Project Member

Comment 35 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a256069d5d0c34e4da9d21e91acad17c5c907e20

commit a256069d5d0c34e4da9d21e91acad17c5c907e20
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 22 04:06:13 2016

Flip FYI Win Goma builders to GN.

Now that nearly all of the Win builders are on GN, the
Goma builders should be, too.

TBR=ukai@chromium.org, thakis@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2074333002
Cr-Commit-Position: refs/heads/master@{#401202}

[modify] https://crrev.com/a256069d5d0c34e4da9d21e91acad17c5c907e20/tools/mb/mb_config.pyl

Project Member

Comment 36 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb929f6769c9a834e5941a2412ec2883b3b162fe

commit cb929f6769c9a834e5941a2412ec2883b3b162fe
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 22 17:25:13 2016

Flip remaining chromium.webrtc* builders to GN.

There are very few GYP builders remaining on the chromium waterfalls;
all of the main builders have been flipped to GN, so WebRTC should be
testing that config now.

R=kjellander@chromium.org
BUG= 605318 ,  618468 

Review-Url: https://codereview.chromium.org/2085873005
Cr-Commit-Position: refs/heads/master@{#401327}

[modify] https://crrev.com/cb929f6769c9a834e5941a2412ec2883b3b162fe/tools/mb/mb_config.pyl

Project Member

Comment 37 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64cecdda60c559f9aa5dcdd7cb40e513bc0eab29

commit 64cecdda60c559f9aa5dcdd7cb40e513bc0eab29
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 22 17:27:14 2016

Remove client.skia section from mb_config.pyl.

The builders were removed so this section was useless.

TBR=borenet@google.com
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2089953002
Cr-Commit-Position: refs/heads/master@{#401329}

[modify] https://crrev.com/64cecdda60c559f9aa5dcdd7cb40e513bc0eab29/tools/mb/mb_config.pyl

Project Member

Comment 38 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33e626ee1d4e57f64aea682f8479e65ecf59e7ac

commit 33e626ee1d4e57f64aea682f8479e65ecf59e7ac
Author: dpranke <dpranke@chromium.org>
Date: Thu Jun 23 04:41:32 2016

Add 'chrome_official_builder' target to //BUILD.gn.

This is needed on the official 32-bit win desktop builder.

R=brettw@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2082183002
Cr-Commit-Position: refs/heads/master@{#401540}

[modify] https://crrev.com/33e626ee1d4e57f64aea682f8479e65ecf59e7ac/BUILD.gn

Project Member

Comment 39 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e61fe77ee3b64299e38bb13ef093e26f148e45

commit b0e61fe77ee3b64299e38bb13ef093e26f148e45
Author: phoglund <phoglund@chromium.org>
Date: Thu Jun 23 10:00:09 2016

Revert of Flip remaining chromium.webrtc* builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2085873005/ )

Reason for revert:
Reason for revert:
Speculative revert: causes H264 regression (?): https://bugs.chromium.org/p/chromium/issues/detail?id=622632

BUG=622632

Original issue's description:
> Flip remaining chromium.webrtc* builders to GN.
>
> There are very few GYP builders remaining on the chromium waterfalls;
> all of the main builders have been flipped to GN, so WebRTC should be
> testing that config now.
>
> R=kjellander@chromium.org
> BUG= 605318 ,  618468 
>
> Committed: https://crrev.com/cb929f6769c9a834e5941a2412ec2883b3b162fe
> Cr-Commit-Position: refs/heads/master@{#401327}

TBR=kjellander@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605318 ,  618468 

Review-Url: https://codereview.chromium.org/2095473004
Cr-Commit-Position: refs/heads/master@{#401574}

[modify] https://crrev.com/b0e61fe77ee3b64299e38bb13ef093e26f148e45/tools/mb/mb_config.pyl

Project Member

Comment 40 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6d02268650a10af563042109968d9f58a43170d

commit f6d02268650a10af563042109968d9f58a43170d
Author: phoglund <phoglund@chromium.org>
Date: Thu Jun 23 13:04:54 2016

Reland of Flip remaining chromium.webrtc* builders to GN. (patchset #1 id:1 of https://codereview.chromium.org/2088343003/ )

Reason for revert:
This revert broke the WebRTC win build (?)

Original issue's description:
> Revert of Flip remaining chromium.webrtc* builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2085873005/ )
>
> Reason for revert:
> Speculative revert: causes H264 regression (?): https://bugs.chromium.org/p/chromium/issues/detail?id=622632
>
> BUG=622632
>
> Original issue's description:
> > Flip remaining chromium.webrtc* builders to GN.
> >
> > There are very few GYP builders remaining on the chromium waterfalls;
> > all of the main builders have been flipped to GN, so WebRTC should be
> > testing that config now.
> >
> > R=kjellander@chromium.org
> > BUG= 605318 ,  618468 
> >
> > Committed: https://crrev.com/cb929f6769c9a834e5941a2412ec2883b3b162fe
> > Cr-Commit-Position: refs/heads/master@{#401327}
>
> TBR=kjellander@chromium.org,dpranke@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 605318 ,  618468 

TBR=kjellander@chromium.org,dpranke@chromium.org,phoglund@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=622632

Review-Url: https://codereview.chromium.org/2081393005
Cr-Commit-Position: refs/heads/master@{#401593}

[modify] https://crrev.com/f6d02268650a10af563042109968d9f58a43170d/tools/mb/mb_config.pyl

Blockedon: 622715
Project Member

Comment 42 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf63a9a5e547087e23a0773e5875a1e2fa4331b1

commit cf63a9a5e547087e23a0773e5875a1e2fa4331b1
Author: dpranke <dpranke@chromium.org>
Date: Fri Jun 24 18:12:27 2016

Flip mac and win "gn" builders back to GYP.

Now that the main builders are on GN, we can flip the dedicated
"gn" builders back to GYP and rename them to "gyp" to avoid
confusion and keep some GYP coverage on the main waterfalls
(they will build "all" but not run tests or be in the CQ for now).

R=rsesek@chromium.org
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2092173002
Cr-Commit-Position: refs/heads/master@{#401910}

[modify] https://crrev.com/cf63a9a5e547087e23a0773e5875a1e2fa4331b1/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/cf63a9a5e547087e23a0773e5875a1e2fa4331b1/testing/buildbot/chromium.win.json
[modify] https://crrev.com/cf63a9a5e547087e23a0773e5875a1e2fa4331b1/tools/mb/mb_config.pyl

Project Member

Comment 43 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/11582d2d7d07ac1409907a39ed823b68a9916271

commit 11582d2d7d07ac1409907a39ed823b68a9916271
Author: dpranke <dpranke@chromium.org>
Date: Fri Jun 24 23:09:40 2016

Rename Mac/Win GN builders to GYP builders.

Now that the main Mac and Win builders are on GN, the builders
with "GN" in the names are redundant and confusing. This CL renames
them and the corresponding trybots to "GYP" to provide some GYP
coverage until we drop the GYP build completely.

There are matching trybots for the builders, but they are not
part of the commit queue.

- chromium.mac
  - "Mac GN" -> "Mac GYP"
  - "Mac GN (dbg)" -> "Mac GYP (dbg)"
- chromium.win
  - "Win8 Aura" -> "Win8 GYP" (Aura has been default for a long time)
  - "Win8 GN (dbg) -> "Win8 GYP (dbg)"
- tryserver.chromium.mac
  - mac_chromium_rel_ng -> mac_chromium_gyp_rel
  - mac_chromium_dbg_ng -> mac_chromium_gyp_dbg
- tryserver.chromium.win
  - win8_chromium_ng -> win8_chromium_gyp_rel
  - win8_chromium_gn_dbg -> win8_chromium_gyp_dbg

R=rsesek@chromium.org
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2098943002

[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/masters/master.chromium.mac/master_mac_cfg.py
[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/masters/master.chromium.mac/slaves.cfg
[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/masters/master.chromium.win/master_win_cfg.py
[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/masters/master.chromium.win/slaves.cfg
[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/masters/master.tryserver.chromium.mac/master.cfg
[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/masters/master.tryserver.chromium.mac/slaves.cfg
[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/masters/master.tryserver.chromium.win/master.cfg
[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/masters/master.tryserver.chromium.win/slaves.cfg
[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/scripts/slave/recipe_modules/chromium_tests/chromium_mac.py
[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/scripts/slave/recipe_modules/chromium_tests/chromium_win.py
[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/scripts/slave/recipe_modules/chromium_tests/trybots.py
[add] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_GYP.json
[add] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_GYP__dbg_.json
[add] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP.json
[add] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json
[add] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_gyp_dbg.json
[add] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_gyp_rel.json
[add] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_gyp_dbg.json
[add] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_gyp_rel.json
[modify] https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271/tests/masters_recipes_test.py

Project Member

Comment 44 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bc901b5d3297a636c684b4311161f526bdeece98

commit bc901b5d3297a636c684b4311161f526bdeece98
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jun 24 23:42:08 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271 Rename Mac/Win GN builders to GYP builders. (dpranke@chromium.org)

R=rsesek@chromium.org,dpranke@chromium.org
BUG= 605318 , 618468 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2097983003

[modify] https://crrev.com/bc901b5d3297a636c684b4311161f526bdeece98/infra/config/recipes.cfg

Project Member

Comment 45 by bugdroid1@chromium.org, Jun 25 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/396b1c80fd917c93985b0b709508ea49447240d9

commit 396b1c80fd917c93985b0b709508ea49447240d9
Author: dpranke <dpranke@google.com>
Date: Sat Jun 25 00:00:03 2016

Project Member

Comment 46 by bugdroid1@chromium.org, Jun 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/6b54440a5aa93598a311d360af6010a7747de4a7

commit 6b54440a5aa93598a311d360af6010a7747de4a7
Author: recipe-roller <recipe-roller@chromium.org>
Date: Sat Jun 25 00:07:08 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271 Rename Mac/Win GN builders to GYP builders. (dpranke@chromium.org)
  https://crrev.com/17e0575a176b22b3c3d52ba44e405fd04c48da9c Mark the Win - WPTServe FYI bot as 32-bit, not 64-bit. (dpranke@chromium.org)

R=rsesek@chromium.org,dpranke@chromium.org,dcampb@google.com,qyearsley@chromium.org
BUG=620871, 605318 , 618468 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2095113003

[modify] https://crrev.com/6b54440a5aa93598a311d360af6010a7747de4a7/infra/config/recipes.cfg

Summary: Flip all Win bots over to GN (was: flip all windows bots over to GN)
Summary: Flip all remaining Win bots over to GN (was: Flip all Win bots over to GN)
Project Member

Comment 49 by bugdroid1@chromium.org, Jun 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b067bb0848308067e35c24c7a39273e2861fb53

commit 7b067bb0848308067e35c24c7a39273e2861fb53
Author: dpranke <dpranke@chromium.org>
Date: Sun Jun 26 19:27:01 2016

Flip mac, win trunk builders on official.desktop.continuous to GN.

TBR=rsesek@chromium.org, brettw@chromium.org
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2099943002
Cr-Commit-Position: refs/heads/master@{#402084}

[modify] https://crrev.com/7b067bb0848308067e35c24c7a39273e2861fb53/tools/mb/mb_config.pyl

Project Member

Comment 50 by bugdroid1@chromium.org, Jun 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea1a899ae5ff3f17eca472de434541715c1bc44e

commit ea1a899ae5ff3f17eca472de434541715c1bc44e
Author: dpranke <dpranke@chromium.org>
Date: Sun Jun 26 20:23:56 2016

Revert of Flip mac, win trunk builders on official.desktop.continuous to GN. (patchset #1 id:1 of https://codereview.chromium.org/2099943002/ )

Reason for revert:
Reverting now that the official.desktop.continuous builders have picked up at least one build.

Original issue's description:
> Flip mac, win trunk builders on official.desktop.continuous to GN.
>
> TBR=rsesek@chromium.org, brettw@chromium.org
> BUG= 618468 ,  605318 
>
> Committed: https://crrev.com/7b067bb0848308067e35c24c7a39273e2861fb53
> Cr-Commit-Position: refs/heads/master@{#402084}

TBR=brettw@chromium.org,rsesek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2098253002
Cr-Commit-Position: refs/heads/master@{#402087}

[modify] https://crrev.com/ea1a899ae5ff3f17eca472de434541715c1bc44e/tools/mb/mb_config.pyl

Blocking: -621677
Labels: -M-53
We don't need to flip *all* bots before M-53, so clearing this.

Comment 52 by h...@chromium.org, Jun 28 2016

Blockedon: 624132
Project Member

Comment 53 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/f7b7c2a06a5b09e56df379be5de85a926dc1e01a

commit f7b7c2a06a5b09e56df379be5de85a926dc1e01a
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 29 01:42:32 2016

Remove traces of removed Mac/Win GN builders.

R=martiniss@chromium.org, kjellander@chromium.org
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2097223002

[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipe_modules/chromium_tests/chromium_mac.py
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipe_modules/chromium_tests/chromium_win.py
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipe_modules/chromium_tests/trybots.py
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_GN.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_GN__dbg_.json
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_GN.json
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_GN__dbg_.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_Aura.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GN__dbg_.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_gn_dbg.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_gn_rel.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_ng.json
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/tests/masters_recipes_test.py

Project Member

Comment 54 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1286dbd329b0669e082ffcebe3cb2b7fa47e438d

commit 1286dbd329b0669e082ffcebe3cb2b7fa47e438d
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 29 01:43:28 2016

Flip full, perf Mac and Win builders back to GYP.

This will give us a bit more test coverage prior to
the branch.

R=brettw@chromium.org
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2105043003
Cr-Commit-Position: refs/heads/master@{#402631}

[modify] https://crrev.com/1286dbd329b0669e082ffcebe3cb2b7fa47e438d/tools/mb/mb_config.pyl

Project Member

Comment 55 by bugdroid1@chromium.org, Jun 29 2016

Project Member

Comment 56 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/d9a13dd0b70d15ef99f5f501cdee0b8cb2e60b36

commit d9a13dd0b70d15ef99f5f501cdee0b8cb2e60b36
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jun 29 01:58:55 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a Remove traces of removed Mac/Win GN builders. (dpranke@chromium.org)

R=dpranke@chromium.org,martiniss@chromium.org,kjellander@chromium.org
BUG= 605318 , 618468 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2106953003

[modify] https://crrev.com/d9a13dd0b70d15ef99f5f501cdee0b8cb2e60b36/infra/config/recipes.cfg

Project Member

Comment 57 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/d9a13dd0b70d15ef99f5f501cdee0b8cb2e60b36

commit d9a13dd0b70d15ef99f5f501cdee0b8cb2e60b36
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jun 29 01:58:55 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a Remove traces of removed Mac/Win GN builders. (dpranke@chromium.org)

R=dpranke@chromium.org,martiniss@chromium.org,kjellander@chromium.org
BUG= 605318 , 618468 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2106953003

[modify] https://crrev.com/d9a13dd0b70d15ef99f5f501cdee0b8cb2e60b36/infra/config/recipes.cfg

Project Member

Comment 58 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6311f0fdc42799da33b9e28e6b784a1eda788aa0

commit 6311f0fdc42799da33b9e28e6b784a1eda788aa0
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 29 23:41:46 2016

Add Mac, Win builders back to the CQ for extra coverage.

Given that we're not going to ship GN-built Mac and Win
releases in M53, let's add some GYP coverage back to the
CQ; this'll make sure the targets the official builders
really need build, although we won't run any tests. We
should have capacity, but start with a 50% experiment for
now.

R=phajdan.jr@chromium.org, jam@chromium.org
BUG= 618468 ,  605318 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:mac_chromium_gyp_rel;tryserver.chromium.win:win8_chromium_gyp_rel

Review-Url: https://codereview.chromium.org/2111463002
Cr-Commit-Position: refs/heads/master@{#402999}

[modify] https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0/BUILD.gn
[modify] https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0/build/all.gyp
[modify] https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0/infra/config/cq.cfg
[modify] https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0/testing/buildbot/chromium.win.json

Blocking: -354261
As suggested by laforge@ and a conversation w/ the monorail folks, I'm going to try tracking GN-Migration related issues by *just* using the Proj-GN-Migration label, and not using blocking/rollup bugs, so that we can use blocking for just tasks that truly need to be completed before other tasks can make progress.
Labels: -Pri-1 Pri-2
Project Member

Comment 61 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39a588cf27ffda8ac9f504c87d7f897342cf180e

commit 39a588cf27ffda8ac9f504c87d7f897342cf180e
Author: dpranke <dpranke@chromium.org>
Date: Fri Jul 01 01:52:21 2016

Bump mac_chromium_gyp_rel to 100% in CQ, fix typo for win8_chromium_gyp_rel.

TBR=jam@chromium.org
BUG= 605318 ,  618468 

Review-Url: https://codereview.chromium.org/2113893003
Cr-Commit-Position: refs/heads/master@{#403386}

[modify] https://crrev.com/39a588cf27ffda8ac9f504c87d7f897342cf180e/infra/config/cq.cfg

Project Member

Comment 63 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/f99628b14ae428b859febdda55df395dd0aa4201

commit f99628b14ae428b859febdda55df395dd0aa4201
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 19 19:29:58 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b733a7710154b30292bbb716328737965510a6e7 Switch 'Win x64' builder on chromium waterfall to use MB. (dpranke@chromium.org)

R=dpranke@chromium.org,sebmarchand@chromium.org
BUG= 605318 , 569975 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2162903003

[modify] https://crrev.com/f99628b14ae428b859febdda55df395dd0aa4201/infra/config/recipes.cfg

Project Member

Comment 64 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca5dcbc22eabd941b98fe3b1500905ba50836cba

commit ca5dcbc22eabd941b98fe3b1500905ba50836cba
Author: dpranke <dpranke@chromium.org>
Date: Tue Jul 26 17:08:06 2016

Flip remaining non-ASAN Win Clang builders to GN.

This flips the following builders to GN:

- chromium.fyi
  - CrWinClang(dbg)
  - CrWinClang64
  - CrWinClang64(dll)
  - ClangToTWin
  - ClangToTWin(dll)
  - ClangToTWin64(dbg)
  - CrWinClangLLD
  - CrWinClangLLD64
  - CrWinClangLLD64dbg
- tryserver.chromium.win
  - win_clang_dbg
  - win_clang_rel
  - win_clang_x64_rel

R=hans@chromium.org
BUG= 605318 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_clang_dbg,win_clang_rel,win_clang_x64_dbg,win_clang_x64_rel

Review-Url: https://codereview.chromium.org/2183593002
Cr-Commit-Position: refs/heads/master@{#407834}

[modify] https://crrev.com/ca5dcbc22eabd941b98fe3b1500905ba50836cba/tools/mb/mb_config.pyl

Project Member

Comment 65 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91224d8c9f54a8a6d9ed8fcffb43fde276ce4afa

commit 91224d8c9f54a8a6d9ed8fcffb43fde276ce4afa
Author: dpranke <dpranke@chromium.org>
Date: Tue Jul 26 22:36:28 2016

Flip DrMemory memory.fyi builders to GN.

R=bruening@chromium.org, brettw@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2181843002
Cr-Commit-Position: refs/heads/master@{#407940}

[modify] https://crrev.com/91224d8c9f54a8a6d9ed8fcffb43fde276ce4afa/tools/mb/mb_config.pyl

Project Member

Comment 66 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/032d2e7f0eb77552c1eed14f0dd22cb2accfcd94

commit 032d2e7f0eb77552c1eed14f0dd22cb2accfcd94
Author: dpranke <dpranke@chromium.org>
Date: Wed Jul 27 01:24:57 2016

Flip misc. remaining Win FYI builders to GN.

This flips:

- chromium.fyi
  - MD Top Chrome Win Material
  - Site Isolation Win
- tryserver.chromium.win
  - win_nacl_sdk
  - win_nacl_sdk_build

R=brettw@chromium.org, creis@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2180843003
Cr-Commit-Position: refs/heads/master@{#408007}

[modify] https://crrev.com/032d2e7f0eb77552c1eed14f0dd22cb2accfcd94/tools/mb/mb_config.pyl

Project Member

Comment 67 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df2307f88ab1411ce0dddfc92020d19345be47f5

commit df2307f88ab1411ce0dddfc92020d19345be47f5
Author: dpranke <dpranke@chromium.org>
Date: Wed Jul 27 17:23:55 2016

Revert of Flip DrMemory memory.fyi builders to GN. (patchset #1 id:1 of https://codereview.chromium.org/2181843002/ )

Reason for revert:
The builders appear to be all sorts of broken in GN; I don't even know how ninja is running at all, and the errors it is producing don't make any sense.

Original issue's description:
> Flip DrMemory memory.fyi builders to GN.
>
> R=bruening@chromium.org, brettw@chromium.org
> BUG= 605318 
>
> Committed: https://crrev.com/91224d8c9f54a8a6d9ed8fcffb43fde276ce4afa
> Cr-Commit-Position: refs/heads/master@{#407940}

TBR=bruening@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605318 

Review-Url: https://codereview.chromium.org/2187043002
Cr-Commit-Position: refs/heads/master@{#408166}

[modify] https://crrev.com/df2307f88ab1411ce0dddfc92020d19345be47f5/tools/mb/mb_config.pyl

Project Member

Comment 69 by bugdroid1@chromium.org, Jul 27 2016

Project Member

Comment 70 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/cac06763fb22744767165858d71d1ec27cfdd64a

commit cac06763fb22744767165858d71d1ec27cfdd64a
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 27 17:56:00 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/069c76b1aac385d3bebe51c274523a62457c7460 Add MB config to SyzyASAN builders. (dpranke@chromium.org)

R=dpranke@chromium.org,sebmarchand@chromium.org
BUG= 605318 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2182493007

[modify] https://crrev.com/cac06763fb22744767165858d71d1ec27cfdd64a/infra/config/recipes.cfg

Project Member

Comment 71 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1adad67e3f88cbe8d25b22c972cddb76cfa7d7f8

commit 1adad67e3f88cbe8d25b22c972cddb76cfa7d7f8
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 28 02:40:31 2016

Try again to flip Win PGO builders to GN.

This affects:

- chromium.fyi
  - Chromium Win PGO Builder
  - Chromium Win x64 PGO Builder
- official.desktop
  - win-pgo
  - win64-pgo
- tryserver.chromium.win
  - win_pgo

TBR=sebmarchand@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2189853002
Cr-Commit-Position: refs/heads/master@{#408317}

[modify] https://crrev.com/1adad67e3f88cbe8d25b22c972cddb76cfa7d7f8/tools/mb/mb_config.pyl

Project Member

Comment 72 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/6deb4e7015748d5c9d43b7433b50acc51e07f364

commit 6deb4e7015748d5c9d43b7433b50acc51e07f364
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 28 06:01:06 2016

Reland "Change PGO recipe to use MB now that it supports multiple phases."

Now that the PGO changes have been merged back to the release branches,
this should be safe to land again.

TBR=sebmarchand@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2190883002

[modify] https://crrev.com/6deb4e7015748d5c9d43b7433b50acc51e07f364/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/6deb4e7015748d5c9d43b7433b50acc51e07f364/scripts/slave/recipe_modules/pgo/api.py
[modify] https://crrev.com/6deb4e7015748d5c9d43b7433b50acc51e07f364/scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder.json
[modify] https://crrev.com/6deb4e7015748d5c9d43b7433b50acc51e07f364/scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder_benchmark_failure.json
[modify] https://crrev.com/6deb4e7015748d5c9d43b7433b50acc51e07f364/scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_PGO_Builder.json
[modify] https://crrev.com/6deb4e7015748d5c9d43b7433b50acc51e07f364/scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_x64_PGO_Builder.json
[modify] https://crrev.com/6deb4e7015748d5c9d43b7433b50acc51e07f364/scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json

Project Member

Comment 73 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/2106781c6df5c99011ce32517c43cf2612d18fbb

commit 2106781c6df5c99011ce32517c43cf2612d18fbb
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jul 28 09:26:04 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/394d6f00e87c96da80bcf69cdf451a2af0bf349d Exclude nested submodules properly.  This never worked. (dsansome@chromium.org)
  https://crrev.com/6deb4e7015748d5c9d43b7433b50acc51e07f364 Reland "Change PGO recipe to use MB now that it supports multiple phases." (dpranke@chromium.org)

R=dpranke@chromium.org,sebmarchand@chromium.org,dsansome@chromium.org
BUG= 605318 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2184353002

[modify] https://crrev.com/2106781c6df5c99011ce32517c43cf2612d18fbb/infra/config/recipes.cfg

Project Member

Comment 74 by bugdroid1@chromium.org, Jul 28 2016

Project Member

Comment 75 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f83cc2371fb48bd29fa4f231842909d111756e2f

commit f83cc2371fb48bd29fa4f231842909d111756e2f
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 28 17:24:32 2016

Flip SyzyASAN builders to GN.

This affects the following builders:

- chromium.lkgr
  - Chromium Win SyzyASAN
- official.desktop
  - win-asan
- tryserver.chromium.win
  - win_chromium_syzyasan_rel

R=sebmarchand@chromium.org
BUG= 605318 ,  623659 

Review-Url: https://codereview.chromium.org/2178393003
Cr-Commit-Position: refs/heads/master@{#408412}

[modify] https://crrev.com/f83cc2371fb48bd29fa4f231842909d111756e2f/tools/mb/mb_config.pyl

Project Member

Comment 76 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bee3ba76d68482e88e08418eca6386aa8f2f1924

commit bee3ba76d68482e88e08418eca6386aa8f2f1924
Author: dpranke <dpranke@chromium.org>
Date: Fri Jul 29 01:26:15 2016

Fix SyzyASAN builders to be release GN builds, not debug.

Also, turn off goma and add no_pch on the trybot.

TBR=sebmarchand@chromium.org
BUG= 605318 

Review-Url: https://codereview.chromium.org/2196503002
Cr-Commit-Position: refs/heads/master@{#408547}

[modify] https://crrev.com/bee3ba76d68482e88e08418eca6386aa8f2f1924/tools/mb/mb_config.pyl

Project Member

Comment 77 by bugdroid1@chromium.org, Jul 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5a29eae56fe805e78220d5f071050dded5dee35

commit a5a29eae56fe805e78220d5f071050dded5dee35
Author: dpranke <dpranke@chromium.org>
Date: Sun Jul 31 20:54:32 2016

Flip remaining builders to GN.

(Apart from the dedicated GYP builders, of course).

This affects:

- chromium.fyi
  - Closure Compilation Linux
  - CrWinAsan
  - CrWinAsan(dll)
  - CrWinAsanCov
- chromium.lkgr
  - Win ASan Release Coverage
  - Win ASan Release Media
  - Win ASan Release
- chromium.mac
  - ios-simulator
- chromium.memory.full
  - Chromium Windows Builder (DrMemory x64)
  - Chromium Windows Builder (DrMemory)
- tryserver.chromium.linux
  - closure_compilation
- tryserver.chromium.mac
  - ios-simulator

Though the closure compilation builder doesn't really use GN or MB yet.

TBR=brettw@chromium.org
BUG= 605318 , 621708

Review-Url: https://codereview.chromium.org/2198693002
Cr-Commit-Position: refs/heads/master@{#408890}

[modify] https://crrev.com/a5a29eae56fe805e78220d5f071050dded5dee35/ios/build/bots/chromium.mac/ios-simulator.json
[modify] https://crrev.com/a5a29eae56fe805e78220d5f071050dded5dee35/tools/mb/mb_config.pyl

Status: Fixed (was: Started)

Sign in to add a comment