New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605314 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
cwp

Blocking:
issue 382705



Sign in to add a comment

Runtime Memory Leak Detector: Do not generate too many leak reports

Project Member Reported by sque@chromium.org, Apr 20 2016

Issue description

See this slideshow for a description of the problem and a proposed solution:
https://docs.google.com/presentation/d/15P1qTloLEZa20aNUl_-A6JqojTebwxTSrMdGk7Ny_Fo/edit#slide=id.p

We do not want to fill UMA with too much redundant data.
 

Comment 1 by sque@chromium.org, Apr 20 2016

Labels: M-52
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a9e129ec81d69c64a23d1bf7ab83e3f5ae3b3d4

commit 7a9e129ec81d69c64a23d1bf7ab83e3f5ae3b3d4
Author: sque <sque@chromium.org>
Date: Thu Apr 21 07:15:20 2016

Add cooldown to LeakDetectorImpl leak report generation

After a report is generated for a particular allocation size
and call site, there is a cooldown period before another
report can be generated for the same size and call site. This
prevents LeakDetectorImpl from generating too reports with
redundant data.

BUG= chromium:605314 
TEST=unit tests pass

Review URL: https://codereview.chromium.org/1892283004

Cr-Commit-Position: refs/heads/master@{#388707}

[modify] https://crrev.com/7a9e129ec81d69c64a23d1bf7ab83e3f5ae3b3d4/components/metrics/leak_detector/leak_detector_impl.cc
[modify] https://crrev.com/7a9e129ec81d69c64a23d1bf7ab83e3f5ae3b3d4/components/metrics/leak_detector/leak_detector_impl.h
[modify] https://crrev.com/7a9e129ec81d69c64a23d1bf7ab83e3f5ae3b3d4/components/metrics/leak_detector/leak_detector_impl_unittest.cc

Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by sque@chromium.org, Jun 6 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment