Allow Chrome to handle file downloads |
|||
Issue descriptionCurrently ExternalNavigationHandler runs for navigations to something that triggers a download. This means a third-party app may be chosen to do the download, which doesn't always work because the download may require a cookie authentication within Chrome. Instead, we should let Chrome handle all downloads and when the download is opened, the user may have the option of choosing to view the file in a different application.
,
Apr 25 2016
,
Apr 25 2016
[Removed OS-All since ExternalNavigationHandler only exists on Android]
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c69dcd0656f7f5dd570ca55c46393f79d3fc1368 commit c69dcd0656f7f5dd570ca55c46393f79d3fc1368 Author: mariakhomenko <mariakhomenko@chromium.org> Date: Wed Jun 01 21:35:57 2016 Disable external navigation for file downloads. Allow Chrome to handle downloads, otherwise the user may end up in a situation where an external application is handling the download, but doesn't have credentials to do so. Tying this to SystemDownloadManager feature -- we should only be doing this when Chrome is handling downloads. BUG= 605302 Review-Url: https://codereview.chromium.org/2026953002 Cr-Commit-Position: refs/heads/master@{#397255} [modify] https://crrev.com/c69dcd0656f7f5dd570ca55c46393f79d3fc1368/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/c69dcd0656f7f5dd570ca55c46393f79d3fc1368/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java [modify] https://crrev.com/c69dcd0656f7f5dd570ca55c46393f79d3fc1368/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java [modify] https://crrev.com/c69dcd0656f7f5dd570ca55c46393f79d3fc1368/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java [modify] https://crrev.com/c69dcd0656f7f5dd570ca55c46393f79d3fc1368/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java [modify] https://crrev.com/c69dcd0656f7f5dd570ca55c46393f79d3fc1368/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java [modify] https://crrev.com/c69dcd0656f7f5dd570ca55c46393f79d3fc1368/chrome/browser/android/chrome_feature_list.cc
,
Jun 1 2016
Min and I agreed to scale this back to just .pdf files because it's difficult to figure out exactly which files should be downloaded just from the file name. Since this problem mostly affects the .pdf files, we will start with that and perhaps add handling for other frequent types as time goes on.
,
Jun 13 2016
Issue 619564 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by sidv@chromium.org
, Apr 21 2016Components: UI>Browser>Downloads
Labels: OS-All