New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605301 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Could not find MediaDrmBridge inner classes on Android K

Project Member Reported by xhw...@chromium.org, Apr 20 2016

Issue description

04-19 16:25:13.686  6437  6576 E dalvikvm: Could not find class 'org.chromium.media.MediaDrmBridge$EventListener', referenced from method org.chromium.media.MediaDrmBridge.<init>
04-19 16:25:13.686  6437  6576 W dalvikvm: VFY: unable to resolve new-instance 4671 (Lorg/chromium/media/MediaDrmBridge$EventListener;) in Lorg/chromium/media/MediaDrmBridge;
04-19 16:25:13.686  6437  6576 D dalvikvm: VFY: replacing opcode 0x22 at 0x0034
04-19 16:25:13.686  6437  6576 E dalvikvm: Could not find class 'org.chromium.media.MediaDrmBridge$KeyStatus', referenced from method org.chromium.media.MediaDrmBridge.getDummyKeysInfo
04-19 16:25:13.686  6437  6576 W dalvikvm: VFY: unable to resolve new-instance 4673 (Lorg/chromium/media/MediaDrmBridge$KeyStatus;) in Lorg/chromium/media/MediaDrmBridge;
04-19 16:25:13.686  6437  6576 D dalvikvm: VFY: replacing opcode 0x22 at 0x0005

 

Comment 1 by xhw...@chromium.org, Apr 20 2016

This breaks EME on Android K devices.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c451bc3643a0f6c19bfb0dd8307d08e50304d7e

commit 1c451bc3643a0f6c19bfb0dd8307d08e50304d7e
Author: xhwang <xhwang@chromium.org>
Date: Thu Apr 21 03:06:42 2016

media: Use @MainDex for MediaDrmBridge inner classes

This is required for Java classes running outside the browser process on
K- versions of Android.

BUG= 605301 
TEST=EME works on Android K device.

Review URL: https://codereview.chromium.org/1903343003

Cr-Commit-Position: refs/heads/master@{#388673}

[modify] https://crrev.com/1c451bc3643a0f6c19bfb0dd8307d08e50304d7e/media/base/android/java/src/org/chromium/media/MediaDrmBridge.java

Comment 3 by xhw...@chromium.org, Apr 21 2016

Labels: Merge-Request-51

Comment 4 by tin...@google.com, Apr 21 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 21 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c22f7fea5ab3d28400f6acb08d4d66b8f8c1c240

commit c22f7fea5ab3d28400f6acb08d4d66b8f8c1c240
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Apr 21 18:28:53 2016

media: Use @MainDex for MediaDrmBridge inner classes

This is required for Java classes running outside the browser process on
K- versions of Android.

BUG= 605301 
TEST=EME works on Android K device.

Review URL: https://codereview.chromium.org/1903343003

Cr-Commit-Position: refs/heads/master@{#388673}
(cherry picked from commit 1c451bc3643a0f6c19bfb0dd8307d08e50304d7e)

Review URL: https://codereview.chromium.org/1905943003 .

Cr-Commit-Position: refs/branch-heads/2704@{#168}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/c22f7fea5ab3d28400f6acb08d4d66b8f8c1c240/media/base/android/java/src/org/chromium/media/MediaDrmBridge.java

Comment 6 by xhw...@chromium.org, Apr 21 2016

Status: Fixed (was: Started)

Sign in to add a comment