delete LinkDisambiguation code from desktop |
||
Issue descriptionLinkDisambiguationPopup, etc. this feature was implemented in 2014 and was briefly enabled, then disabled by default for the last 2 years. Time to dispose of it.
,
May 10 2016
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b87deb2d757a71be5c35530b443582038de2e376 commit b87deb2d757a71be5c35530b443582038de2e376 Author: EhsanK <ekaramad@chromium.org> Date: Thu Sep 14 17:42:32 2017 [refactor] Remove Unused API from RenderViewHostDelegate The methods removed have been initially added in https://codereview.chromium.org/712723002 in regards to "link disambiguation popup suppression in the presence of virtual keyboard". The logic however was later removed in: https://codereview.chromium.org/1926173002 which rendered removed methods useless. This CL removes the said methods from RenderViewHostDelegate. Bug: 605299 Change-Id: Ib4c942132dcb2ebd2364bc15898ccf84520d1b48 Reviewed-on: https://chromium-review.googlesource.com/665419 Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Charlie Reis (slow) <creis@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#501986} [modify] https://crrev.com/b87deb2d757a71be5c35530b443582038de2e376/content/browser/renderer_host/render_view_host_delegate.cc [modify] https://crrev.com/b87deb2d757a71be5c35530b443582038de2e376/content/browser/renderer_host/render_view_host_delegate.h [modify] https://crrev.com/b87deb2d757a71be5c35530b443582038de2e376/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/b87deb2d757a71be5c35530b443582038de2e376/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/b87deb2d757a71be5c35530b443582038de2e376/content/browser/web_contents/web_contents_impl.h |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 4 2016