New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605299 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

delete LinkDisambiguation code from desktop

Project Member Reported by est...@chromium.org, Apr 20 2016

Issue description

LinkDisambiguationPopup, etc.

this feature was implemented in 2014 and was briefly enabled, then disabled by default for the last 2 years. Time to dispose of it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c

commit 6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c
Author: estade <estade@chromium.org>
Date: Wed May 04 23:51:36 2016

Erase LinkDisambiguation code on desktop.

BUG= 605299 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
TBR=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/1926173002
Cr-Commit-Position: refs/heads/master@{#391698}

[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/chrome/app/generated_resources.grd
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/chrome/browser/about_flags.cc
[delete] https://crrev.com/1183f27e2663a6e519f57370f8c515339841408c/chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc
[delete] https://crrev.com/1183f27e2663a6e519f57370f8c515339841408c/chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.h
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/browser/renderer_host/render_view_host_delegate_view.h
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/content_renderer.gypi
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/content_tests.gypi
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/public/browser/web_contents_view_delegate.cc
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/public/browser/web_contents_view_delegate.h
[rename] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/renderer/android/disambiguation_popup_helper.cc
[rename] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/renderer/android/disambiguation_popup_helper.h
[rename] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/renderer/android/disambiguation_popup_helper_unittest.cc
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/renderer/render_view_impl.cc
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/content/renderer/render_view_impl.h
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/ui/base/ui_base_switches.cc
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/ui/base/ui_base_switches.h
[modify] https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c/ui/base/ui_base_switches_util.cc

Comment 2 by est...@chromium.org, May 10 2016

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b87deb2d757a71be5c35530b443582038de2e376

commit b87deb2d757a71be5c35530b443582038de2e376
Author: EhsanK <ekaramad@chromium.org>
Date: Thu Sep 14 17:42:32 2017

[refactor]  Remove Unused API from RenderViewHostDelegate

The methods removed have been initially added in
https://codereview.chromium.org/712723002 in regards to "link
disambiguation popup suppression in the presence of virtual keyboard".
The logic however was later removed in:
https://codereview.chromium.org/1926173002
which rendered removed methods useless. This CL removes the said
methods from RenderViewHostDelegate.

Bug:  605299 
Change-Id: Ib4c942132dcb2ebd2364bc15898ccf84520d1b48
Reviewed-on: https://chromium-review.googlesource.com/665419
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Charlie Reis (slow) <creis@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501986}
[modify] https://crrev.com/b87deb2d757a71be5c35530b443582038de2e376/content/browser/renderer_host/render_view_host_delegate.cc
[modify] https://crrev.com/b87deb2d757a71be5c35530b443582038de2e376/content/browser/renderer_host/render_view_host_delegate.h
[modify] https://crrev.com/b87deb2d757a71be5c35530b443582038de2e376/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/b87deb2d757a71be5c35530b443582038de2e376/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/b87deb2d757a71be5c35530b443582038de2e376/content/browser/web_contents/web_contents_impl.h

Sign in to add a comment