New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605298 link

Starred by 1 user
Status: Fixed
Owner:
█ mariakho...@chromium.org
Left Chrome team
Closed: Nov 2016
Cc:
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

MemoryInfra: Allow configurable limit to exclude small allocations

Project Member Reported by mariakho...@chromium.org, Apr 20 2016 
Background context:go/memory-infra: memory profiling in chrome://tracing

Add a parameter to trace config file that will allow to customize the cutoff for keeping heap traces for small allocations.

Change the current code to use a non-relative value, so that very large allocations don't push out medium sized ones from the traces.
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b1e75900d721b57351754318af8bcfaa7815744

commit 3b1e75900d721b57351754318af8bcfaa7815744
Author: mariakhomenko <mariakhomenko@chromium.org>
Date: Thu May 05 06:51:42 2016

Add configurable limit to allocations in heap profiler.

Adds a new trace config parameter, min_allocation_size_bytes, which determines
the cutoff for allocation sizes below which the traces for that allocation are
excluded from the trace file.

Makes the default cutoff to be 1024 bytes.

BUG= 605298 

Review-Url: https://codereview.chromium.org/1911643002
Cr-Commit-Position: refs/heads/master@{#391773}

[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/base/trace_event/heap_profiler_heap_dump_writer.cc
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/base/trace_event/heap_profiler_heap_dump_writer.h
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/base/trace_event/heap_profiler_heap_dump_writer_unittest.cc
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/base/trace_event/malloc_dump_provider.cc
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/base/trace_event/memory_dump_session_state.cc
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/base/trace_event/memory_dump_session_state.h
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/base/trace_event/trace_config.cc
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/base/trace_event/trace_config.h
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/base/trace_event/trace_config_memory_test_util.h
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/base/trace_event/trace_config_unittest.cc
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/third_party/WebKit/Source/devtools/protocol.json
[modify] https://crrev.com/3b1e75900d721b57351754318af8bcfaa7815744/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc

Comment 2 by primiano@chromium.org, Nov 25 2016

Status: Fixed (was: Assigned)

Comment 3 by primiano@chromium.org, Jan 4 2017

Components: Internals>Instrumentation>Memory
►

Sign in to add a comment