Problem with activating find-in-page match via find tickbar |
||
Issue descriptionVersion: 52.0.2710.0 OS: Android What steps will reproduce the problem? (1) Open a page with text. (2) Search using find-in-page for a string that appears multiple times. (3) Hit the down arrow to find the next match. (4) Touch one of the yellow ticks in the tickbar (on the right, showing matches down the page). What is the expected output? I expect that match to become the active match, and that tick to become orange. What do you see instead? It looks like the active match highlighting in the page moves to the right match, but neither the active match ordinal nor the tickbar are updated. I believe I may have caused this somehow in one of my recently landed CLs: https://codereview.chromium.org/1851793002/
,
Apr 22 2016
I have located the problem and have a fix in progress now: https://codereview.chromium.org/1913543002/
,
Apr 25 2016
Issue 606239 has been merged into this issue.
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cfca29de5756e4f3e5b5210d21cf6f4461d0aa8 commit 1cfca29de5756e4f3e5b5210d21cf6f4461d0aa8 Author: paulmeyer <paulmeyer@chromium.org> Date: Mon Apr 25 23:25:57 2016 Fix for problem with activating find-in-page match via find tickbar. The problem was that the TabFindHelper was throwing out certain valid find replies because the helper was only comparing them against the latest find request ID it knows about (which is usually the ID that valid replies will have). This patch makes it so that this and another android-specific find helper now properly track the current find session ID (in addition to the latest request ID) so that they can accept all valid find replies relevant to the current find session. BUG= 605297 Review URL: https://codereview.chromium.org/1913543002 Cr-Commit-Position: refs/heads/master@{#389603} [modify] https://crrev.com/1cfca29de5756e4f3e5b5210d21cf6f4461d0aa8/android_webview/browser/find_helper.cc [modify] https://crrev.com/1cfca29de5756e4f3e5b5210d21cf6f4461d0aa8/android_webview/browser/find_helper.h [modify] https://crrev.com/1cfca29de5756e4f3e5b5210d21cf6f4461d0aa8/chrome/browser/ui/find_bar/find_tab_helper.cc [modify] https://crrev.com/1cfca29de5756e4f3e5b5210d21cf6f4461d0aa8/chrome/browser/ui/find_bar/find_tab_helper.h [modify] https://crrev.com/1cfca29de5756e4f3e5b5210d21cf6f4461d0aa8/content/browser/find_request_manager.cc
,
Apr 26 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by paulmeyer@chromium.org
, Apr 22 2016