New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605289 link

Starred by 1 user
Status: Assigned
Owner:
clamy@chromium.org
Cc:
creis@chromium.org
█ nasko@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Many renderer kills from RFH_FAIL_PROVISIONAL_LOAD_NO_HANDLE

Project Member Reported by creis@chromium.org, Apr 20 2016 
Version: 52.0.2712.0
OS: All

We're seeing a substantial number of renderer kills in RFH_FAIL_PROVISIONAL_LOAD_NO_HANDLE, which was introduced in https://codereview.chromium.org/1880423002/.  By far the most are from the --isolate-extensions field trial (SiteIsolationExtensions), but it happens in the control group as well.

I'll disable that kill for now, but we should figure out why it's happening, prevent it, and re-introduce the kill.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec53a5efe2db2eaf81f43e69430a128a7fe5ec31

commit ec53a5efe2db2eaf81f43e69430a128a7fe5ec31
Author: creis <creis@chromium.org>
Date: Thu Apr 21 03:12:03 2016

Avoid renderer kills for missing NavigationHandle in DidFail.

TBR=clamy
BUG=605289
TEST=Fewer renderer kills in the stability data.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1907693002

Cr-Commit-Position: refs/heads/master@{#388680}

[modify] https://crrev.com/ec53a5efe2db2eaf81f43e69430a128a7fe5ec31/content/browser/frame_host/render_frame_host_impl.cc

Comment 2 by nasko@chromium.org, Dec 6 2016

Status: Fixed (was: Assigned)
I don't see RFH_FAIL_PROVISIONAL_LOAD_NO_HANDLE kills in M53 and above. Closing as fixed based on the CL in comment #1.

Comment 3 by nasko@chromium.org, Dec 6 2016

Status: Untriaged (was: Fixed)
Actually, I just missed the last part of the description that we need to reenable the kill. Undoing the closing.

Comment 4 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment