SimpleChrome GN error with BOARD=arm-generic: use_system_minigbm has no effect |
|||
Issue description
Failing command:
~/Work/chrome/src (master) $ cros chrome-sdk --board=arm-generic
(sdk arm-generic R52-8186.0.0-b18499) stevenjb@stevenjb3 ~/Work/chrome/src $ gn gen out_$SDK_BOARD/Release --args="$GN_ARGS"
ERROR at the command-line "--args":22:22: Build argument has no effect.
use_system_minigbm = true
^---
The variable "use_system_minigbm" was set as a build argument
but never appeared in a declare_args() block in any buildfile.
,
Apr 20 2016
use_system_minigbm appears in src/third_party/minigbm/BUILD.gn. minigbm is only included in ui/ozone/platform/drm/BUILD.gn use_ozone = true, so I'm not sure why we are getting this error.
,
Apr 21 2016
ui/ozone/BUILD.gn depends on platform/drm:gbm only when ozone_platform_gbm==true. (https://code.google.com/p/chromium/codesearch#chromium/src/ui/ozone/BUILD.gn&sq=package:chromium&q=platform/drm:gbm&l=39) So if ozone_platform_gbm is not set, GN complains about use_system_minigbm.
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/991f9069fd71eacce5ad689956621a6433714789 commit 991f9069fd71eacce5ad689956621a6433714789 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Apr 27 22:16:08 2016 Only set use_system_minigbm for ozone_platform_gbm BUG= chromium:605288 TEST=Ensure that use_system_minigbm is true in GN_ARGS on all board configurations with use_ozone = true, but not set where use_ozone = false Change-Id: I9adbb964ea9b78a244cc04329181628ad6740b9a Reviewed-on: https://chromium-review.googlesource.com/341063 Commit-Ready: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ilja Friedel <ihf@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/991f9069fd71eacce5ad689956621a6433714789/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Apr 28 2016
,
May 23 2016
Bulk verified
,
May 23 2016
bulk verified |
|||
►
Sign in to add a comment |
|||
Comment 1 by dpranke@chromium.org
, Apr 20 2016Status: Assigned (was: Untriaged)