Issue metadata
Sign in to add a comment
|
Alignment of theme images for active tab and frame/other tabs is off. |
||||||||||||||||||||||
Issue description49.0.2623.87 (Official Build) (64-bit) ToT os: linux, chromeos It looks to me that the frame and the inactive tabs are aligned, and the active tab and the location bar are aligned, but these two groups are not. I haven't tested but I assume Windows has the same issue. estade@, can you look into this?
,
Apr 20 2016
I believe this falls under pkasting's purview. How does this look in MD? (which is default on Linux M51+)
,
Apr 20 2016
MD has the same issue. (ToT + ChromeOS)
,
Apr 21 2016
This alignment is intentional. We used to have different alignment for restored versus maximized windows, meaning themes were always misaligned in one of the two. We standardized on an alignment so that now it's at least possible for themes to be correctly aligned all the time. Unfortunately this theme was built for the other alignment, so it's now misaligned all the time. (To be specific, we used the restored-mode alignment in all cases. Using the maximized-mode alignment in restored mode would leave an unpainted gap atop the window, so that wasn't an option. It also looked to me like more themes chose to align restored mode anyway.)
,
Apr 21 2016
Just to make sure I understand the expected behavior. This theme gets aligned in maximized window, not all the time. Is it still intentional?
,
Apr 21 2016
I'm testing on trunk, and the theme is misaligned all the time. You must be testing before my fix landed, in which case, per comment 4, the theme is presumably aligned only for maximized windows. After the alignment change, we use the restored-mode alignment in all cases.
,
Apr 22 2016
Interesting, it is indeed misaligned all the time on linux, but on chromeos, it's aligned in maximized mode. This is the screenshot take on yesterday's ToT (388810). Just FYI.
,
Apr 22 2016
Maybe the Ash frame is doing something weird; I don't normally touch that.
,
Apr 22 2016
Do you have an example theme that works all the time? I want to check if it works correctly on chromeos as well.
,
Apr 22 2016
,
Apr 22 2016
So the alignment is now always broken on chromeos. varkha@, can one of your team look into this?
,
Apr 25 2016
,
Oct 20 2017
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by osh...@chromium.org
, Apr 20 2016