We should update the FromGWS observer to log aborts. This will entail fixing up the logic to determine if a navigation is from gws before the commit point (for aborts before commit).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff3dd0217b152227db56a7d0731b431873ce88eb commit ff3dd0217b152227db56a7d0731b431873ce88eb Author: csharrison <csharrison@chromium.org> Date: Tue Apr 26 21:27:22 2016 This patch uses the WebContents' opener to extract the previous committed url for the very first navigation within the MetricsWebContentsObserver. This is used for the FromGWS abort metrics. This patch was split from the previous CL here: https://codereview.chromium.org/1901303004/ BUG= 605259 Review URL: https://codereview.chromium.org/1924543002 Cr-Commit-Position: refs/heads/master@{#389893} [modify] https://crrev.com/ff3dd0217b152227db56a7d0731b431873ce88eb/components/page_load_metrics/browser/metrics_web_contents_observer.cc [modify] https://crrev.com/ff3dd0217b152227db56a7d0731b431873ce88eb/components/page_load_metrics/browser/metrics_web_contents_observer.h [modify] https://crrev.com/ff3dd0217b152227db56a7d0731b431873ce88eb/components/page_load_metrics/browser/page_load_metrics_observer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bd4ae311136de4f95b19b8f1a3e6d4d8430b560 commit 6bd4ae311136de4f95b19b8f1a3e6d4d8430b560 Author: csharrison <csharrison@chromium.org> Date: Tue Apr 26 21:51:35 2016 Add FromGWS variants to the AbortTiming metrics This patch was split off from the larger CL authored here: https://codereview.chromium.org/1901303004/ BUG= 605259 Review URL: https://codereview.chromium.org/1919193003 Cr-Commit-Position: refs/heads/master@{#389903} [modify] https://crrev.com/6bd4ae311136de4f95b19b8f1a3e6d4d8430b560/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc [modify] https://crrev.com/6bd4ae311136de4f95b19b8f1a3e6d4d8430b560/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h [modify] https://crrev.com/6bd4ae311136de4f95b19b8f1a3e6d4d8430b560/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/6bd4ae311136de4f95b19b8f1a3e6d4d8430b560/tools/metrics/histograms/histograms.xml
Could we merge these two CLs into M-51? They are primarily metrics changes that are highly desired for this milestone.
Your change meets the bar and is auto-approved for M51 (branch: 2704)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0b63747d1888fb9ea8b46d7bd5870b410200684 commit b0b63747d1888fb9ea8b46d7bd5870b410200684 Author: Charles Harrison <csharrison@chromium.org> Date: Thu Apr 28 17:15:39 2016 This patch uses the WebContents' opener to extract the previous committed url for the very first navigation within the MetricsWebContentsObserver. This is used for the FromGWS abort metrics. This patch was split from the previous CL here: https://codereview.chromium.org/1901303004/ BUG= 605259 Review URL: https://codereview.chromium.org/1924543002 Cr-Commit-Position: refs/heads/master@{#389893} (cherry picked from commit ff3dd0217b152227db56a7d0731b431873ce88eb) Add FromGWS variants to the AbortTiming metrics This patch was split off from the larger CL authored here: https://codereview.chromium.org/1901303004/ BUG= 605259 Review URL: https://codereview.chromium.org/1919193003 Cr-Commit-Position: refs/heads/master@{#389903} (cherry picked from commit 6bd4ae311136de4f95b19b8f1a3e6d4d8430b560) TBR=bmcquade@chromium.org Review URL: https://codereview.chromium.org/1916913008 . Cr-Commit-Position: refs/branch-heads/2704@{#289} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/b0b63747d1888fb9ea8b46d7bd5870b410200684/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc [modify] https://crrev.com/b0b63747d1888fb9ea8b46d7bd5870b410200684/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h [modify] https://crrev.com/b0b63747d1888fb9ea8b46d7bd5870b410200684/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/b0b63747d1888fb9ea8b46d7bd5870b410200684/components/page_load_metrics/browser/metrics_web_contents_observer.cc [modify] https://crrev.com/b0b63747d1888fb9ea8b46d7bd5870b410200684/components/page_load_metrics/browser/metrics_web_contents_observer.h [modify] https://crrev.com/b0b63747d1888fb9ea8b46d7bd5870b410200684/components/page_load_metrics/browser/page_load_metrics_observer.h [modify] https://crrev.com/b0b63747d1888fb9ea8b46d7bd5870b410200684/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, Apr 26 2016