New issue
Advanced search Search tips

Issue 605258 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Deduplicate link header parsing code

Project Member Reported by mek@chromium.org, Apr 20 2016

Issue description

Content and blink both have code to parse Link: headers. That code should be moved to a new //components/something so both blink and content can share the same implementation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b28f42062acbf9241543d48b9479b449c95fc7b

commit 9b28f42062acbf9241543d48b9479b449c95fc7b
Author: mek <mek@chromium.org>
Date: Fri May 13 21:46:23 2016

Share link header parsing code between blink and content.

Introduces a new components/link_header_util with the shared parsing
logic. Moves blinks LinkHeader code from core/loader to platform/network
to be able to depend on this and use std::string.

BUG= 605258 

Review-Url: https://codereview.chromium.org/1811163002
Cr-Commit-Position: refs/heads/master@{#393650}

[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/components/BUILD.gn
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/components/components_tests.gyp
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/components/gcm_driver/crypto/encryption_header_parsers.cc
[add] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/components/link_header_util/BUILD.gn
[add] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/components/link_header_util/DEPS
[add] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/components/link_header_util/OWNERS
[add] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/components/link_header_util/link_header_util.cc
[add] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/components/link_header_util/link_header_util.gyp
[add] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/components/link_header_util/link_header_util.h
[add] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/components/link_header_util/link_header_util_unittest.cc
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/content/browser/BUILD.gn
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/content/browser/DEPS
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/content/browser/service_worker/link_header_support.cc
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/content/browser/service_worker/link_header_support_unittest.cc
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/content/content_browser.gypi
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/net/http/http_security_headers.cc
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/net/http/http_util.cc
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/net/http/http_util.h
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/net/http/http_util_unittest.cc
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/third_party/WebKit/LayoutTests/http/tests/preload/resources/media-link-headers.php
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/third_party/WebKit/Source/core/core.gypi
[delete] https://crrev.com/3b459237e5c0aa826e89e14c003ffbc1c27bf461/third_party/WebKit/Source/core/loader/LinkHeader.cpp
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/third_party/WebKit/Source/platform/DEPS
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/third_party/WebKit/Source/platform/blink_platform.gyp
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/third_party/WebKit/Source/platform/network/DEPS
[add] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/third_party/WebKit/Source/platform/network/LinkHeader.cpp
[rename] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/third_party/WebKit/Source/platform/network/LinkHeader.h
[rename] https://crrev.com/9b28f42062acbf9241543d48b9479b449c95fc7b/third_party/WebKit/Source/platform/network/LinkHeaderTest.cpp

Comment 2 by mek@chromium.org, May 13 2016

Status: Fixed (was: Started)

Sign in to add a comment