New issue
Advanced search Search tips

Issue 605244 link

Starred by 1 user
Status: Fixed
Owner:
sahel@chromium.org
Closed: May 2016
Cc:
tdres...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 574898



Sign in to add a comment

Need to count addEventListener usage for PointerEvents

Project Member Reported by mustaq@chromium.org, Apr 20 2016 
We suspect that a significant fraction of  early adopters of PointerEvent  would access only the legacy ME attributes within the PE. For example, could just replace the 1st param of addEventListener from "mouse..." to "pointer..." and get (or at least expect) a reasonable "TE coverage".

So, we need to count addEventHandler usage in addition to the current attribute usage counter.

This could be the place to add this:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/events/EventTarget.cpp&rcl=1461151052&l=145

Comment 1 by mustaq@chromium.org, Apr 27 2016

Blocking: 574898
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472

commit db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472
Author: sahel <sahel@chromium.org>
Date: Wed May 11 23:20:31 2016

Usecounter added for counting usage of addEventListener for PointerEvents.

BUG= 605244 
TEST=~/chromium/src/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-add-event-listener-count.html

Review-Url: https://codereview.chromium.org/1934413003
Cr-Commit-Position: refs/heads/master@{#393103}

[modify] https://crrev.com/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-use-count-expected.txt
[modify] https://crrev.com/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-use-count.html
[modify] https://crrev.com/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472/third_party/WebKit/Source/core/events/EventTarget.cpp
[add] https://crrev.com/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472/third_party/WebKit/Source/core/events/EventUtil.cpp
[add] https://crrev.com/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472/third_party/WebKit/Source/core/events/EventUtil.h
[modify] https://crrev.com/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
[modify] https://crrev.com/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/db9ccdad371b96fa9b30e2fa88dcc8fc6b1bf472/tools/metrics/histograms/histograms.xml

Comment 3 by sahel@chromium.org, May 11 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment