New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605234 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Priority inversion fixup in TileManager should be recursive.

Project Member Reported by ericrk@chromium.org, Apr 20 2016

Issue description

Currently TileManager updates a task's category from background to foreground if a new high priority task depends on it. This doesn't handle GPU image decode tasks as the update doesn't check a dependency's dependencies to find additional tasks categories to upgrade. We may want to enable this behavior, or alternately fix  crbug.com/594851 , which will make this unnecessary.

A naive recursive approach seems too heavy for sites with a lot of images.
 
Cc: prashan...@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ae72aff5123edc8c9042da88a95b895a227297e

commit 3ae72aff5123edc8c9042da88a95b895a227297e
Author: ericrk <ericrk@chromium.org>
Date: Tue May 03 11:19:48 2016

Clean up task category assignment

Task category assignment in TileManager is a bit roundabout, and can be
simpler now that all TileTasks have the |supports_concurrent_execution|
method.

This change also fixes an issue where NONCONCURRENT_FOREGROUND tasks
were accidentally downgraded to FOREGROUND.

BUG=605234
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1910613002
Cr-Commit-Position: refs/heads/master@{#391200}

[modify] https://crrev.com/3ae72aff5123edc8c9042da88a95b895a227297e/cc/tiles/tile_manager.cc

Comment 3 by ericrk@chromium.org, Jan 20 2017

Labels: -Type-Bug Type-Feature

Sign in to add a comment