PersistentSampleMap needs to support negative values. |
||
Issue descriptionAlthough histograms aren't supposed to have negative values, the SparseHistogram does allow them and at least one histogram on Mac (SimpleCache.Http.FileDescriptorLimitHard) uses that. This causes the debug PersistentSampleMap to crash (if persistent histograms are enabled) because it DCHECKs that the value is not negative. It uses a negative value to indicate "all" during loading of sample data.
,
Apr 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82b10a43c1a329c1b198fdeddae101ba0dc029c5 commit 82b10a43c1a329c1b198fdeddae101ba0dc029c5 Author: bcwhite <bcwhite@chromium.org> Date: Thu Apr 21 13:39:07 2016 Support negative sample values in PersistentHistogramMap. BUG= 605229 Review URL: https://codereview.chromium.org/1909673002 Cr-Commit-Position: refs/heads/master@{#388758} [modify] https://crrev.com/82b10a43c1a329c1b198fdeddae101ba0dc029c5/base/metrics/persistent_sample_map.cc [modify] https://crrev.com/82b10a43c1a329c1b198fdeddae101ba0dc029c5/base/metrics/persistent_sample_map.h [modify] https://crrev.com/82b10a43c1a329c1b198fdeddae101ba0dc029c5/base/metrics/persistent_sample_map_unittest.cc
,
Apr 21 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by asvitk...@chromium.org
, Apr 20 2016