New issue
Advanced search Search tips

Issue 605201 link

Starred by 1 user
Status: Fixed
Owner:
gab@chromium.org
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

git cl upload with vi as an editor results in blocking warning

Project Member Reported by gab@chromium.org, Apr 20 2016 
".../cl_description.../ [Incomplete last line][dos format] 10 lines, 318 characters
Press ENTER or type command to continue

Pressing ENTER works, but this is annoying (just started happening semi-recently) and I have a fix for it @ https://codereview.chromium.org/1905693002

Note: [dos format] is another warning but that one doesn't block, FWIU it's caused by fileobj.write() replacing '\n\ with os.linesep which is '\r\n' on Windows but that's okay because read() auto replaces them back.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/a3fe2903e215f5da8b3b3d00e7d8c16a8580ee68

commit a3fe2903e215f5da8b3b3d00e7d8c16a8580ee68
Author: gab@chromium.org <gab@chromium.org>
Date: Wed Apr 20 18:31:37 2016

Ensure files passed to the editor by RunEditor end in a new line

BUG= 605201 

Review URL: https://codereview.chromium.org/1905693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300049 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/a3fe2903e215f5da8b3b3d00e7d8c16a8580ee68/gclient_utils.py
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/68f7ea1039685769ecc1058d6fd3855c6703027a

commit 68f7ea1039685769ecc1058d6fd3855c6703027a
Author: recipe-roller@chromium.org <recipe-roller@chromium.org>
Date: Wed Apr 20 18:48:59 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/a3fe2903e215f5da8b3b3d00e7d8c16a8580ee68 Ensure files passed to the editor by RunEditor end in a new line (gab@chromium.org)

R=gab@chromium.org
BUG= 605201 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1910583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300052 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/68f7ea1039685769ecc1058d6fd3855c6703027a/infra/config/recipes.cfg

Comment 3 by gab@chromium.org, Apr 20 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2016 

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86901

------------------------------------------------------------------
r86901 | recipe-roller@chromium.org | 2016-04-21T21:08:59.493261Z

-----------------------------------------------------------------
►

Sign in to add a comment