New issue
Advanced search Search tips

Issue 605177 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: May 2017
Cc:
grt@chromium.org
zmin@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Test update scenarios

Project Member Reported by fdoray@chromium.org, Apr 20 2016 
We have integration tests for mini_installer.exe. Unfortunately, they don't cover update scenarios.

We should have regular and in-use update tests. These tests should verify that after the update:
- The new files have been written in the installation directory.
- Chrome can be launched through its shortcuts.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f60b933129fc5da66040af05cd22701dfcea8a28

commit f60b933129fc5da66040af05cd22701dfcea8a28
Author: fdoray <fdoray@chromium.org>
Date: Wed Apr 27 20:00:26 2016

Add next_version_mini_installer target.

This target generates next_version_mini_installer.exe, which has a
higher version number than mini_installer.exe. This new installer
will be used to test various update scenarios (using test_installer.py).

next_version_mini_installer needs to be added to the list of
dependencies of MiniInstallerTest before tests start using it.
(build/scripts/slave/recipe_modules/chromium_tests/steps.py)

BUG= 605177 

Review-Url: https://codereview.chromium.org/1902233003
Cr-Commit-Position: refs/heads/master@{#390158}

[modify] https://crrev.com/f60b933129fc5da66040af05cd22701dfcea8a28/BUILD.gn
[modify] https://crrev.com/f60b933129fc5da66040af05cd22701dfcea8a28/build/all.gyp
[modify] https://crrev.com/f60b933129fc5da66040af05cd22701dfcea8a28/build/gn_migration.gypi
[modify] https://crrev.com/f60b933129fc5da66040af05cd22701dfcea8a28/chrome/installer/mini_installer.gyp
[modify] https://crrev.com/f60b933129fc5da66040af05cd22701dfcea8a28/chrome/installer/mini_installer/BUILD.gn
[add] https://crrev.com/f60b933129fc5da66040af05cd22701dfcea8a28/chrome/installer/mini_installer/generate_next_version_mini_installer.py
[modify] https://crrev.com/f60b933129fc5da66040af05cd22701dfcea8a28/chrome/installer/test/alternate_version_generator_main.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9

commit 8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9
Author: jdonnelly <jdonnelly@chromium.org>
Date: Wed Apr 27 21:23:01 2016

Revert of Add next_version_mini_installer target. (patchset #6 id:100001 of https://codereview.chromium.org/1902233003/ )

Reason for revert:
Broke the Win builder: https://build.chromium.org/p/chromium/builders/Win/builds/42817

Failed step checkbins:

Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /DYNAMICBASE... FAIL
Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /NXCOMPAT... PASS
Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /SAFESEH... PASS

Original issue's description:
> Add next_version_mini_installer target.
>
> This target generates next_version_mini_installer.exe, which has a
> higher version number than mini_installer.exe. This new installer
> will be used to test various update scenarios (using test_installer.py).
>
> next_version_mini_installer needs to be added to the list of
> dependencies of MiniInstallerTest before tests start using it.
> (build/scripts/slave/recipe_modules/chromium_tests/steps.py)
>
> BUG= 605177 

TBR=grt@chromium.org,dpranke@chromium.org,zmin@chromium.org,eclipse0072015@gmail.com,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605177 

Review-Url: https://codereview.chromium.org/1926893002
Cr-Commit-Position: refs/heads/master@{#390191}

[modify] https://crrev.com/8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9/BUILD.gn
[modify] https://crrev.com/8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9/build/all.gyp
[modify] https://crrev.com/8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9/build/gn_migration.gypi
[modify] https://crrev.com/8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9/chrome/installer/mini_installer.gyp
[modify] https://crrev.com/8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9/chrome/installer/mini_installer/BUILD.gn
[delete] https://crrev.com/47aee4ab460a9f4ce895794d23c73fe02c2f4548/chrome/installer/mini_installer/generate_next_version_mini_installer.py
[modify] https://crrev.com/8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9/chrome/installer/test/alternate_version_generator_main.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb048bff9ec1ecdb632386878c33168a77b75895

commit fb048bff9ec1ecdb632386878c33168a77b75895
Author: fdoray <fdoray@chromium.org>
Date: Thu Apr 28 22:07:36 2016

Add next_version_mini_installer target.

This target generates next_version_mini_installer.exe, which has a
higher version number than mini_installer.exe. This new installer
will be used to test various update scenarios (using test_installer.py).

next_version_mini_installer needs to be added to the list of
dependencies of MiniInstallerTest before tests start using it.
(build/scripts/slave/recipe_modules/chromium_tests/steps.py)

This CL is based on https://codereview.chromium.org/1902233003 which
was reverted because it broke Win Builder. To avoid this problem, this
CL adds next_version_mini_installer.exe to the list of files excluded
from the checkbins step.

BUG= 605177 

Review-Url: https://codereview.chromium.org/1928983002
Cr-Commit-Position: refs/heads/master@{#390503}

[modify] https://crrev.com/fb048bff9ec1ecdb632386878c33168a77b75895/BUILD.gn
[modify] https://crrev.com/fb048bff9ec1ecdb632386878c33168a77b75895/build/all.gyp
[modify] https://crrev.com/fb048bff9ec1ecdb632386878c33168a77b75895/build/gn_migration.gypi
[modify] https://crrev.com/fb048bff9ec1ecdb632386878c33168a77b75895/chrome/installer/mini_installer.gyp
[modify] https://crrev.com/fb048bff9ec1ecdb632386878c33168a77b75895/chrome/installer/mini_installer/BUILD.gn
[add] https://crrev.com/fb048bff9ec1ecdb632386878c33168a77b75895/chrome/installer/mini_installer/generate_next_version_mini_installer.py
[modify] https://crrev.com/fb048bff9ec1ecdb632386878c33168a77b75895/chrome/installer/test/alternate_version_generator_main.cc
[modify] https://crrev.com/fb048bff9ec1ecdb632386878c33168a77b75895/tools/checkbins/checkbins.py
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/7263ea394d5d286183dc938f1d7557dde805f123

commit 7263ea394d5d286183dc938f1d7557dde805f123
Author: fdoray@chromium.org <fdoray@chromium.org>
Date: Fri Apr 29 19:02:35 2016

Add next_version_mini_installer to MiniInstallerTest's compile targets.

We plan to start using next_version_mini_installer.exe in mini_installer
tests https://codereview.chromium.org/1929383002

BUG= 605177 

Review-Url: https://codereview.chromium.org/1935583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300363 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder_Trybot.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng_exp.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_rel_ng.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_ng.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_ng.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json
[modify] https://crrev.com/7263ea394d5d286183dc938f1d7557dde805f123/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87238

------------------------------------------------------------------
r87238 | recipe-roller@chromium.org | 2016-04-29T19:37:42.100337Z

-----------------------------------------------------------------
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/7016519c50790123fdf4ca04c828fcef6340c2e9

commit 7016519c50790123fdf4ca04c828fcef6340c2e9
Author: dpranke@chromium.org <dpranke@chromium.org>
Date: Fri Apr 29 23:36:23 2016

Revert of Add next_version_mini_installer to MiniInstallerTest's compile targets. (patchset #2 id:20001 of https://codereview.chromium.org/1935583002/ )

Reason for revert:
Unfortunately, I need to revert this because it breaks one of the internal builders.

See the details in crbug.com/608066.

Original issue's description:
> Add next_version_mini_installer to MiniInstallerTest's compile targets.
> 
> We plan to start using next_version_mini_installer.exe in mini_installer
> tests https://codereview.chromium.org/1929383002
> 
> BUG= 605177 
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300363

TBR=fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605177 

Review-Url: https://codereview.chromium.org/1934033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300379 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder_Trybot.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng_exp.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_rel_ng.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_ng.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_ng.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json
[modify] https://crrev.com/7016519c50790123fdf4ca04c828fcef6340c2e9/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 30 2016 

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87251

------------------------------------------------------------------
r87251 | recipe-roller@chromium.org | 2016-04-30T00:00:22.394896Z

-----------------------------------------------------------------

Comment 8 by grt@chromium.org, May 24 2016

Cc: zmin@chromium.org
What do you think of merging r390503 to M51 so that the MiniInstallerTest compile targets change can re-land soon-ish?

Comment 9 by fdoray@chromium.org, Jun 1 2016

Labels: Merge-Request-51
Request to merge r390503 to M51. This change adds the next_version_mini_installer target which is *only used in tests*. Having this target in M51 will allow it to be added as a dependency of the installer tests (test dependencies are the same for all branches).

Comment 10 by tin...@google.com, Jun 1 2016

Labels: -Merge-Request-51 Merge-Review-51 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M51), manual review required.

Comment 11 by sshru...@google.com, Jun 3 2016 

I see a revert because it broke a builder, and I don't see anything here that suggests this is very high impact and necessary on M51. I am not comfortable merging this into a post-stable branch. Please remove the merge request if that makes sense, or add more details to the request.

Comment 12 by fdoray@chromium.org, Jun 3 2016 

The CL that I want to merge (r390503) didn't break any builder.

This CL adds a new compile target (next_version_mini_installer). It doesn't affect any existing binary.

We want to add this target as a dependency of mini-installer tests on trunk. Unfortunately, the current infrastructure doesn't allow us to have different test dependencies for different branches (i.e. we can't add a target as a dependency of an existing test if it doesn't exist on all supported branches).

tl;dr Having this target on branch M51 would unblock our work to add new mini-installer tests on trunk and doesn't affect any M51 binary.

Comment 13 by gab@chromium.org, Jun 8 2016 

Hi Francois, it seems r390158 causes build spew for mini_installer target ("ninja -C out/Release mini_installer" should not produce stdout output unless there are errors).

In a successful build, I'm getting:
====================================================
[8/13] ACTION //chrome/installer/mini_installer:next_version_mini_installer(//build/toolchain/win:x64)
Microsoft (R) File Expansion Utility  Version 10.0.10011.16384
Copyright (c) Microsoft Corporation. All rights reserved.

Adding C:\Users\gab\AppData\Local\Temp\mini_installer_test_temp2096_4999\setup.exe to Extraction Queue

Expanding Files ....

Expanding Files Complete ...

7-Zip (a) [64] 15.14 : Copyright (c) 1999-2015 Igor Pavlov : 2015-12-31

Scanning the drive:
11 folders, 403 files, 347487821 bytes (332 MiB)

Creating archive: C:\Users\gab\AppData\Local\Temp\mini_installer_test_temp2096_4999\CHROME.7Z

Items to compress: 414


Files read from disk: 403
Archive size: 347494084 bytes (332 MiB)
Everything is Ok
Cabinet Maker - Lossless Data Compression Tool

Generated version 53.0.2763.1 from version 53.0.2763.0
====================================================

Probably need a trick similar to the one I added to create_installer_archive.py in https://codereview.chromium.org/1372303003 in generate_next_version_mini_installer.py.

Cheers,
Gab

Comment 14 by gov...@chromium.org, Jun 27 2016 

Does this require a merge to M52? If yes, please request a merge to M52 by applying "Merge-Request-52" label. Thank you.

Comment 15 by fdoray@chromium.org, Jun 28 2016

Labels: Merge-Request-51
No, this is already in M52.

I would like to merge fb048bff9ec1ecdb632386878c33168a77b75895 in M51. As I explained in comment #12, this commit doesn't affect any existing binary. It adds a new target 'next_version_mini_installer' that we want to use for installer tests on trunk. It is unfortunately not possible to add a test dependency on trunk if the dependency doesn't exist on all maintained branches.

Comment 16 by dimu@google.com, Jun 28 2016

Labels: -Merge-Request-51
[Automated comment] Request affecting a post-stable build (M51), manual review required.

Comment 17 by grt@chromium.org, Jul 25 2016 

Is this unblocked now that M52 is on stable?

Comment 18 by fdoray@chromium.org, Jul 26 2016 

Yes. Working on it https://codereview.chromium.org/2182133002/
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20

commit fa772cf7a2487a00eb38ff4eb7377b80f82c8b20
Author: fdoray <fdoray@chromium.org>
Date: Tue Jul 26 19:09:35 2016

Add next_version_mini_installer to MiniInstallerTest's compile targets.

We plan to start using next_version_mini_installer.exe in mini_installer
tests https://codereview.chromium.org/1929383002

This CL is identical to https://codereview.chromium.org/1935583002
It shouldn't be reverted this time because the
'next_version_mini_installer' target exists in all supported branches
(M52+).

BUG= 605177 

Review-Url: https://codereview.chromium.org/2182133002

[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder_Trybot.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng_exp.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_rel_ng.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_ng.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_ng.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json
[modify] https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/a0dee83fe037438141893e4ef393780f55425560

commit a0dee83fe037438141893e4ef393780f55425560
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 26 21:47:37 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/85dc563ddd3caa560307c9d79a6d4842f83dace8 Labeling bisect/perf try jobs with a prominent null step. (robertocn@chromium.org)
  https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20 Add next_version_mini_installer to MiniInstallerTest's compile targets. (fdoray@chromium.org)
  https://crrev.com/ed78cc14380f4f28e9bdd3f3a054a6e5dab7ff4a Refactor chromium_tests tryserver.chromium.perf builder spec. (dtu@chromium.org)
  https://crrev.com/6387e4a41ee691fdee6007e07eea4b3acf1a9189 Added test suite table. (hzl@google.com)

R=robertocn@chromium.org,fdoray@chromium.org,dtu@chromium.org,hzl@google.com,eakuefner@chromium.org,sullivan@chromium.org
BUG= 605177 ,605572, 611484 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2188543003

[modify] https://crrev.com/a0dee83fe037438141893e4ef393780f55425560/infra/config/recipes.cfg
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/a0dee83fe037438141893e4ef393780f55425560

commit a0dee83fe037438141893e4ef393780f55425560
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 26 21:47:37 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/85dc563ddd3caa560307c9d79a6d4842f83dace8 Labeling bisect/perf try jobs with a prominent null step. (robertocn@chromium.org)
  https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20 Add next_version_mini_installer to MiniInstallerTest's compile targets. (fdoray@chromium.org)
  https://crrev.com/ed78cc14380f4f28e9bdd3f3a054a6e5dab7ff4a Refactor chromium_tests tryserver.chromium.perf builder spec. (dtu@chromium.org)
  https://crrev.com/6387e4a41ee691fdee6007e07eea4b3acf1a9189 Added test suite table. (hzl@google.com)

R=robertocn@chromium.org,fdoray@chromium.org,dtu@chromium.org,hzl@google.com,eakuefner@chromium.org,sullivan@chromium.org
BUG= 605177 ,605572, 611484 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2188543003

[modify] https://crrev.com/a0dee83fe037438141893e4ef393780f55425560/infra/config/recipes.cfg
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/a0dee83fe037438141893e4ef393780f55425560

commit a0dee83fe037438141893e4ef393780f55425560
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 26 21:47:37 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/85dc563ddd3caa560307c9d79a6d4842f83dace8 Labeling bisect/perf try jobs with a prominent null step. (robertocn@chromium.org)
  https://crrev.com/fa772cf7a2487a00eb38ff4eb7377b80f82c8b20 Add next_version_mini_installer to MiniInstallerTest's compile targets. (fdoray@chromium.org)
  https://crrev.com/ed78cc14380f4f28e9bdd3f3a054a6e5dab7ff4a Refactor chromium_tests tryserver.chromium.perf builder spec. (dtu@chromium.org)
  https://crrev.com/6387e4a41ee691fdee6007e07eea4b3acf1a9189 Added test suite table. (hzl@google.com)

R=robertocn@chromium.org,fdoray@chromium.org,dtu@chromium.org,hzl@google.com,eakuefner@chromium.org,sullivan@chromium.org
BUG= 605177 ,605572, 611484 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2188543003

[modify] https://crrev.com/a0dee83fe037438141893e4ef393780f55425560/infra/config/recipes.cfg
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 27 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/706b51a1b7f82c77a7d0be227b91d10c9d56b626

commit 706b51a1b7f82c77a7d0be227b91d10c9d56b626
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 27 05:15:59 2016
Project Member

Comment 24 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc0191e67db955f788ce61a5d4f832271ff102d4

commit fc0191e67db955f788ce61a5d4f832271ff102d4
Author: fdoray <fdoray@chromium.org>
Date: Wed Aug 03 21:59:08 2016

Add mini_installer not-in-use update test.

The new tests install Chrome at the user level, system level or SxS
and update it. They then verifies that files have been written as
expected.

BUG= 605177 

Review-Url: https://codereview.chromium.org/1929383002
Cr-Commit-Position: refs/heads/master@{#409635}

[modify] https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4/chrome/installer/mini_installer_tests.isolate
[modify] https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4/chrome/test/mini_installer/config/chrome_canary_installed.prop
[add] https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4/chrome/test/mini_installer/config/chrome_canary_updated.prop
[modify] https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4/chrome/test/mini_installer/config/chrome_system_installed.prop
[add] https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4/chrome/test/mini_installer/config/chrome_system_updated.prop
[modify] https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4/chrome/test/mini_installer/config/chrome_user_installed.prop
[add] https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4/chrome/test/mini_installer/config/chrome_user_updated.prop
[modify] https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4/chrome/test/mini_installer/config/config.config
[modify] https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4/chrome/test/mini_installer/test_installer.py
[modify] https://crrev.com/fc0191e67db955f788ce61a5d4f832271ff102d4/chrome/test/mini_installer/variable_expander.py

Comment 25 by fdoray@chromium.org, May 25 2017

Owner: ----
Launching Chrome after the installation is complete would be a nice addition. We would need to collect the call stack in case of a crash.

Comment 26 by grt@chromium.org, May 29 2017

Status: Fixed (was: Started)
Indeed. Issue 461856 is on file for that. I'm calling this bug fixed. Thanks, Francois!
►

Sign in to add a comment