MenuButtons need mac-specific look & feel, as used in the site info dialog.
Attached: screenshot of what these look like after https://codereview.chromium.org/1904753002/
:)
We need to ensure we handle subclasses of MenuButton too. E.g. the OIB. It looks like it overrides the border, or adds a second dotted-rectangle focus border. or something.
before/after screengrabs for Windows. Context: https://codereview.chromium.org/1904753002/diff/120001/ui/views/controls/button/menu_button.cc#newcode330 Note: - the alignment of the dropdown arrow changes - the extra border around the Chrome menu and extension toolbar buttons
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9412ffff054dd142ec06804e1e1303d3f6f064cf commit 9412ffff054dd142ec06804e1e1303d3f6f064cf Author: ellyjones <ellyjones@chromium.org> Date: Tue May 17 22:41:11 2016 Views: factor out Combobox background and const-ify style This change: * Factors background sizing out of Combobox * Makes ComboboxBackgroundMac reusable for other controls * Removes the ability to change the style of comboboxes dynamically * Introduces caching of arrow images for comboboxes BUG= 605161 Review-Url: https://codereview.chromium.org/1971333002 Cr-Commit-Position: refs/heads/master@{#394250} [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/chrome/browser/ui/views/translate/translate_bubble_view.cc [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/gfx/BUILD.gn [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/gfx/gfx.gyp [add] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/gfx/scoped_canvas.cc [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/gfx/scoped_canvas.h [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/views/controls/combobox/combobox.h [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/views/controls/combobox/combobox_unittest.cc [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/views/examples/combobox_example.cc [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/views/examples/examples.gyp [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/views/style/mac/combobox_background_mac.cc [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/views/style/mac/combobox_background_mac.h [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/views/style/platform_style.cc [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/views/style/platform_style.h [modify] https://crrev.com/9412ffff054dd142ec06804e1e1303d3f6f064cf/ui/views/style/platform_style_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5acf0c2022fc685f2250a54eea3b6e2bfc90dc60 commit 5acf0c2022fc685f2250a54eea3b6e2bfc90dc60 Author: ellyjones <ellyjones@chromium.org> Date: Thu Jun 09 22:07:58 2016 PermissionSelectorView: use Combobox on MacViews builds. The Cocoa version of this dialog uses the cocoa equivalent of Comboboxes. Also, Comboboxes on MacViews have appropriate styling, whereas MenuButtons don't and changing them to have it seems quite involved. This CL involves adapting the permission selector's MenuModel to a ComboboxModel, then creating a Combobox instead of a MenuButton on Mac. BUG= 605161 Review-Url: https://codereview.chromium.org/2011963002 Cr-Commit-Position: refs/heads/master@{#399034} [modify] https://crrev.com/5acf0c2022fc685f2250a54eea3b6e2bfc90dc60/chrome/browser/ui/views/website_settings/permission_selector_view.cc [modify] https://crrev.com/5acf0c2022fc685f2250a54eea3b6e2bfc90dc60/chrome/browser/ui/views/website_settings/permission_selector_view.h [modify] https://crrev.com/5acf0c2022fc685f2250a54eea3b6e2bfc90dc60/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc [modify] https://crrev.com/5acf0c2022fc685f2250a54eea3b6e2bfc90dc60/chrome/browser/ui/views/website_settings/website_settings_popup_view_unittest.cc
MacViews triage: this bug is extremely obsolete.
Comment 1 by lafo...@chromium.org
, Apr 20 2016