Issue metadata
Sign in to add a comment
|
bot_update with gerrit patches: need to do rebase |
||||||||||||||||||||||||
Issue descriptionCurrently, the ref is just checked out as is regardless of the value of revision, which is usually HEAD. This is different than what we do for Rietveld. There, we actually do a rebase. I think, default should be same as Rietveld, just so that we don't have to debug a ton of recipes while migrating to Gerrit.
,
Apr 20 2016
How debugging of a ton of recipes would be caused by not rebasing?
,
Apr 20 2016
Because some recipes make use of the current master branch revision. Example - goma client https://bugs.chromium.org/p/chromium/issues/detail?id=596787. But luckily it failed loudly, so it was noticed. Then some try recipes, like chrome trybot, in case of test failure with patch, try the same test without patch. What revision would be used in place of "without patch" is now open to chance.
,
Apr 27 2016
,
Jun 15 2016
,
Jun 24 2016
,
Jun 29 2016
Issue 624389 has been merged into this issue.
,
Jul 18 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tandrii@chromium.org
, Apr 20 2016