We saw a regression on Winodws only of version between 51.0.2693.2 and 51.0.2700.0 95 percentile on Event.Latency.TouchToFirstScrollUpdateSwapBegin Event.Latency.TouchToScrollUpdateSwapBegin. https://uma.googleplex.com/p/chrome/timeline_v2/?q=%7B%22day_count%22%3A%2290%22%2C%22end_date%22%3A%22latest%22%2C%22window_size%22%3A%221%22%2C%22filters%22%3A%5B%7B%22fieldId%22%3A%22channel%22%2C%22operator%22%3A%22EQ%22%2C%22study%22%3A%22%22%2C%22selected%22%3A%5B%222%22%5D%7D%2C%7B%22fieldId%22%3A%22version_tags%22%2C%22operator%22%3A%22CONTAINS%22%2C%22study%22%3A%22%22%2C%22selected%22%3A%5B%22D%22%5D%7D%2C%7B%22fieldId%22%3A%22platform%22%2C%22operator%22%3A%22COMPARE%22%2C%22study%22%3A%22%22%2C%22selected%22%3A%5B%22W%22%5D%7D%5D%2C%22histograms%22%3A%5B%22Event.Latency.TouchToFirstScrollUpdateSwapBegin%22%2C%22Event.Latency.TouchToScrollUpdateSwapBegin%22%5D%2C%22default_entry_values%22%3A%7B%22measureModel%22%3A%7B%22measure%22%3A%22%22%2C%22buckets%22%3A%5B%5D%2C%22percentiles%22%3A%5B%2250%22%5D%2C%22selectedFormulas%22%3A%5B%5D%2C%22allFormulas%22%3A%5B%5D%7D%2C%22zeroBased%22%3Atrue%2C%22logScale%22%3Afalse%2C%22showLowVolumeData%22%3Afalse%2C%22showVersionAnnotations%22%3Atrue%7D%2C%22entries%22%3A%5B%7B%22measureModel%22%3A%7B%22measure%22%3A%22percentile%22%2C%22percentiles%22%3A%5B%2295%22%5D%7D%7D%2C%7B%22measureModel%22%3A%7B%22measure%22%3A%22percentile%22%2C%22percentiles%22%3A%5B%2295%22%5D%7D%7D%5D%7D
The Event.Latency.TouchToScrollUpdateSwapBegin is much clearer.
This is because we accidentally started reporting wheel scrolling in this metric... Over to dtapuska to fix.
Only the LatencyInfo is conveyed from the compositor. It isn't clear when on a frame update it was caused by a touch or a wheel event.
Can we figure out the event type based on which components are present in the LatencyInfo? Is INPUT_EVENT_LATENCY_TERMINATED_MOUSE_WHEEL_COMPONENT present? https://code.google.com/p/chromium/codesearch#chromium/src/ui/events/latency_info.h&l=77
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9 commit 2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9 Author: dtapuska <dtapuska@chromium.org> Date: Fri Apr 22 22:27:29 2016 Fix reporting of TouchToFirstScroll latency metrics The metrics reported during GestureScrollUpdate contained mouse wheel event gestures as well. This appeared as increased data to be reported and showed a regression. To fix this tag when a gesture scroll update is generated by a mouse wheel event; and avoid these when reporting them to the uma metrics. BUG= 605147 Review URL: https://codereview.chromium.org/1911963005 Cr-Commit-Position: refs/heads/master@{#389271} [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/content/browser/renderer_host/input/input_router_client.h [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/content/browser/renderer_host/input/input_router_impl.cc [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/content/browser/renderer_host/input/input_router_impl.h [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/content/browser/renderer_host/input/input_router_impl_perftest.cc [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/content/browser/renderer_host/input/mock_input_router_client.cc [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/content/browser/renderer_host/input/mock_input_router_client.h [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/content/browser/renderer_host/input/mouse_wheel_event_queue.cc [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/content/browser/renderer_host/input/mouse_wheel_event_queue.h [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/ui/events/latency_info.cc [modify] https://crrev.com/2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9/ui/events/latency_info.h
Your change meets the bar and is auto-approved for M51 (branch: 2704)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4e6e8438b71f84bc75c731b17e3651c3f357271 commit b4e6e8438b71f84bc75c731b17e3651c3f357271 Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Apr 26 14:54:27 2016 Fix reporting of TouchToFirstScroll latency metrics The metrics reported during GestureScrollUpdate contained mouse wheel event gestures as well. This appeared as increased data to be reported and showed a regression. To fix this tag when a gesture scroll update is generated by a mouse wheel event; and avoid these when reporting them to the uma metrics. BUG= 605147 Review URL: https://codereview.chromium.org/1911963005 Cr-Commit-Position: refs/heads/master@{#389271} (cherry picked from commit 2148f54fea0ee0fa6d48d4cd87e204f6fbf7c9b9) Review URL: https://codereview.chromium.org/1922903002 . Cr-Commit-Position: refs/branch-heads/2704@{#248} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/content/browser/renderer_host/input/input_router_client.h [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/content/browser/renderer_host/input/input_router_impl.cc [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/content/browser/renderer_host/input/input_router_impl.h [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/content/browser/renderer_host/input/input_router_impl_perftest.cc [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/content/browser/renderer_host/input/mock_input_router_client.cc [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/content/browser/renderer_host/input/mock_input_router_client.h [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/content/browser/renderer_host/input/mouse_wheel_event_queue.cc [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/content/browser/renderer_host/input/mouse_wheel_event_queue.h [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/ui/events/latency_info.cc [modify] https://crrev.com/b4e6e8438b71f84bc75c731b17e3651c3f357271/ui/events/latency_info.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86a8870522b41ebd1166bcc9f795ec19a662c896 commit 86a8870522b41ebd1166bcc9f795ec19a662c896 Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Apr 26 16:38:35 2016 Fix build issue with change https://codereview.chromium.org/1922903002 M51 was toDOMWindow not toLocalDOMWindow() BUG= 605147 (cherry picked from commit de64386e2218c169d27f5f9879515c8d2c7511e2) Review URL: https://codereview.chromium.org/1918313002 . Cr-Commit-Position: refs/branch-heads/2704@{#249} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/86a8870522b41ebd1166bcc9f795ec19a662c896/third_party/WebKit/Source/core/input/EventHandler.cpp
Comment 1 by tdres...@chromium.org
, Apr 20 2016