New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605140 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

More pixels below the toolbar than above

Project Member Reported by shrike@chromium.org, Apr 20 2016

Issue description

Version: 52.0.2713.0
OS: 10.11

On Retina is's 7 above and 10 below. Not sure if this is a regression or not.
 
Artboard 1.png
40.1 KB View Download

Comment 1 by shrike@chromium.org, Apr 20 2016

Cc: ainslie@chromium.org

Comment 2 by meh...@chromium.org, Apr 20 2016

Maybe this happened on Retina after fixing  issue 602393  for Non-Retina?

Comment 3 by shrike@chromium.org, Apr 20 2016

Thanks - that might be the case.

Cc: pinkerton@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90b73afb789c6a84ce25579c08bb4ac55164c768

commit 90b73afb789c6a84ce25579c08bb4ac55164c768
Author: shrike <shrike@chromium.org>
Date: Mon May 09 18:41:34 2016

[Mac][Material Design] Fix toolbar height on Retina.

A recent change to center the toolbar's buttons and textfield on
Retina displays throws them off-center on Retina when in Material
Design. This change bypasses the adjustment in this case.

Note that on Retina there is an odd number of pixels between the top
and bottom edges of the toolbar, which means that the location bar's
contents cannot be exactly centered. This is per spec (it also
occurs on ChromeOS).

Lastly, this cl makes the location bar shadow color transparent.

R=avi@chromium.org
BUG= 605140 

Review-Url: https://codereview.chromium.org/1948963002
Cr-Commit-Position: refs/heads/master@{#392379}

[modify] https://crrev.com/90b73afb789c6a84ce25579c08bb4ac55164c768/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/90b73afb789c6a84ce25579c08bb4ac55164c768/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
[modify] https://crrev.com/90b73afb789c6a84ce25579c08bb4ac55164c768/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment