More pixels below the toolbar than above |
|||
Issue descriptionVersion: 52.0.2713.0 OS: 10.11 On Retina is's 7 above and 10 below. Not sure if this is a regression or not.
,
Apr 20 2016
Maybe this happened on Retina after fixing issue 602393 for Non-Retina?
,
Apr 20 2016
Thanks - that might be the case.
,
May 2 2016
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90b73afb789c6a84ce25579c08bb4ac55164c768 commit 90b73afb789c6a84ce25579c08bb4ac55164c768 Author: shrike <shrike@chromium.org> Date: Mon May 09 18:41:34 2016 [Mac][Material Design] Fix toolbar height on Retina. A recent change to center the toolbar's buttons and textfield on Retina displays throws them off-center on Retina when in Material Design. This change bypasses the adjustment in this case. Note that on Retina there is an odd number of pixels between the top and bottom edges of the toolbar, which means that the location bar's contents cannot be exactly centered. This is per spec (it also occurs on ChromeOS). Lastly, this cl makes the location bar shadow color transparent. R=avi@chromium.org BUG= 605140 Review-Url: https://codereview.chromium.org/1948963002 Cr-Commit-Position: refs/heads/master@{#392379} [modify] https://crrev.com/90b73afb789c6a84ce25579c08bb4ac55164c768/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/90b73afb789c6a84ce25579c08bb4ac55164c768/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm [modify] https://crrev.com/90b73afb789c6a84ce25579c08bb4ac55164c768/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
,
May 9 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by shrike@chromium.org
, Apr 20 2016