MacViews: CHECK failure in MaterialDesignController |
|||
Issue descriptionWhen mousing over a Views menu in MacViews, in views_examples_with_content_exe, this happens: [0420/104302:FATAL:material_design_controller.cc(63)] Check failed: is_mode_initialized_. 0 views_examples_with_content_exe 0x000000010e25d83f _ZN4base5debug10StackTraceC2Ev + 47 1 views_examples_with_content_exe 0x000000010e25d9e3 _ZN4base5debug10StackTraceC1Ev + 35 2 views_examples_with_content_exe 0x000000010e2d5f10 _ZN7logging10LogMessageD2Ev + 80 3 views_examples_with_content_exe 0x000000010e2d37b3 _ZN7logging10LogMessageD1Ev + 35 4 views_examples_with_content_exe 0x00000001113e142f _ZN2ui24MaterialDesignController7GetModeEv + 159 5 views_examples_with_content_exe 0x00000001113e148b _ZN2ui24MaterialDesignController14IsModeMaterialEv + 27 6 views_examples_with_content_exe 0x00000001198535eb _ZN5views12MenuItemView11PaintButtonEPN3gfx6CanvasENS0_15PaintButtonModeE + 1035 7 views_examples_with_content_exe 0x00000001198531bd _ZN5views12MenuItemView7OnPaintEPN3gfx6CanvasE + 45 8 views_examples_with_content_exe 0x0000000119916bee _ZN5views4View5PaintERKN2ui12PaintContextE + 2782 9 views_examples_with_content_exe 0x000000011991d16f _ZN5views4View13PaintChildrenERKN2ui12PaintContextE + 399 10 views_examples_with_content_exe 0x000000011986c130 _ZN5views11SubmenuView13PaintChildrenERKN2ui12PaintContextE + 64 11 views_examples_with_content_exe 0x0000000119916c14 _ZN5views4View5PaintERKN2ui12PaintContextE + 2820 12 views_examples_with_content_exe 0x000000011991d16f _ZN5views4View13PaintChildrenERKN2ui12PaintContextE + 399 13 views_examples_with_content_exe 0x0000000119916c14 _ZN5views4View5PaintERKN2ui12PaintContextE + 2820 14 views_examples_with_content_exe 0x000000011991d16f _ZN5views4View13PaintChildrenERKN2ui12PaintContextE + 399 15 views_examples_with_content_exe 0x0000000119916c14 _ZN5views4View5PaintERKN2ui12PaintContextE + 2820 16 views_examples_with_content_exe 0x000000011991d16f _ZN5views4View13PaintChildrenERKN2ui12PaintContextE + 399 17 views_examples_with_content_exe 0x0000000119916c14 _ZN5views4View5PaintERKN2ui12PaintContextE + 2820 18 views_examples_with_content_exe 0x0000000119945ebd _ZN5views6Widget19OnNativeWidgetPaintERKN2ui12PaintContextE + 77 19 views_examples_with_content_exe 0x00000001197ef6ce _ZN5views19BridgedNativeWidget12OnPaintLayerERKN2ui12PaintContextE + 334 20 views_examples_with_content_exe 0x00000001181075e6 _ZN2ui5Layer26PaintContentsToDisplayListEN2cc18ContentLayerClient22PaintingControlSettingE + 678 21 views_examples_with_content_exe 0x00000001181079f7 _ZThn8_N2ui5Layer26PaintContentsToDisplayListEN2cc18ContentLayerClient22PaintingControlSettingE + 55 22 views_examples_with_content_exe 0x0000000110487765 _ZN2cc15RecordingSource27UpdateAndExpandInvalidationEPNS_18ContentLayerClientEPNS_6RegionERKN3gfx4SizeEiNS0_13RecordingModeE + 981 23 views_examples_with_content_exe 0x0000000110374524 _ZN2cc12PictureLayer6UpdateEv + 1076 24 views_examples_with_content_exe 0x000000011062853d _ZN2cc13LayerTreeHost14DoUpdateLayersEPNS_5LayerE + 2877 25 views_examples_with_content_exe 0x0000000110627731 _ZN2cc13LayerTreeHost12UpdateLayersEv + 497 26 views_examples_with_content_exe 0x000000011075808e _ZN2cc17SingleThreadProxy16DoBeginMainFrameERKNS_14BeginFrameArgsE + 126 27 views_examples_with_content_exe 0x0000000110759c3e _ZN2cc17SingleThreadProxy14BeginMainFrameERKNS_14BeginFrameArgsE + 942 28 views_examples_with_content_exe 0x000000011075cf97 _ZN4base8internal15RunnableAdapterIMN2cc17SingleThreadProxyEFvRKNS2_14BeginFrameArgsEEE3RunIJS6_EEEvPS3_DpOT_ + 135 29 views_examples_with_content_exe 0x000000011075ceee _ZN4base8internal12InvokeHelperILb1EvNS0_15RunnableAdapterIMN2cc17SingleThreadProxyEFvRKNS3_14BeginFrameArgsEEEEE8MakeItSoINS_7WeakPtrIS4_EEJS7_EEEvSA_T_DpOT0_ + 94 30 views_examples_with_content_exe 0x000000011075ce64 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN2cc17SingleThreadProxyEFvRKNS6_14BeginFrameArgsEEEEFvPS7_SA_EJNS_7WeakPtrIS7_EESA_EEENS0_12InvokeHelperILb1EvSD_EEFvvEE3RunEPNS0_13BindStateBaseE + 148 31 views_examples_with_content_exe 0x000000010e46f48f _ZNK4base8CallbackIFvvELNS_8internal8CopyModeE1EE3RunEv + 63 32 views_examples_with_content_exe 0x000000011267d2d7 _ZN2ui12_GLOBAL__N_111WrappedTask3RunEv + 71 33 views_examples_with_content_exe 0x000000011267e537 _ZN4base8internal15RunnableAdapterIMN2ui12_GLOBAL__N_111WrappedTaskEFvvEE3RunIJEEEvPS4_DpOT_ + 119 34 views_examples_with_content_exe 0x000000011267e44d _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN2ui12_GLOBAL__N_111WrappedTaskEFvvEEEE8MakeItSoIJPS5_EEEvS8_DpOT_ + 61 35 views_examples_with_content_exe 0x000000011267e3e8 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN2ui12_GLOBAL__N_111WrappedTaskEFvvEEEFvPS8_EJNS0_12OwnedWrapperIS8_EEEEENS0_12InvokeHelperILb0EvSB_EEFvvEE3RunEPNS0_13BindStateBaseE + 104 36 views_examples_with_content_exe 0x000000010e46f48f _ZNK4base8CallbackIFvvELNS_8internal8CopyModeE1EE3RunEv + 63 37 views_examples_with_content_exe 0x000000010e25f23e _ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 654 38 views_examples_with_content_exe 0x000000010e31572d _ZN4base11MessageLoop7RunTaskERKNS_11PendingTaskE + 877 39 views_examples_with_content_exe 0x000000010e315e06 _ZN4base11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE + 86 40 views_examples_with_content_exe 0x000000010e316508 _ZN4base11MessageLoop6DoWorkEv + 552 41 views_examples_with_content_exe 0x000000010e213268 _ZN4base24MessagePumpCFRunLoopBase7RunWorkEv + 104 42 views_examples_with_content_exe 0x000000010e2131da ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 42 43 views_examples_with_content_exe 0x000000010e2d86fa _ZN4base3mac15CallWithEHFrameEU13block_pointerFvvE + 10 44 views_examples_with_content_exe 0x000000010e212575 _ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv + 101 45 CoreFoundation 0x00007fff8e864881 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 46 CoreFoundation 0x00007fff8e843fbc __CFRunLoopDoSources0 + 556 47 CoreFoundation 0x00007fff8e8434df __CFRunLoopRun + 927 48 CoreFoundation 0x00007fff8e842ed8 CFRunLoopRunSpecific + 296 49 HIToolbox 0x00007fff8ab5d935 RunCurrentEventLoopInMode + 235 50 HIToolbox 0x00007fff8ab5d76f ReceiveNextEventCommon + 432 51 HIToolbox 0x00007fff8ab5d5af _BlockUntilNextEventMatchingListInModeWithFilter + 71 52 AppKit 0x00007fff98303efa _DPSNextEvent + 1067 53 AppKit 0x00007fff9830332a -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 454 54 views_examples_with_content_exe 0x000000010e214649 _ZN4base24MessagePumpNSApplication5DoRunEPNS_11MessagePump8DelegateE + 505 55 views_examples_with_content_exe 0x000000010e212e7d _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 125 56 views_examples_with_content_exe 0x000000010e314f5a _ZN4base11MessageLoop10RunHandlerEv + 298 57 views_examples_with_content_exe 0x000000010e3b00b5 _ZN4base7RunLoop3RunEv + 85 58 views_examples_with_content_exe 0x0000000119858de7 _ZN5views18MenuMessageLoopMac3RunEPNS_14MenuControllerEPNS_6WidgetEb + 119 59 views_examples_with_content_exe 0x00000001198352b2 _ZN5views14MenuController14RunMessageLoopEb + 114 60 views_examples_with_content_exe 0x0000000119833b0e _ZN5views14MenuController3RunEPNS_6WidgetEPNS_10MenuButtonEPNS_12MenuItemViewERKN3gfx4RectENS_18MenuAnchorPositionEbbPi + 2334 61 views_examples_with_content_exe 0x0000000119861942 _ZN5views8internal14MenuRunnerImpl9RunMenuAtEPNS_6WidgetEPNS_10MenuButtonERKN3gfx4RectENS_18MenuAnchorPositionEi + 738 Trace/BPT trap
,
Apr 21 2016
I think estade just landed a fix for this in r388338 https://codereview.chromium.org/1895203004/ https://codereview.chromium.org/1895203004/diff/20001/ui/views/examples/examples_main.cc#newcode92 ui/views/examples/examples_main.cc:92: ui::MaterialDesignController::Initialize(); On 2016/04/19 18:14:55, msw wrote: > Why is this needed in this CL? without it, views_examples_exe crashes. This is due to varkha's recent change to the initialization process for MaterialDesignController. I guess no one noticed it till now.
,
Apr 21 2016
bleh - except that was for views_examples_exe, and views_examples_with_content_exe needs the same fix - like https://codereview.chromium.org/1903393003 (gonna steal this :3 - since I need that to also fix Issue 605404 )
,
Apr 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a23372cb2efd67280e8c7e99fdea0c9f8cf797ba commit a23372cb2efd67280e8c7e99fdea0c9f8cf797ba Author: tapted <tapted@chromium.org> Date: Fri Apr 22 06:15:33 2016 Initialize Material Design in views_examples_with_content_exe This is required since r386582 requires MaterialDesignController initialization to be explicit. It was fixed for views_examples in r388338 This applies a similar fix for views_content_client which is used by views_examples_with_content_exe Also, add an OWNERS file to ui/views_content_client with tapted@. Probably should have done this when I made it in r272902 but I was too timid. BUG= 605126 Review URL: https://codereview.chromium.org/1903393003 Cr-Commit-Position: refs/heads/master@{#389037} [add] https://crrev.com/a23372cb2efd67280e8c7e99fdea0c9f8cf797ba/ui/views_content_client/OWNERS [modify] https://crrev.com/a23372cb2efd67280e8c7e99fdea0c9f8cf797ba/ui/views_content_client/views_content_client_main_parts.cc
,
Apr 23 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by lafo...@chromium.org
, Apr 20 2016