New issue
Advanced search Search tips

Issue 605097 link

Starred by 1 user
Status: Fixed
Owner:
msramek@chromium.org
Closed: Jan 14
Cc:
maxwalker@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Extend the button string limit in ClearBrowsingDataPreferences on Android

Project Member Reported by msramek@chromium.org, Apr 20 2016 
With the revamp of the Clear Browsing Data dialog on Android ( issue 569870 ), we replaced the small dialog with a larger settings page.

This enabled us to replace "Clear" button with a larger "Clear data". However, the text limit of the button stayed at 20 chars. This seems not to be enough for some translations, such as Georgian.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0415dd81282d858c0b886556ece36a6e020a192e

commit 0415dd81282d858c0b886556ece36a6e020a192e
Author: msramek <msramek@chromium.org>
Date: Wed Apr 20 12:53:40 2016

Extend the "Clear data" button translation limit to 30 chars.

The previous 20 chars was unnecessarily short, since the button has its own row on the screen, and was reported not to be enough for e.g. Georgian translation.

TBR=tedchoc@chromium.org
BUG= 605097 

Review URL: https://codereview.chromium.org/1909443002

Cr-Commit-Position: refs/heads/master@{#388478}

[modify] https://crrev.com/0415dd81282d858c0b886556ece36a6e020a192e/chrome/android/java/strings/android_chrome_strings.grd

Comment 2 by benhenry@google.com, Jan 11 

You started fixing this bug over two years ago. Are you still working on it?

Comment 3 by msramek@google.com, Jan 14

Status: Fixed (was: Started)
Fixed in #1.
►

Sign in to add a comment