Regression: Incorrect focus position is seen in chrome://downloads on pressing Tab key.
Reported by
vvishwak...@etouch.net,
Apr 20 2016
|
||||||||||
Issue descriptionVersion: 52.0.2713.0 (Official Build) 939788c10e98a18cb74d5311f8792105930d9bd9-refs/heads/master@{#388380} (32/64-bit) OS: All (Win 7-Aero enabled) URL: http://mirror.internode.on.net/pub/test/ What steps will reproduce the problem? 1) Launch chrome, go to above URL and download any file. 2) Go to 'chrome://downloads', press Tab key till focus is on 'Pause' button and then press 'Enter' key. 3) Again press Tab key and observe. On pressing Tab key focus stays on 'RESUME' button. On pressing Tab key focus should be on 'CANCEL' button. This is a Regression issue broken in M-50, below is the bisect info Manual bisect: Good build: 50.0.2657.0 Bad build: 50.0.2658.0 Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/7a1e387c1670c314ff76f26f5061c8abae030c7d..11efbc5592132de8ad0f2e5ef158ecaf91cb8861?pretty=fuller&n=100 Suspecting: r376949
,
Apr 25 2016
I haven't investigated the details yet. But it seems cr.ui.FocusRow and sequential focus navigation starting point don't work together well.
,
Apr 25 2016
> 2) Go to 'chrome://downloads', press Tab key till focus is on 'Pause' button and then press 'Enter' key. On this step, - [Pause] button has tabindex=0, SFNSP is this. It gets display:none, and blur event happens. - [Resume] button has tabindex=0, and gets display:inline-block. - [Cancel] button has tabindex=0 > 3) Again press Tab key and observe. - FocusController finds [Resume] button, which is the next focusable element in tree order. I wonder how Chrome 52.0.2657.0 worked in this case. If I removed the SFNSP feature on ToT, Step 3 focused on [CLEAR ALL] button in the top bar. Downgrade to Pri-2 because the current behavior is not so crazy.
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 24 2016
I checked the behavior of r376947, it's just before my change. In Step 3, TAB key focused on [CLEAR ALL] button. So the behavior was already broken before my change. dbeam, is the current behavior acceptable? If not, who's responsible for focus behavior of md-downloads?
,
Jul 10 2016
Delegate to the owners of UI>Browser>Downloads. I can't fix this without feedback.
,
Jul 12 2016
dbeam@, could you take a look or assign someone?
,
Jul 15 2016
I didn't understand what "SFNSP", which kept me from responding for a while. the desired behavior is that focus effectively stays on "PAUSE" or "RESUME" when a downloads is paused/resumed via keyboard. maybe I can just change the text of the button instead of hiding/showing different buttons.
,
Jul 16 2016
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c17549d24c067ceaab8303f829fd090da0ae7d4 commit 9c17549d24c067ceaab8303f829fd090da0ae7d4 Author: dbeam <dbeam@chromium.org> Date: Tue Jul 19 04:03:17 2016 MD Downloads: fix focus issue on downloads page by combining pause/play R=tsergeant@chromium.org BUG= 605093 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2154033002 Cr-Commit-Position: refs/heads/master@{#406209} [modify] https://crrev.com/9c17549d24c067ceaab8303f829fd090da0ae7d4/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/9c17549d24c067ceaab8303f829fd090da0ae7d4/chrome/browser/resources/md_downloads/item.css [modify] https://crrev.com/9c17549d24c067ceaab8303f829fd090da0ae7d4/chrome/browser/resources/md_downloads/item.html [modify] https://crrev.com/9c17549d24c067ceaab8303f829fd090da0ae7d4/chrome/browser/resources/md_downloads/item.js [modify] https://crrev.com/9c17549d24c067ceaab8303f829fd090da0ae7d4/chrome/browser/resources/md_downloads/vulcanized.html
,
Jul 19 2016
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by vvishwak...@etouch.net
, Apr 20 2016