New issue
Advanced search Search tips

Issue 605087 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : While opening the list, Ripple effect is not fully seen for 'Select an account' dropdown.

Reported by yfulgaon...@etouch.net, Apr 20 2016

Issue description

Chrome Version: 52.0.2713.0 (Official Build) 939788c10e98a18cb74d5311f8792105930d9bd9-refs/heads/master@{#388380} 32/64 Bit. 
OS:Windows (Win 7 Aero enabled)

Precondition: 1. Enable 'Material design in the browser's top chrome' flag from 'chrome://flags'
	      2. Enable 'Material Design User Manager' flag from 'chrome://flags'

What steps will reproduce the problem?
1. Launch chrome, click on avatar icon and sign in to chrome.
2. Now click on 'Switch person' option in signin overlay and select 'ADD PERSON'.
3. Check the 'Supervise this person...' checkbox and click on 'Select an account' dropdown list.
4. Now observe the Ripple effect while opening the dropdown list.

Actual : While opening the list, Ripple effect is not fully seen for 'Select an account' dropdown.
Expected : The Ripple effect should be fully seen.

This is a regression issue,broken in 'M-51', below is manual bisect info

Good Build: 51.0.2702.0
Bad Build: 51.0.2704.0

Note : Unable to provide narrow bisect as sign in to chrome in chromium builds is not possible, hence providing a change log info.

Change log info:
https://chromium.googlesource.com/chromium/src/+log/51.0.2702.0..51.0.2704.0?pretty=fuller&n=10000

Suspecting : r385787 ? from change log

Please help to re-assign if your change is not the cause for this issue.
 
Actual_ripple_effect.mp4
1.1 MB Download
Expected_Ripple_effect.mp4
1.3 MB Download
Ripple_effect.png
108 KB View Download
Status: Started (was: Assigned)
https://codereview.chromium.org/1916913010/ is expected to fix this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a4c0a69d113eda53a86c4cd3013632f82f88a65

commit 9a4c0a69d113eda53a86c4cd3013632f82f88a65
Author: mahmadi <mahmadi@chromium.org>
Date: Wed May 04 02:16:11 2016

MD User Manager: Supervised user checkbox is always displaying.

When there are no signed in users available, a message containing a link to a HC article is displayed instead of the dropdown.
It also fixes the bug related to the ripple effect on the dropdown menu.

BUG=563722,  605087 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1939933002
Cr-Commit-Position: refs/heads/master@{#391417}

[modify] https://crrev.com/9a4c0a69d113eda53a86c4cd3013632f82f88a65/chrome/app/generated_resources.grd
[modify] https://crrev.com/9a4c0a69d113eda53a86c4cd3013632f82f88a65/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/9a4c0a69d113eda53a86c4cd3013632f82f88a65/chrome/browser/resources/md_user_manager/create_profile.js
[modify] https://crrev.com/9a4c0a69d113eda53a86c4cd3013632f82f88a65/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/9a4c0a69d113eda53a86c4cd3013632f82f88a65/chrome/test/data/webui/md_user_manager/create_profile_tests.js

Status: Fixed (was: Started)

Sign in to add a comment