New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605075 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Regression: Unnecessary page navigate to webstore after resetting to default theme in ‘chrome://md-settings'

Reported by dmascare...@etouch.net, Apr 20 2016

Issue description

Chrome Version: 52.0.2713.0 (Official Build)939788c10e98a18cb74d5311f8792105930d9bd9-refs/heads/master@{#388380} 32/64-bit.
OS: All

Pre-condition: Theme should be installed on the profile

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/
2. Click on ‘Reset the theme’ and observe.

Actual: Unnecessary page navigate to webstore after step 2.
Expected: Page should not navigate to webstore after step 2.

This is regression issue,broken ‘M51’ and will soon update the bisect info.

Good build:51.0.2703.0
Bad Build:51.0.2704.2

 
Actual_theme.mov
2.2 MB Download
Labels: ReleaseBlock-Stable
as this is recent regression, adding RB-label please change if required.

Comment 3 by dbeam@chromium.org, Apr 21 2016

Cc: dschuyler@chromium.org
Status: Started (was: Assigned)
i can't actually reproduce this on Linux, but I can imagine what's happening

Comment 4 by dbeam@chromium.org, Apr 21 2016

Components: -UI>Browser>Themes UI>Settings
Labels: -Pri-1 -ReleaseBlock-Stable -Type-Bug-Regression -M-51 OS-Chrome Pri-2 Type-Bug

Comment 5 by dbeam@chromium.org, Apr 21 2016

dschuyler@ fixed other OSes here: crrev.com/1896283003
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/128077b165c9860d9c51f96bee506dba3cb505c9

commit 128077b165c9860d9c51f96bee506dba3cb505c9
Author: dbeam <dbeam@chromium.org>
Date: Fri Apr 22 00:02:55 2016

MD Settings: fix bug where "RESET THEME" opens theme gallery

R=dschuyler@chromium.org
BUG= 605075 

Review URL: https://codereview.chromium.org/1907843002

Cr-Commit-Position: refs/heads/master@{#388962}

[modify] https://crrev.com/128077b165c9860d9c51f96bee506dba3cb505c9/chrome/browser/resources/settings/appearance_page/appearance_page.html

Comment 7 by dbeam@chromium.org, Apr 22 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 	8329.0.0, 52.0.2734.0

Sign in to add a comment