New issue
Advanced search Search tips

Issue 605021 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Cube doesn't rotate in 'Cube 3D' experiment.

Reported by dchau...@etouch.net, Apr 20 2016

Issue description

Chrome Version: 52.0.2713.0 (Official Build)939788c10e98a18cb74d5311f8792105930d9bd9-refs/heads/master@{#388380} 32/64-bit.
OS: Windows(Aero enabled)

URL: http://paulrhayes.com/experiments/cube-3d/

What steps will reproduce the problem?
1. Launch chrome and go to above URL.
2. Press and hold up/down/left/right key from keyboard and observe.

Cube doesn't rotate.
Cube should rotate.

This is a regression issue, broken in M-51 series, will soon update other info.
 

Comment 1 by dchau...@etouch.net, Apr 20 2016

Labels: hasbisect OS-Linux OS-Mac
Owner: alancutter@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range;

Good build: 51.0.2696.0
Bad build: 51.0.2698.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/697d42b85a7a8e9f345d26bb99576c26b7d268a5..e7b73385a8c33c070b28992484dee9657bcefa02?pretty=fuller&n=50

Suspecting: r384489 ?

@alancutter: Kindly help to reassign if your changes are not related to this issue.	

Note: This issue is also reproducible on Mac and Linux OS.

Kindly review the attached screen-cast for reference.
Actual_behavior.mp4
1.0 MB Download
Expected_behavior.mp4
2.0 MB Download
Labels: ReleaseBlock-Stable
adding RB-label, please change if required.
Components: -IO>Keyboard -Blink>CSS>3D Blink>Animation
Looks like it's falling into matrix decomposition, investigating.
Labels: OS-Chrome
Reproducible in Chrome 51.0.2707.23/CrOS 8172.9.0 - Blaze
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b721ba4c7c32b789911cdf125f4871f9b442320b

commit b721ba4c7c32b789911cdf125f4871f9b442320b
Author: alancutter <alancutter@chromium.org>
Date: Tue Apr 26 04:33:00 2016

Don't decompose retargeted rotate() transform transitions

2D rotate() transform operations were always interpolating as 3D rotate()
operations.
This resulted in interpolations between interpolated 2D rotate()s and
matching 2D rotate()s using matrix decomposition as the operation
types no longer matched.

This change ensures non-matrix-decomposition interpolation between
rotate() operations produces the same type of rotate() operation.

BUG= 605021 

Review URL: https://codereview.chromium.org/1909863002

Cr-Commit-Position: refs/heads/master@{#389696}

[add] https://crrev.com/b721ba4c7c32b789911cdf125f4871f9b442320b/third_party/WebKit/LayoutTests/transitions/retargeted-matching-rotation-transforms.html
[modify] https://crrev.com/b721ba4c7c32b789911cdf125f4871f9b442320b/third_party/WebKit/Source/platform/transforms/RotateTransformOperation.cpp

Labels: Merge-Request-51

Comment 7 by tin...@google.com, Apr 27 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 8 by gov...@chromium.org, Apr 28 2016

Please merge your change to M51 branch 2704 before 5:00 PM PST, tomorrow (Friday), so we can take it in for next week M51 beta release. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 29 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/127afd1b0ee3a6c937e23cd3807f2f144789e41c

commit 127afd1b0ee3a6c937e23cd3807f2f144789e41c
Author: Alan Cutter <alancutter@chromium.org>
Date: Fri Apr 29 04:00:47 2016

Don't decompose retargeted rotate() transform transitions

2D rotate() transform operations were always interpolating as 3D rotate()
operations.
This resulted in interpolations between interpolated 2D rotate()s and
matching 2D rotate()s using matrix decomposition as the operation
types no longer matched.

This change ensures non-matrix-decomposition interpolation between
rotate() operations produces the same type of rotate() operation.

BUG= 605021 

Review URL: https://codereview.chromium.org/1909863002

Cr-Commit-Position: refs/heads/master@{#389696}
(cherry picked from commit b721ba4c7c32b789911cdf125f4871f9b442320b)

Review URL: https://codereview.chromium.org/1926063004 .

Cr-Commit-Position: refs/branch-heads/2704@{#303}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[add] https://crrev.com/127afd1b0ee3a6c937e23cd3807f2f144789e41c/third_party/WebKit/LayoutTests/transitions/retargeted-matching-rotation-transforms.html
[modify] https://crrev.com/127afd1b0ee3a6c937e23cd3807f2f144789e41c/third_party/WebKit/Source/platform/transforms/RotateTransformOperation.cpp

Status: Fixed (was: Assigned)
Labels: TE-Verified-51.0.2704.36 TE-Verified-M51
Tested the issue on Windows 7, Mac 10.10.5, Ubuntu 14.04 using 51.0.2704.36.Observed that cube rotated when press and hold up/down/left/right key from keyboard.
Please find attached screencast.

Marking it as TE-Verified.
605021.mp4
2.4 MB Download
Status: Verified (was: Fixed)
Verified on 8172.39.0/51.0.2704.55

Sign in to add a comment