Regression: Cube doesn't rotate in 'Cube 3D' experiment.
Reported by
dchau...@etouch.net,
Apr 20 2016
|
||||||||||
Issue descriptionChrome Version: 52.0.2713.0 (Official Build)939788c10e98a18cb74d5311f8792105930d9bd9-refs/heads/master@{#388380} 32/64-bit. OS: Windows(Aero enabled) URL: http://paulrhayes.com/experiments/cube-3d/ What steps will reproduce the problem? 1. Launch chrome and go to above URL. 2. Press and hold up/down/left/right key from keyboard and observe. Cube doesn't rotate. Cube should rotate. This is a regression issue, broken in M-51 series, will soon update other info.
,
Apr 20 2016
adding RB-label, please change if required.
,
Apr 21 2016
Looks like it's falling into matrix decomposition, investigating.
,
Apr 22 2016
Reproducible in Chrome 51.0.2707.23/CrOS 8172.9.0 - Blaze
,
Apr 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b721ba4c7c32b789911cdf125f4871f9b442320b commit b721ba4c7c32b789911cdf125f4871f9b442320b Author: alancutter <alancutter@chromium.org> Date: Tue Apr 26 04:33:00 2016 Don't decompose retargeted rotate() transform transitions 2D rotate() transform operations were always interpolating as 3D rotate() operations. This resulted in interpolations between interpolated 2D rotate()s and matching 2D rotate()s using matrix decomposition as the operation types no longer matched. This change ensures non-matrix-decomposition interpolation between rotate() operations produces the same type of rotate() operation. BUG= 605021 Review URL: https://codereview.chromium.org/1909863002 Cr-Commit-Position: refs/heads/master@{#389696} [add] https://crrev.com/b721ba4c7c32b789911cdf125f4871f9b442320b/third_party/WebKit/LayoutTests/transitions/retargeted-matching-rotation-transforms.html [modify] https://crrev.com/b721ba4c7c32b789911cdf125f4871f9b442320b/third_party/WebKit/Source/platform/transforms/RotateTransformOperation.cpp
,
Apr 26 2016
,
Apr 27 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 28 2016
Please merge your change to M51 branch 2704 before 5:00 PM PST, tomorrow (Friday), so we can take it in for next week M51 beta release. Thank you.
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/127afd1b0ee3a6c937e23cd3807f2f144789e41c commit 127afd1b0ee3a6c937e23cd3807f2f144789e41c Author: Alan Cutter <alancutter@chromium.org> Date: Fri Apr 29 04:00:47 2016 Don't decompose retargeted rotate() transform transitions 2D rotate() transform operations were always interpolating as 3D rotate() operations. This resulted in interpolations between interpolated 2D rotate()s and matching 2D rotate()s using matrix decomposition as the operation types no longer matched. This change ensures non-matrix-decomposition interpolation between rotate() operations produces the same type of rotate() operation. BUG= 605021 Review URL: https://codereview.chromium.org/1909863002 Cr-Commit-Position: refs/heads/master@{#389696} (cherry picked from commit b721ba4c7c32b789911cdf125f4871f9b442320b) Review URL: https://codereview.chromium.org/1926063004 . Cr-Commit-Position: refs/branch-heads/2704@{#303} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [add] https://crrev.com/127afd1b0ee3a6c937e23cd3807f2f144789e41c/third_party/WebKit/LayoutTests/transitions/retargeted-matching-rotation-transforms.html [modify] https://crrev.com/127afd1b0ee3a6c937e23cd3807f2f144789e41c/third_party/WebKit/Source/platform/transforms/RotateTransformOperation.cpp
,
Apr 29 2016
,
May 4 2016
Tested the issue on Windows 7, Mac 10.10.5, Ubuntu 14.04 using 51.0.2704.36.Observed that cube rotated when press and hold up/down/left/right key from keyboard. Please find attached screencast. Marking it as TE-Verified.
,
May 20 2016
Verified on 8172.39.0/51.0.2704.55 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dchau...@etouch.net
, Apr 20 2016Owner: alancutter@chromium.org
Status: Assigned (was: Unconfirmed)
1.0 MB
1.0 MB Download
2.0 MB
2.0 MB Download